geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sai Boorlagadda <sboorlaga...@pivotal.io>
Subject Re: Review Request 49536: refactor TombstoneService and add more info to testTombstones
Date Wed, 06 Jul 2016 23:12:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49536/#review141099
-----------------------------------------------------------


Ship it!




Ship It!

- Sai Boorlagadda


On July 1, 2016, 10:13 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49536/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 10:13 p.m.)
> 
> 
> Review request for geode, Eric Shu and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-1420
>     https://issues.apache.org/jira/browse/GEODE-1420
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> testTombstones has a history of intermittently failing.
> I fixed some race conditions in the product and added more information to the assertion
message if the test fails again.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/CacheTime.java PRE-CREATION

>   geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DSClock.java d13610a399242295eb789db08fb165eaee093829

>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
6ee4c17d81b1486b0a0c772ba6e0ae7867bb9e4f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
bc919fc69a46946b8a195fb8fe68a1d11b96d04e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e0f6fa285914a0af3897b47ff04e18ef74750cbc

>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
186ebbcae83de759809bc881abb0cf5e59623d3d 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java
55bdde4c6488979a9d790e28f2fbcac53a02255a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 205f38f9b7829caedd1a29cce8b306942429fac2

>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TombstoneService.java
7036d452bd63da63741aa0dcc8e1b66e83073199 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java
c4b48f43cecfc5afc98ffe7636d05a8c8f4adf67 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java
652bd6bf7c1f52836cd8c496b40376bdd7b7ce6b 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/GlobalRegionCCEDUnitTest.java
1458e4f1258adaec1e053b2bef2cb4740a7321ec 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java a8a512eafec7f1b42834c4c83901842dd94af998

>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java
c92a436123b9fbe1220658045cc33c846dda3cf6 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java
bdadd8a3f229e9b8cbf5401fcc9fd48170eb747d 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TombstoneCreationJUnitTest.java
3eeddf5bcdb2f5e7d3032c88aa9c7467851f4aec 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/persistence/PersistentRVVRecoveryDUnitTest.java
f7c011d1301da6ab992838717419f99bd17b8653 
> 
> Diff: https://reviews.apache.org/r/49536/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message