geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruce Schuchardt <bschucha...@pivotal.io>
Subject Re: Review Request 49666: GEODE-1613 CI failure: ConnectionPoolDUnitTest.test021ClientGetOfInvalidServerEntry
Date Tue, 05 Jul 2016 23:21:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49666/
-----------------------------------------------------------

(Updated July 5, 2016, 11:21 p.m.)


Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.


Bugs: GEODE-1613
    https://issues.apache.org/jira/browse/GEODE-1613


Repository: geode


Description
-------

The suspect string that caused this test to fail showed that the executor being used had been
terminated.  The code scheduling a task in this executor needs to perform a cancellation check
if execution is rejected.

I rewrote all of the other cancellation checks in this method to avoid throwing Cancel exceptions
during shutdown.  There's no reason for it to do that - it can just exit the run() method.


Diffs (updated)
-----

  geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/DataSerializerRecoveryListener.java
0c3f69229a3bdbbe8fea66f7e5dc893d460e2785 

Diff: https://reviews.apache.org/r/49666/diff/


Testing
-------


Thanks,

Bruce Schuchardt


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message