Mailing-List: contact dev-help@geode.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.incubator.apache.org
From: Nitin Lamba <nitin@ampool.io>
To: "dev@geode.incubator.apache.org" <dev@geode.incubator.apache.org>
Subject: Re: Source distribution
Thread-Topic: Source distribution
Thread-Index: AQHRQ8xNBDFz7mjMtEGP3dfFO5wqwp7rwLHJgAAHnwCAABSsPQ==
Date: Mon, 4 Jan 2016 21:00:56 +0000
Message-ID: 
 <BY2PR10MB0615035662E514D3DFEEDEF5B6F20@BY2PR10MB0615.namprd10.prod.outlook.com>
References: <2AE596A1-4EC4-4C56-97DE-B5085D9F29FE@pivotal.io>
 <BY2PR10MB0615F0F2EDB911F8D662E5BCB6F20@BY2PR10MB0615.namprd10.prod.outlook.com>,<B8FD916D-DA33-4A9E-BD20-29B8FC35F5EC@pivotal.io>
In-Reply-To: <B8FD916D-DA33-4A9E-BD20-29B8FC35F5EC@pivotal.io>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: ampool.io does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2016 21:00:56.5418
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cc74c336-6612-4331-bc36-5d89c60e6d89
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR10MB0616

I didn't build locally but picked the artifacts that are getting posted fro=
m CI:

https://builds.apache.org/job/Geode-nightly/lastSuccessfulBuild/artifact/ge=
mfire-assembly/build/distributions/apache-geode-src-1.0.0-incubating-SNAPSH=
OT.tar.gz

All the java files I checked still had Pivotal copyright. Also, gemfire-jgr=
oups/src/main/java directory is non-empty and has LGPL headers. Perhaps, Je=
nkins scripts need to be fixed.

- Nitin

________________________________________
From: Anthony Baker <abaker@pivotal.io>
Sent: Monday, January 4, 2016 11:41 AM
To: dev@geode.incubator.apache.org
Subject: Re: Source distribution

Hmmm, that sounds odd.  The srcDistTar task uses the current working copy. =
 You might try a `git clean -fd` to remove all non-version controlled artif=
acts (be careful!).

Which copyrights are missing?  Here=92s what I see in the src distribution:

Anthony-Baker-MacBook-Pro:distributions abaker$ head apache-geode-src-1.0.0=
-incubating-SNAPSHOT/build.gradle
/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *

The LGPL jgroups source dependency has been removed.  We still have a binar=
y dependency on an ASLv2 licensed version of jgroups for reliable mcast com=
munication.

Anthony


> On Jan 4, 2016, at 11:21 AM, Nitin Lamba <nitin@ampool.io> wrote:
>
> Thanks Anthony!! This is great progress as the community marches towards =
the first GEODE release!
>
> Besides the missing LICENSE and NOTICE files (you have a separate thread =
on GEODE-610), I noticed a few things in the src artifact:
> - The copyright updates are missing
> - It still has jgroups/ LGPL files
>
> Do you know if the srcDistTar getting generated from 'master'? Once the r=
elease is cut, it'll probably pick-up the latest changes from develop so ma=
ybe this is intentional. I'll check the gradle file on my end too.
>
> -Nitin
> PS: I've updated the release wiki page with the latest status:
> https://cwiki.apache.org/confluence/display/GEODE/1.0.0-alpha1+%28First%2=
9+Release
>
> ________________________________________
> From: Anthony Baker <abaker@pivotal.io>
> Sent: Thursday, December 31, 2015 5:08 AM
> To: dev@geode.incubator.apache.org
> Subject: Source distribution
>
> I added a build command for creating a source distribution (see GEODE-627=
):
>
> `gradle srcDistTar`
>
> A normal build will create both the binary and src tar/zip files.
>
> Anthony-Baker-MacBook-Pro:incubator-geode abaker$ ls -l gemfire-assembly/=
build/distributions/
> total 404040
> -rw-r--r--  1 abaker  staff  89908576 Dec 31 06:53 apache-geode-1.0.0-inc=
ubating-SNAPSHOT.tar.gz
> -rw-r--r--  1 abaker  staff  89923450 Dec 31 06:53 apache-geode-1.0.0-inc=
ubating-SNAPSHOT.zip
> -rw-r--r--  1 abaker  staff  10381760 Dec 31 06:59 apache-geode-src-1.0.0=
-incubating-SNAPSHOT.tar.gz
> -rw-r--r--  1 abaker  staff  16648398 Dec 31 06:57 apache-geode-src-1.0.0=
-incubating-SNAPSHOT.zip
>
>
> Anthony
>