Return-Path: X-Original-To: apmail-geode-dev-archive@minotaur.apache.org Delivered-To: apmail-geode-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E19FA1816A for ; Thu, 7 Jan 2016 01:03:36 +0000 (UTC) Received: (qmail 9778 invoked by uid 500); 7 Jan 2016 01:03:36 -0000 Delivered-To: apmail-geode-dev-archive@geode.apache.org Received: (qmail 9733 invoked by uid 500); 7 Jan 2016 01:03:36 -0000 Mailing-List: contact dev-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list dev@geode.incubator.apache.org Received: (qmail 9722 invoked by uid 99); 7 Jan 2016 01:03:36 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jan 2016 01:03:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 19EB31A0987 for ; Thu, 7 Jan 2016 01:03:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.427 X-Spam-Level: *** X-Spam-Status: No, score=3.427 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ObZnhlUZuEJ6 for ; Thu, 7 Jan 2016 01:03:35 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 2926520515 for ; Thu, 7 Jan 2016 01:03:33 +0000 (UTC) Received: (qmail 9709 invoked by uid 99); 7 Jan 2016 01:03:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jan 2016 01:03:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AE7162989A0; Thu, 7 Jan 2016 01:03:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0665792508105840100==" MIME-Version: 1.0 Subject: Review Request 42008: GEODE-701: fix double free in unit test From: "Darrel Schneider" To: "Scott Jewell" , "Swapnil Bawaskar" Cc: "geode" , "Darrel Schneider" Date: Thu, 07 Jan 2016 01:03:31 -0000 Message-ID: <20160107010331.26044.39941@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Darrel Schneider" X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42008/ X-Sender: "Darrel Schneider" Reply-To: "Darrel Schneider" X-ReviewRequest-Repository: geode --===============0665792508105840100== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42008/ ----------------------------------------------------------- Review request for geode, Scott Jewell and Swapnil Bawaskar. Bugs: GEODE-701 https://issues.apache.org/jira/browse/GEODE-701 Repository: geode Description ------- The failure was caused by LifecycleListenerJUnitTest setting a system property and then not unsetting it when it completed. testClose now asserts that the system property must be initially false when it runs. LifecycleListenerJUnitTest now unsets the property in a finally block after setting it. Diffs ----- gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java c886e4372559055f1724f9f66cd97d7af73fd41b gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java 6bc488dc797d0560d7f6a0b7278609abfd78fa7a Diff: https://reviews.apache.org/r/42008/diff/ Testing ------- Ran LifecycleListenerJUnitTest and SimpleMemoryAllocatorJUnitTest. Thanks, Darrel Schneider --===============0665792508105840100==--