Return-Path: X-Original-To: apmail-geode-dev-archive@minotaur.apache.org Delivered-To: apmail-geode-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C651185F7 for ; Wed, 6 Jan 2016 21:43:36 +0000 (UTC) Received: (qmail 11008 invoked by uid 500); 6 Jan 2016 21:43:36 -0000 Delivered-To: apmail-geode-dev-archive@geode.apache.org Received: (qmail 10963 invoked by uid 500); 6 Jan 2016 21:43:36 -0000 Mailing-List: contact dev-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list dev@geode.incubator.apache.org Received: (qmail 10952 invoked by uid 99); 6 Jan 2016 21:43:35 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2016 21:43:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 79195C0DE0 for ; Wed, 6 Jan 2016 21:43:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.628 X-Spam-Level: **** X-Spam-Status: No, score=4.628 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id LcPasSkbBF7I for ; Wed, 6 Jan 2016 21:43:34 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 6622031ABF for ; Wed, 6 Jan 2016 21:43:33 +0000 (UTC) Received: (qmail 10938 invoked by uid 99); 6 Jan 2016 21:43:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2016 21:43:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F28E129831B; Wed, 6 Jan 2016 21:43:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0139923782031705443==" MIME-Version: 1.0 Subject: Review Request 41991: GEODE-245 QueryMonitor cancellation is being ignored by query using CompactRangeIndex From: "Jason Huynh" To: "Jianxia Chen" , "Hitesh Khamesra" , "anilkumar gingade" , "Bruce Schuchardt" Cc: "Jason Huynh" , "geode" Date: Wed, 06 Jan 2016 21:43:30 -0000 Message-ID: <20160106214330.26043.12055@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jason Huynh" X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41991/ X-Sender: "Jason Huynh" Reply-To: "Jason Huynh" X-ReviewRequest-Repository: geode --===============0139923782031705443== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41991/ ----------------------------------------------------------- Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen. Repository: geode Description ------- Compact Range Index was not checking if query had been cancelled while iterating through the indexed values Moved testhook to pause the executing query instead of the query monitor thread Removed test code from QueryMonitor that suppressed/worked around itermittent failures. Diffs ----- gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/DefaultQuery.java 9419d04 gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/QueryMonitor.java 65a64a4 gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/CompactRangeIndex.java 41e2ea4 Diff: https://reviews.apache.org/r/41991/diff/ Testing ------- Thanks, Jason Huynh --===============0139923782031705443==--