Return-Path: X-Original-To: apmail-geode-dev-archive@minotaur.apache.org Delivered-To: apmail-geode-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2B3A1858D for ; Wed, 6 Jan 2016 21:30:59 +0000 (UTC) Received: (qmail 82801 invoked by uid 500); 6 Jan 2016 21:30:59 -0000 Delivered-To: apmail-geode-dev-archive@geode.apache.org Received: (qmail 82759 invoked by uid 500); 6 Jan 2016 21:30:59 -0000 Mailing-List: contact dev-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list dev@geode.incubator.apache.org Received: (qmail 82748 invoked by uid 99); 6 Jan 2016 21:30:59 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2016 21:30:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0D9A31805CD for ; Wed, 6 Jan 2016 21:30:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.427 X-Spam-Level: *** X-Spam-Status: No, score=3.427 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id HC5aBjpFR6Jd for ; Wed, 6 Jan 2016 21:30:57 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 4234E2026F for ; Wed, 6 Jan 2016 21:30:55 +0000 (UTC) Received: (qmail 82111 invoked by uid 99); 6 Jan 2016 21:30:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2016 21:30:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AF38629831B; Wed, 6 Jan 2016 21:30:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1359860013409724226==" MIME-Version: 1.0 Subject: Re: Review Request 41992: Upgrade log4j2 from 2.1 to 2.5 From: "Jens Deppe" To: "Jens Deppe" , "Jinmei Liao" Cc: "geode" , "Kirk Lund" Date: Wed, 06 Jan 2016 21:30:53 -0000 Message-ID: <20160106213053.1209.5015@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jens Deppe" X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41992/ X-Sender: "Jens Deppe" References: <20160106195844.26043.64109@reviews.apache.org> In-Reply-To: <20160106195844.26043.64109@reviews.apache.org> Reply-To: "Jens Deppe" X-ReviewRequest-Repository: geode --===============1359860013409724226== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41992/#review113137 ----------------------------------------------------------- Ship it! Ship It! - Jens Deppe On Jan. 6, 2016, 7:58 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41992/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 7:58 p.m.) > > > Review request for geode, Jens Deppe and Jinmei Liao. > > > Bugs: GEODE-374 > https://issues.apache.org/jira/browse/GEODE-374 > > > Repository: geode > > > Description > ------- > > GEODE-374: Upgrade log4j2 from 2.1 to 2.5 (PR #67) > > Remove unused import statements from logging classes. > > Remove unused log4j2 classes: GemFireXmlConfigurationFactory, GemFireXmlConfiguration, GemFireFileConfigurationMonitor. These classes were copied from log4j2 2.1 with the plan to change GemFireFileConfigurationMonitor to use a background thread for monitoring as well as reconfiguring but no changes were ever made and these classes are unused. > > > Diffs > ----- > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java 8159966 > gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLogger.java c85b3f7 > gemfire-core/src/main/java/com/gemstone/org/apache/logging/log4j/core/config/GemFireFileConfigurationMonitor.java e6b2bb4 > gemfire-core/src/main/java/com/gemstone/org/apache/logging/log4j/core/config/xml/GemFireXmlConfiguration.java e31db04 > gemfire-core/src/main/java/com/gemstone/org/apache/logging/log4j/core/config/xml/GemFireXmlConfigurationFactory.java 4e9d7af > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4J2PerformanceTest.java a002389 > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLoggerPerformanceTest.java 61b5131 > gemfire-core/src/test/java/dunit/standalone/DUnitLauncher.java 72c33d6 > gradle/dependency-versions.properties 30a7fd8 > > Diff: https://reviews.apache.org/r/41992/diff/ > > > Testing > ------- > > LoggingUnitTestSuite, LoggingIntegrationTestSuite, Log4jUnitTestSuite, Log4jIntegrationTestSuite > precheckin (currently in-progress) > > > Thanks, > > Kirk Lund > > --===============1359860013409724226==--