geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Lamba <ni...@ampool.io>
Subject Re: Source distribution
Date Thu, 07 Jan 2016 02:11:22 GMT
Yes, makes sense to merge GEODE-610 before the release branch. Thanks!

@William - sure, whatever we decide; I'm easy :)

- Nitin
________________________________________
From: William Markito <wmarkito@pivotal.io>
Sent: Wednesday, January 6, 2016 5:26 PM
To: dev
Subject: Re: Source distribution

+1 for keeping incubating as part of the version since it's required during
incubation.  For the name of the branch, we're keeping it tied to the
version names, so if the version has it, so the branch....


On Wed, Jan 6, 2016 at 5:09 PM, Anthony Baker <abaker@pivotal.io> wrote:

> Also, I should merge the initial changes on feature/GEODE-610 to develop
> before creating the release branch.  There was an earlier thread requesting
> feedback on that work [1].
>
> Anthony
>
> [1]
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201601.mbox/%3c7889921B-97EB-4ECD-8F39-9FBDFEB013DB@pivotal.io%3e
>
>
> > On Jan 6, 2016, at 4:59 PM, Anthony Baker <abaker@pivotal.io> wrote:
> >
> > I can create the release branch if we’re in agreement on the name:
> release/1.0.0-incubating-alpha1
> >
> > I’ve done an initial round of work on GEODE-610.  I think we need input
> and review from our mentors in order to mark it as resolved.  If you have
> other suggestions for how to continue that please let me know (and many
> thanks to Niall for all the IP work!)
> >
> > I’ll push the DISCLAIMER changes now.
> >
> > Anthony
> >
> >
> >> On Jan 6, 2016, at 4:52 PM, Nitin Lamba <nitin@ampool.io> wrote:
> >>
> >> The DISCLAIMER language looks accurate from [1]!
> >>
> >> Anthony,
> >>
> >> Who can help create a release branch in git? I certainly don't have the
> git karma to do it. Also, we can merge LICENSE, NOTICE and DISCLAIMER
> directly into this release branch whenever it is ready?
> >>
> >> Also, do you know if anyone is working on GEODE-610? As per JIRA, it is
> not assigned and not marked 'in progress'.
> >>
> >> Thanks,
> >> Nitin
> >>
> >> [1] http://incubator.apache.org/guides/branding.html#disclaimers
> >>
> >> ________________________________________
> >> From: Anthony Baker <abaker@pivotal.io>
> >> Sent: Wednesday, January 6, 2016 4:09 PM
> >> To: dev@geode.incubator.apache.org
> >> Subject: Re: Source distribution
> >>
> >> Is there a good reason to use the Jenkins artifacts?  Seems like it
> would be preferable to create artifacts from a clean working dir (or maybe
> fix Jenkins to put temporary files elsewhere).
> >>
> >> The DISCLAIMER should look like this I believe:
> >>
> >> Apache Geode is an effort undergoing incubation at The Apache Software
> Foundation (ASF),
> >> sponsored by the Apache Incubator. Incubation is required of all newly
> accepted projects until
> >> a further review indicates that the infrastructure, communications, and
> decision making process
> >> have stabilized in a manner consistent with other successful ASF
> projects. While incubation
> >> status is not necessarily a reflection of the completeness or stability
> of the code, it does
> >> indicate that the project has yet to be fully endorsed by the ASF.
> >>
> >>
> >> Anthony
> >>
> >>
> >>> On Jan 6, 2016, at 4:01 PM, Niall Pemberton <niall.pemberton@gmail.com>
> wrote:
> >>>
> >>> On Mon, Jan 4, 2016 at 10:43 PM, Nitin Lamba <nitin@ampool.io> wrote:
> >>>
> >>>> You're right Anthony - my bad.
> >>>>
> >>>> I did download the archive but accidentally opened the older tar.gz
> from
> >>>> April, 2015:
> >>>> geode-1.0.0.0-SNAPSHOT.src.tar.gz
> >>>> (the original source contributed to Apache).
> >>>>
> >>>> All's good now. Yes, did notice few extra folders but fixing that may
> be
> >>>> low priority.
> >>>>
> >>>
> >>> The extra folders will be a blocker because two of them contain
> external
> >>> jars
> >>>
> >>> - caches (contains dependency jar & class files)
> >>> - daemon
> >>> - native
> >>> - wrapper (contains gradle jar files)
> >>>
> >>> Also, incubator releases have to contain the DISCLAIMER, NOTICE &
> LICENSE
> >>> files - but perhaps thats being done in a separate branch.
> >>>
> >>> Niall
> >>>
> >>>
> >>>> - Nitin
> >>>>
> >>>> ________________________________________
> >>>> From: Anthony Baker <abaker@pivotal.io>
> >>>> Sent: Monday, January 4, 2016 2:25 PM
> >>>> To: dev@geode.incubator.apache.org
> >>>> Subject: Re: Source distribution
> >>>>
> >>>> I wonder if we’re looking at different things??
> >>>>
> >>>> When I download the night-build tarball at [1], I only found one
> Pivotal
> >>>> copyright:
> >>>>
> >>>> Anthony-Baker-MacBook-Pro:tmp abaker$ tar xf
> >>>> ~/Downloads/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar &&
grep -r
> >>>> Pivotal apache-geode-src-1.0.0-incubating-SNAPSHOT | grep -i copy
> >>>>
> apache-geode-src-1.0.0-incubating-SNAPSHOT/gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/InstantiatorPropagationDUnitTest.java:
> >>>> * Copyright (c) 2010-2014 Pivotal Software, Inc. All Rights Reserved.
> >>>>
> >>>> In addition, I didn’t see gemfire-jgroups at all:
> >>>>
> >>>> Anthony-Baker-MacBook-Pro:tmp abaker$ tar xf
> >>>> ~/Downloads/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar &&
find
> >>>> apache-geode-src-1.0.0-incubating-SNAPSHOT -name "gemfire-jgroups"
> >>>> Anthony-Baker-MacBook-Pro:tmp abaker$
> >>>>
> >>>> I do see that the jenkins build is including up some extra dirs
> (caches,
> >>>> daemon, ...) in the source distribution that don’t exist in a clean
> working
> >>>> directory.
> >>>>
> >>>> Anthony
> >>>>
> >>>>
> >>>> [1]
> >>>>
> https://builds.apache.org/job/Geode-nightly/lastSuccessfulBuild/artifact/gemfire-assembly/build/distributions/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar.gz
> >>>>
> >>>>
> >>>>> On Jan 4, 2016, at 1:45 PM, Bruce Schuchardt <bschuchardt@pivotal.io
> >
> >>>> wrote:
> >>>>>
> >>>>> The gemfire-jgroups project has been deleted on the develop branch.
> That
> >>>> happened when feature/GEODE-77 was merged to develop.  If it's still
> >>>> sitting around in a checkout it should be deleted.
> >>>>>
> >>>>> Le 1/4/2016 1:00 PM, Nitin Lamba a écrit :
> >>>>>> I didn't build locally but picked the artifacts that are getting
> posted
> >>>> from CI:
> >>>>>>
> >>>>>>
> >>>>
> https://builds.apache.org/job/Geode-nightly/lastSuccessfulBuild/artifact/gemfire-assembly/build/distributions/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar.gz
> >>>>>>
> >>>>>> All the java files I checked still had Pivotal copyright. Also,
> >>>> gemfire-jgroups/src/main/java directory is non-empty and has LGPL
> headers.
> >>>> Perhaps, Jenkins scripts need to be fixed.
> >>>>>>
> >>>>>> - Nitin
> >>>>>>
> >>>>>> ________________________________________
> >>>>>> From: Anthony Baker <abaker@pivotal.io>
> >>>>>> Sent: Monday, January 4, 2016 11:41 AM
> >>>>>> To: dev@geode.incubator.apache.org
> >>>>>> Subject: Re: Source distribution
> >>>>>>
> >>>>>> Hmmm, that sounds odd.  The srcDistTar task uses the current
working
> >>>> copy.  You might try a `git clean -fd` to remove all non-version
> controlled
> >>>> artifacts (be careful!).
> >>>>>>
> >>>>>> Which copyrights are missing?  Here’s what I see in the src
> >>>> distribution:
> >>>>>>
> >>>>>> Anthony-Baker-MacBook-Pro:distributions abaker$ head
> >>>> apache-geode-src-1.0.0-incubating-SNAPSHOT/build.gradle
> >>>>>> /*
> >>>>>> * Licensed to the Apache Software Foundation (ASF) under one
or more
> >>>>>> * contributor license agreements.  See the NOTICE file distributed
> with
> >>>>>> * this work for additional information regarding copyright
> ownership.
> >>>>>> * The ASF licenses this file to You under the Apache License,
> Version
> >>>> 2.0
> >>>>>> * (the "License"); you may not use this file except in compliance
> with
> >>>>>> * the License.  You may obtain a copy of the License at
> >>>>>> *
> >>>>>> *      http://www.apache.org/licenses/LICENSE-2.0
> >>>>>> *
> >>>>>>
> >>>>>> The LGPL jgroups source dependency has been removed.  We still
have
> a
> >>>> binary dependency on an ASLv2 licensed version of jgroups for reliable
> >>>> mcast communication.
> >>>>>>
> >>>>>> Anthony
> >>>>>>
> >>>>>>
> >>>>>>> On Jan 4, 2016, at 11:21 AM, Nitin Lamba <nitin@ampool.io>
wrote:
> >>>>>>>
> >>>>>>> Thanks Anthony!! This is great progress as the community
marches
> >>>> towards the first GEODE release!
> >>>>>>>
> >>>>>>> Besides the missing LICENSE and NOTICE files (you have a
separate
> >>>> thread on GEODE-610), I noticed a few things in the src artifact:
> >>>>>>> - The copyright updates are missing
> >>>>>>> - It still has jgroups/ LGPL files
> >>>>>>>
> >>>>>>> Do you know if the srcDistTar getting generated from 'master'?
Once
> >>>> the release is cut, it'll probably pick-up the latest changes from
> develop
> >>>> so maybe this is intentional. I'll check the gradle file on my end
> too.
> >>>>>>>
> >>>>>>> -Nitin
> >>>>>>> PS: I've updated the release wiki page with the latest status:
> >>>>>>>
> >>>>
> https://cwiki.apache.org/confluence/display/GEODE/1.0.0-alpha1+%28First%29+Release
> >>>>>>>
> >>>>>>> ________________________________________
> >>>>>>> From: Anthony Baker <abaker@pivotal.io>
> >>>>>>> Sent: Thursday, December 31, 2015 5:08 AM
> >>>>>>> To: dev@geode.incubator.apache.org
> >>>>>>> Subject: Source distribution
> >>>>>>>
> >>>>>>> I added a build command for creating a source distribution
(see
> >>>> GEODE-627):
> >>>>>>>
> >>>>>>> `gradle srcDistTar`
> >>>>>>>
> >>>>>>> A normal build will create both the binary and src tar/zip
files.
> >>>>>>>
> >>>>>>> Anthony-Baker-MacBook-Pro:incubator-geode abaker$ ls -l
> >>>> gemfire-assembly/build/distributions/
> >>>>>>> total 404040
> >>>>>>> -rw-r--r--  1 abaker  staff  89908576 Dec 31 06:53
> >>>> apache-geode-1.0.0-incubating-SNAPSHOT.tar.gz
> >>>>>>> -rw-r--r--  1 abaker  staff  89923450 Dec 31 06:53
> >>>> apache-geode-1.0.0-incubating-SNAPSHOT.zip
> >>>>>>> -rw-r--r--  1 abaker  staff  10381760 Dec 31 06:59
> >>>> apache-geode-src-1.0.0-incubating-SNAPSHOT.tar.gz
> >>>>>>> -rw-r--r--  1 abaker  staff  16648398 Dec 31 06:57
> >>>> apache-geode-src-1.0.0-incubating-SNAPSHOT.zip
> >>>>>>>
> >>>>>>>
> >>>>>>> Anthony
> >>>>>>>
> >>>>>
> >>>>
> >>>>
> >>
> >
>
>


--

William Markito Oliveira
-- For questions about Apache Geode, please write to
*dev@geode.incubator.apache.org
<dev@geode.incubator.apache.org>*

Mime
View raw message