geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anthony Baker <aba...@pivotal.io>
Subject Re: Review for GemFire Session Replication and Hibernate Modules
Date Wed, 06 Jan 2016 17:34:59 GMT
Probably once we decide we are ready to begin the release process we should create a release/XXX
branch following the gitflow process.

Anthony

> On Jan 6, 2016, at 9:02 AM, Jens Deppe <jdeppe@pivotal.io> wrote:
> 
> I can merge any time. I'm OK to wait (or not) as needed.
> 
> --Jens
> 
> On Wed, Jan 6, 2016 at 8:55 AM, Anthony Baker <abaker@pivotal.io> wrote:
> 
>> How close are you to merging?  I think we’re probably *really* close to
>> being ready for an alpha1 release and it would be nice not to have to redo
>> all the IP work before then.
>> 
>> Anthony
>> 
>> 
>>> On Jan 5, 2016, at 6:15 PM, Jens Deppe <jdeppe@pivotal.io> wrote:
>>> 
>>> Yes, that's right. All of the tests are categorized appropriately and run
>>> as part of 'test' or 'integrationTest' (there are no DUnit tests).
>>> 
>>> --Jens
>>> 
>>> On Tue, Jan 5, 2016 at 4:26 PM, Dan Smith <dsmith@pivotal.io> wrote:
>>> 
>>>> After the merge, the session replication and hibernate tests will run as
>>>> part of precheckin, correct?
>>>> 
>>>> -Dan
>>>> 
>>>> On Tue, Jan 5, 2016 at 12:59 PM, Jens Deppe <jdeppe@pivotal.io> wrote:
>>>> 
>>>>> Hello All,
>>>>> 
>>>>> Just a quick bump to request a review on this work which brings the
>>>> GemFire
>>>>> Session Replication and Hibernate modules onto the main branch.
>>>>> 
>>>>> https://reviews.apache.org/r/41802/
>>>>> 
>>>>> I know it's a lot of unknown code. It's coming over basically
>> unmodified
>>>>> from it's original source. Some changes to highlight:
>>>>> 
>>>>> 
>>>>>  - The Gradle modules have been placed under an *extensions/*
>> directory
>>>>>  and are referenced as *:extensions/gemfire-module**.
>>>>>  - Some of the original maven modules have been consolidated.
>>>>>  Specifically gemfire-modules-session,
>> gemfire-modules-session-external
>>>>> and
>>>>>  gemfire-modules-session-integration-test are now all contained within
>>>>>  *:extensions/gemfire-modules-session*.
>>>>>  - The original code allows for WAN replication to be configured. The
>>>>>  hooks to enable this have been commented out.
>>>>>  - A change to the overall build process now enables transitive
>>>>>  dependencies for testing configurations. This means transitive test
>>>>>  dependencies don't need to clutter up
>>>>>  *gradle/dependency-versions.properties*.
>>>>>  - The module artifacts are produced with the gradle task
>>>>>  *extensions/gemfire-modules-assembly:dist*. This task still needs to
>>>> be
>>>>>  included into the overall product distribution creation.
>>>>> 
>>>>> Please either comment in this thread with general questions or in the
>>>>> review request with questions or issues relevant to the code.
>>>>> 
>>>>> Thanks
>>>>> --Jens
>>>>> 
>>>> 
>> 
>> 


Mime
View raw message