geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darrel Schneider" <dschnei...@pivotal.io>
Subject Review Request 42008: GEODE-701: fix double free in unit test
Date Thu, 07 Jan 2016 01:03:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42008/
-----------------------------------------------------------

Review request for geode, Scott Jewell and Swapnil Bawaskar.


Bugs: GEODE-701
    https://issues.apache.org/jira/browse/GEODE-701


Repository: geode


Description
-------

The failure was caused by LifecycleListenerJUnitTest setting
a system property and then not unsetting it when it completed.
testClose now asserts that the system property must be initially
false when it runs.
LifecycleListenerJUnitTest now unsets the property in a finally
block after setting it.


Diffs
-----

  gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java
c886e4372559055f1724f9f66cd97d7af73fd41b 
  gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java
6bc488dc797d0560d7f6a0b7278609abfd78fa7a 

Diff: https://reviews.apache.org/r/42008/diff/


Testing
-------

Ran LifecycleListenerJUnitTest and SimpleMemoryAllocatorJUnitTest.


Thanks,

Darrel Schneider


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message