geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kirk Lund" <kirk.l...@gmail.com>
Subject Review Request 41992: Upgrade log4j2 from 2.1 to 2.5
Date Wed, 06 Jan 2016 19:58:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41992/
-----------------------------------------------------------

Review request for geode, Jens Deppe and Jinmei Liao.


Bugs: GEODE-374
    https://issues.apache.org/jira/browse/GEODE-374


Repository: geode


Description
-------

GEODE-374: Upgrade log4j2 from 2.1 to 2.5 (PR #67)

Remove unused import statements from logging classes.

Remove unused log4j2 classes: GemFireXmlConfigurationFactory, GemFireXmlConfiguration, GemFireFileConfigurationMonitor.
These classes were copied from log4j2 2.1 with the plan to change GemFireFileConfigurationMonitor
to use a background thread for monitoring as well as reconfiguring but no changes were ever
made and these classes are unused.


Diffs
-----

  gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java 8159966

  gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLogger.java
c85b3f7 
  gemfire-core/src/main/java/com/gemstone/org/apache/logging/log4j/core/config/GemFireFileConfigurationMonitor.java
e6b2bb4 
  gemfire-core/src/main/java/com/gemstone/org/apache/logging/log4j/core/config/xml/GemFireXmlConfiguration.java
e31db04 
  gemfire-core/src/main/java/com/gemstone/org/apache/logging/log4j/core/config/xml/GemFireXmlConfigurationFactory.java
4e9d7af 
  gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4J2PerformanceTest.java
a002389 
  gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterLoggerPerformanceTest.java
61b5131 
  gemfire-core/src/test/java/dunit/standalone/DUnitLauncher.java 72c33d6 
  gradle/dependency-versions.properties 30a7fd8 

Diff: https://reviews.apache.org/r/41992/diff/


Testing
-------

LoggingUnitTestSuite, LoggingIntegrationTestSuite, Log4jUnitTestSuite, Log4jIntegrationTestSuite
precheckin (currently in-progress)


Thanks,

Kirk Lund


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message