geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From heyba...@apache.org
Subject [geode-benchmarks] 05/05: write each test only once
Date Thu, 05 Dec 2019 22:11:54 GMT
This is an automated email from the ASF dual-hosted git repository.

heybales pushed a commit to branch GEODE-7554
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git

commit 9057a37c29e65f5235e41d2247979098c9160534
Author: Helena A. Bales <hbales@pivotal.io>
AuthorDate: Thu Dec 5 13:06:02 2019 -0800

    write each test only once
    
    Signed-off-by: Robert Houghton <rhoughton@pivotal.io>
---
 .../src/main/java/org/apache/geode/perftest/analysis/Analyzer.java   | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
index 0ab8785..f4cca01 100644
--- a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
+++ b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
@@ -84,22 +84,21 @@ public class Analyzer {
         if (isNaN(probeResult.baseline) || isNaN(probeResult.test)) {
           errorMessage.append("BENCHMARK FAILED: ").append(benchmarkResult.name)
               .append(" missing result file.\n");
-          writer.append(benchmarkResult.name + "\n");
         } else if (probeResult.description.equals("average latency")) {
           if (probeResult.getDifference() > 0) {
             isHighWaterCandidate = false;
             if (probeResult.getDifference() >= 0.05) {
               errorMessage.append("BENCHMARK FAILED: ").append(benchmarkResult.name)
                   .append(" average latency is 5% worse than baseline.\n");
-              writer.append(benchmarkResult.name + "\n");
             }
           } else if (probeResult.getDifference() <= -0.5) {
             isSignificantlyBetter = true;
           }
         }
       }
-      writer.close();
+      writer.append(benchmarkResult.name + "\n");
     }
+    writer.close();
 
     if (isCI && isHighWaterCandidate && isSignificantlyBetter) {
       System.out.println(


Mime
View raw message