geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From upthewatersp...@apache.org
Subject [geode] branch develop updated (6bec09f -> a0296b7)
Date Wed, 13 Feb 2019 23:07:19 GMT
This is an automated email from the ASF dual-hosted git repository.

upthewaterspout pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git.


    from 6bec09f  GEODE-6395: Use md5 as Spotless cache value. (#3186)
     new 470001c  GEODE-6380: Deleting some unused mutable statics
     new 803f00e  GEODE-6380: Adding annotations for documenting static fields
     new 0f2bf79  GEODE-6380: Annotating static fields
     new 314df6d  GEODE-6380: Adding a PMD rule for static fields.
     new a0296b7  Merge pull request #3178 from upthewaterspout/feature/pmd

The 7363 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../internal/web/controllers/RestTestUtils.java    | 107 ---------------------
 .../integrationTest/resources/assembly_content.txt |   1 +
 .../{VisibleForTesting.java => Immutable.java}     |  16 +--
 .../MakeImmutable.java}                            |  19 ++--
 .../MakeNotStatic.java}                            |  18 ++--
 .../MutableForTesting.java}                        |  18 ++--
 geode-core/build.gradle                            |   1 +
 .../main/java/org/apache/geode/DataSerializer.java |   2 +
 .../main/java/org/apache/geode/StatisticsType.java |   3 +
 .../main/java/org/apache/geode/SystemFailure.java  |  17 ++++
 .../java/org/apache/geode/admin/AlertLevel.java    |   9 ++
 .../geode/admin/DistributedSystemConfig.java       |   2 +
 .../java/org/apache/geode/admin/GemFireHealth.java |   7 +-
 .../org/apache/geode/admin/SystemMemberType.java   |  10 ++
 .../admin/internal/AdminDistributedSystemImpl.java |   2 +
 .../geode/admin/internal/CacheServerImpl.java      |   2 +
 .../admin/internal/DistributionLocatorImpl.java    |   2 +
 .../geode/admin/internal/InetAddressUtil.java      |   3 +
 .../internal/ManagedEntityConfigXmlGenerator.java  |   2 +
 .../admin/jmx/internal/GenerateMBeanHTML.java      |   2 +
 .../apache/geode/admin/jmx/internal/MBeanUtil.java |   8 ++
 .../admin/jmx/internal/ManagedResourceType.java    |  18 ++++
 .../jmx/internal/MemberInfoWithStatsMBean.java     |   2 +
 .../jmx/internal/RefreshNotificationType.java      |   8 ++
 .../geode/admin/jmx/internal/SystemMemberJmx.java  |   2 +
 .../org/apache/geode/cache/AttributesFactory.java  |   2 +
 .../java/org/apache/geode/cache/DataPolicy.java    |  11 +++
 .../org/apache/geode/cache/DiskStoreFactory.java   |   3 +
 .../apache/geode/cache/DynamicRegionFactory.java   |   3 +
 .../org/apache/geode/cache/EvictionAction.java     |   8 ++
 .../org/apache/geode/cache/EvictionAlgorithm.java  |  10 ++
 .../apache/geode/cache/ExpirationAttributes.java   |   2 +
 .../org/apache/geode/cache/InterestPolicy.java     |   9 ++
 .../apache/geode/cache/InterestResultPolicy.java   |   8 ++
 .../java/org/apache/geode/cache/LossAction.java    |  11 +++
 .../java/org/apache/geode/cache/MirrorType.java    |   9 ++
 .../java/org/apache/geode/cache/Operation.java     |  55 +++++++++++
 .../org/apache/geode/cache/ResumptionAction.java   |   9 ++
 .../main/java/org/apache/geode/cache/Scope.java    |  10 ++
 .../asyncqueue/internal/AsyncEventQueueStats.java  |   2 +
 .../client/internal/AutoConnectionSourceImpl.java  |   5 +
 .../client/internal/ClientSideHandshakeImpl.java   |   2 +
 .../client/internal/ConnectionFactoryImpl.java     |   2 +
 .../cache/client/internal/ConnectionImpl.java      |   2 +
 .../cache/client/internal/ConnectionStats.java     |   4 +
 .../geode/cache/client/internal/DestroyOp.java     |   2 +
 .../internal/ExplicitConnectionSourceImpl.java     |   2 +
 .../geode/cache/client/internal/PoolImpl.java      |  14 +++
 .../cache/client/internal/QueueManagerImpl.java    |   3 +
 .../client/internal/SingleHopClientExecutor.java   |   2 +
 .../geode/cache/execute/FunctionService.java       |   2 +
 .../geode/cache/operations/InterestType.java       |   9 ++
 .../cache/query/internal/AttributeDescriptor.java  |   2 +
 .../cache/query/internal/CompiledOperation.java    |   2 +
 .../query/internal/CompiledSortCriterion.java      |   2 +
 .../geode/cache/query/internal/CompiledValue.java  |   4 +
 .../cache/query/internal/CqQueryVsdStats.java      |   2 +
 .../geode/cache/query/internal/DefaultQuery.java   |   7 ++
 .../cache/query/internal/DefaultQueryService.java  |   2 +
 .../geode/cache/query/internal/QueryMonitor.java   |   3 +
 .../cache/query/internal/QueryObserverHolder.java  |   5 +
 .../RestrictedMethodInvocationAuthorizer.java      |   2 +
 .../cache/query/internal/RuntimeIterator.java      |   2 +
 .../cache/query/internal/cq/CqAttributesImpl.java  |   2 +
 .../cache/query/internal/cq/CqServiceProvider.java |   4 +
 .../query/internal/index/CompactRangeIndex.java    |   3 +
 .../cache/query/internal/index/HashIndexSet.java   |   2 +
 .../cache/query/internal/index/IndexManager.java   |  12 ++-
 .../cache/query/internal/index/IndexStats.java     |   2 +
 .../cache/query/internal/index/IndexUtils.java     |   2 +
 .../cache/query/internal/index/MapIndexStore.java  |   2 +
 .../cache/query/internal/index/RangeIndex.java     |   2 +
 .../cache/query/internal/types/TypeUtils.java      |   5 +
 .../org/apache/geode/cache/server/CacheServer.java |   3 +
 .../server/internal/ConnectionCountProbe.java      |   2 +
 .../org/apache/geode/cache/util/ObjectSizer.java   |   4 +
 .../org/apache/geode/cache/wan/GatewaySender.java  |   2 +
 .../apache/geode/distributed/AbstractLauncher.java |   2 +
 .../geode/distributed/DistributedSystem.java       |   2 +
 .../apache/geode/distributed/LocatorLauncher.java  |   8 ++
 .../apache/geode/distributed/ServerLauncher.java   |   8 ++
 .../internal/AbstractDistributionConfig.java       |   4 +
 .../internal/ClusterDistributionManager.java       |   4 +
 .../distributed/internal/DistributionAdvisor.java  |   2 +
 .../distributed/internal/DistributionConfig.java   |   9 ++
 .../distributed/internal/DistributionMessage.java  |   2 +
 .../internal/DistributionMessageObserver.java      |   3 +
 .../distributed/internal/DistributionStats.java    |   4 +
 .../distributed/internal/HealthMonitorImpl.java    |   2 +
 .../internal/InternalDistributedSystem.java        |  12 +++
 .../distributed/internal/InternalLocator.java      |   2 +
 .../geode/distributed/internal/LocatorStats.java   |   2 +
 .../internal/LonerDistributionManager.java         |   2 +
 .../geode/distributed/internal/ProductUseLog.java  |   2 +
 .../distributed/internal/ReplyProcessor21.java     |   2 +
 .../geode/distributed/internal/ServerLocator.java  |   2 +
 .../internal/deadlock/DLockDependencyMonitor.java  |   2 +
 .../deadlock/DependencyMonitorManager.java         |   2 +
 .../deadlock/MessageDependencyMonitor.java         |   2 +
 .../locks/DLockRecoverGrantorProcessor.java        |   2 +
 .../internal/locks/DLockRequestProcessor.java      |   3 +
 .../distributed/internal/locks/DLockService.java   |  10 ++
 .../distributed/internal/locks/DLockStats.java     |   2 +
 .../internal/locks/DummyDLockStats.java            |   2 +
 .../internal/locks/GrantorRequestProcessor.java    |   2 +
 .../membership/InternalDistributedMember.java      |   4 +
 .../internal/membership/InternalRole.java          |   2 +
 .../internal/membership/MemberAttributes.java      |   3 +
 .../internal/membership/MemberFactory.java         |   2 +
 .../distributed/internal/membership/NetView.java   |   2 +
 .../membership/gms/messenger/JGroupsMessenger.java |   2 +
 .../membership/gms/mgr/GMSMembershipManager.java   |   3 +
 .../internal/streaming/StreamingOperation.java     |   2 +
 .../distributed/internal/tcpserver/TcpClient.java  |   2 +
 .../distributed/internal/tcpserver/TcpServer.java  |   6 ++
 .../main/java/org/apache/geode/i18n/StringId.java  |   6 ++
 .../org/apache/geode/internal/AvailablePort.java   |   4 +
 .../org/apache/geode/internal/ClassLoadUtil.java   |   3 +
 .../org/apache/geode/internal/ClassPathLoader.java |   2 +
 .../org/apache/geode/internal/ConfigSource.java    |   8 ++
 .../org/apache/geode/internal/DSFIDFactory.java    |   3 +
 .../org/apache/geode/internal/DeployedJar.java     |   3 +-
 .../apache/geode/internal/DistributionLocator.java |   3 +
 .../org/apache/geode/internal/GemFireVersion.java  |   3 +
 .../geode/internal/GfeConsoleReaderFactory.java    |   2 +
 .../geode/internal/InternalDataSerializer.java     |  19 ++++
 .../geode/internal/InternalInstantiator.java       |   5 +
 .../org/apache/geode/internal/JarDeployer.java     |   2 +
 .../org/apache/geode/internal/ManagerInfo.java     |   2 +
 .../java/org/apache/geode/internal/NanoTimer.java  |   3 +
 .../java/org/apache/geode/internal/OSProcess.java  |   7 ++
 .../org/apache/geode/internal/SharedLibrary.java   |   2 +
 .../java/org/apache/geode/internal/SmHelper.java   |   4 +
 .../org/apache/geode/internal/SystemAdmin.java     |  40 ++++++++
 .../geode/internal/SystemFailureTestHook.java      |   3 +
 .../org/apache/geode/internal/SystemTimer.java     |   3 +
 .../java/org/apache/geode/internal/Version.java    |  37 +++++++
 .../geode/internal/admin/CacheCollector.java       |   3 +
 .../admin/ClientHealthMonitoringRegion.java        |   2 +
 .../geode/internal/admin/ClientStatsManager.java   |   4 +
 .../geode/internal/admin/StatAlertsManager.java    |   3 +
 .../admin/remote/AlertListenerMessage.java         |   3 +-
 .../admin/remote/CancellationRegistry.java         |   2 +
 .../internal/admin/remote/ClientHealthStats.java   |   2 +
 .../admin/remote/InspectionClasspathManager.java   |   3 +
 .../admin/remote/ObjectDetailsResponse.java        |   2 +
 .../admin/remote/RemoteGfManagerAgent.java         |   3 +
 .../admin/remote/RemoteRegionAttributes.java       |   2 +
 .../alerting/AlertingProviderRegistry.java         |   4 +
 .../alerting/AlertingSessionListeners.java         |   3 +
 .../internal/alerting/NullAlertingService.java     |   2 +
 .../geode/internal/cache/AbstractRegion.java       |   3 +
 .../geode/internal/cache/AbstractRegionMap.java    |   3 +
 .../internal/cache/AbstractUpdateOperation.java    |   2 +
 .../apache/geode/internal/cache/BucketAdvisor.java |   2 +
 .../apache/geode/internal/cache/BucketRegion.java  |   3 +
 .../internal/cache/BytesAndBitsForCompactor.java   |   2 +
 .../apache/geode/internal/cache/CacheConfig.java   |   2 +
 .../geode/internal/cache/CacheObserverHolder.java  |   5 +
 .../geode/internal/cache/CachePerfStats.java       |   4 +
 .../geode/internal/cache/CacheServerImpl.java      |   2 +
 .../geode/internal/cache/CacheServerLauncher.java  |   2 +
 .../cache/CachedDeserializableFactory.java         |   3 +
 .../internal/cache/ClientServerObserverHolder.java |   4 +
 .../internal/cache/ClusterConfigurationLoader.java |   2 +
 .../geode/internal/cache/ColocationHelper.java     |   2 +
 .../geode/internal/cache/ColocationLogger.java     |   2 +
 .../geode/internal/cache/DirectoryHolder.java      |   2 +
 .../geode/internal/cache/DiskDirectoryStats.java   |   2 +
 .../geode/internal/cache/DiskRegionStats.java      |   2 +
 .../apache/geode/internal/cache/DiskStoreImpl.java |   8 ++
 .../geode/internal/cache/DiskStoreObserver.java    |   3 +
 .../geode/internal/cache/DiskStoreStats.java       |   2 +
 .../internal/cache/DiskWriteAttributesImpl.java    |   3 +
 .../apache/geode/internal/cache/DistTXState.java   |   3 +
 .../internal/cache/DistributedCacheOperation.java  |   7 ++
 .../internal/cache/DistributedClearOperation.java  |   2 +
 .../geode/internal/cache/DistributedRegion.java    |   5 +
 .../DistributedRegionFunctionStreamingMessage.java |   2 +
 .../cache/DistributedTombstoneOperation.java       |   2 +
 .../geode/internal/cache/EntryExpiryTask.java      |   2 +
 .../geode/internal/cache/EnumListenerEvent.java    |  21 ++++
 .../org/apache/geode/internal/cache/EventID.java   |   9 ++
 .../apache/geode/internal/cache/ExpiryTask.java    |   7 ++
 .../apache/geode/internal/cache/FilterProfile.java |   7 +-
 .../geode/internal/cache/FilterRoutingInfo.java    |   3 +
 .../geode/internal/cache/GemFireCacheImpl.java     |   9 ++
 .../apache/geode/internal/cache/GridAdvisor.java   |   3 +
 .../internal/cache/InitialImageFlowControl.java    |   2 +
 .../internal/cache/InitialImageOperation.java      |  29 ++++++
 .../apache/geode/internal/cache/LocalRegion.java   |   5 +
 .../geode/internal/cache/MemoryThresholdInfo.java  |   2 +
 .../org/apache/geode/internal/cache/Oplog.java     |   2 +
 .../internal/cache/PRHARedundancyProvider.java     |  12 +++
 .../geode/internal/cache/PRQueryProcessor.java     |   4 +
 .../internal/cache/PartitionAttributesImpl.java    |   4 +
 .../geode/internal/cache/PartitionedRegion.java    |   8 ++
 .../internal/cache/PartitionedRegionHelper.java    |   3 +
 .../internal/cache/PartitionedRegionStats.java     |   2 +
 .../geode/internal/cache/PoolManagerImpl.java      |   2 +
 .../org/apache/geode/internal/cache/PoolStats.java |   2 +
 .../geode/internal/cache/ProxyRegionMap.java       |   2 +
 .../cache/SearchLoadAndWriteProcessor.java         |   2 +
 .../geode/internal/cache/TXCommitMessage.java      |   7 ++
 .../apache/geode/internal/cache/TXEntryState.java  |   2 +
 .../apache/geode/internal/cache/TXLockRequest.java |   2 +
 .../apache/geode/internal/cache/TXManagerImpl.java |   9 ++
 .../org/apache/geode/internal/cache/TXState.java   |   2 +
 .../geode/internal/cache/TXStateProxyImpl.java     |   2 +
 .../org/apache/geode/internal/cache/Token.java     |  11 +++
 .../geode/internal/cache/TombstoneService.java     |   8 ++
 .../SnappyCompressedCachedDeserializable.java      |   2 +
 .../internal/cache/control/HeapMemoryMonitor.java  |   5 +
 .../cache/control/InternalResourceManager.java     |   2 +
 .../internal/cache/control/MemoryThresholds.java   |   3 +
 .../cache/control/ResourceManagerStats.java        |   2 +
 .../geode/internal/cache/entries/DiskEntry.java    |   7 ++
 .../entries/VMStatsDiskLRURegionEntryHeap.java     |   2 +
 .../entries/VMStatsDiskLRURegionEntryOffHeap.java  |   2 +
 .../cache/entries/VMStatsDiskRegionEntryHeap.java  |   2 +
 .../entries/VMStatsDiskRegionEntryOffHeap.java     |   2 +
 .../cache/entries/VMStatsLRURegionEntryHeap.java   |   2 +
 .../entries/VMStatsLRURegionEntryOffHeap.java      |   2 +
 .../cache/entries/VMStatsRegionEntryHeap.java      |   2 +
 .../cache/entries/VMStatsRegionEntryOffHeap.java   |   2 +
 .../entries/VMThinDiskLRURegionEntryHeap.java      |   2 +
 .../entries/VMThinDiskLRURegionEntryOffHeap.java   |   2 +
 .../cache/entries/VMThinDiskRegionEntryHeap.java   |   2 +
 .../entries/VMThinDiskRegionEntryOffHeap.java      |   2 +
 .../cache/entries/VMThinLRURegionEntryHeap.java    |   2 +
 .../cache/entries/VMThinLRURegionEntryOffHeap.java |   2 +
 .../cache/entries/VMThinRegionEntryHeap.java       |   2 +
 .../cache/entries/VMThinRegionEntryOffHeap.java    |   2 +
 .../VersionedStatsDiskLRURegionEntryHeap.java      |   2 +
 .../VersionedStatsDiskLRURegionEntryOffHeap.java   |   2 +
 .../entries/VersionedStatsDiskRegionEntryHeap.java |   2 +
 .../VersionedStatsDiskRegionEntryOffHeap.java      |   2 +
 .../entries/VersionedStatsLRURegionEntryHeap.java  |   2 +
 .../VersionedStatsLRURegionEntryOffHeap.java       |   2 +
 .../entries/VersionedStatsRegionEntryHeap.java     |   2 +
 .../entries/VersionedStatsRegionEntryOffHeap.java  |   2 +
 .../VersionedThinDiskLRURegionEntryHeap.java       |   2 +
 .../VersionedThinDiskLRURegionEntryOffHeap.java    |   2 +
 .../entries/VersionedThinDiskRegionEntryHeap.java  |   2 +
 .../VersionedThinDiskRegionEntryOffHeap.java       |   2 +
 .../entries/VersionedThinLRURegionEntryHeap.java   |   2 +
 .../VersionedThinLRURegionEntryOffHeap.java        |   2 +
 .../entries/VersionedThinRegionEntryHeap.java      |   2 +
 .../entries/VersionedThinRegionEntryOffHeap.java   |   2 +
 .../cache/event/NonDistributedEventTracker.java    |   2 +
 .../cache/eviction/CountLRUStatistics.java         |   2 +
 .../internal/cache/eviction/HeapLRUStatistics.java |   2 +
 .../cache/eviction/LRUListWithAsyncSorting.java    |   4 +
 .../cache/eviction/MemoryLRUStatistics.java        |   2 +
 .../internal/cache/execute/AbstractExecution.java  |   2 +
 .../cache/execute/FunctionServiceStats.java        |   2 +
 .../internal/cache/execute/FunctionStats.java      |   3 +
 .../InternalFunctionExecutionServiceImpl.java      |   2 +
 .../cache/execute/InternalFunctionService.java     |   2 +
 .../geode/internal/cache/ha/HARegionQueue.java     |  10 ++
 .../internal/cache/ha/HARegionQueueAttributes.java |   2 +
 .../internal/cache/ha/HARegionQueueStats.java      |   2 +
 .../geode/internal/cache/locks/TXLockIdImpl.java   |   2 +
 .../geode/internal/cache/locks/TXLockService.java  |   2 +
 .../geode/internal/cache/map/RegionMapDestroy.java |   2 +
 .../cache/partitioned/FetchEntriesMessage.java     |   2 +
 .../cache/partitioned/IdentityRequestMessage.java  |   2 +
 .../cache/partitioned/OfflineMemberDetails.java    |   2 +
 .../cache/partitioned/PRTombstoneMessage.java      |   2 +
 .../cache/partitioned/PartitionMessage.java        |   2 +
 .../PartitionedRegionObserverHolder.java           |   4 +
 .../internal/cache/partitioned/RegionAdvisor.java  |   2 +
 .../model/PartitionedRegionLoadModel.java          |   3 +
 .../cache/persistence/DefaultDiskDirs.java         |   3 +
 .../cache/persistence/PersistenceAdvisorImpl.java  |   4 +
 .../persistence/PersistenceObserverHolder.java     |   3 +
 .../persistence/query/mock/ByteComparator.java     |   3 +
 .../internal/cache/snapshot/FlowController.java    |   2 +
 .../geode/internal/cache/snapshot/GFSnapshot.java  |   2 +
 .../cache/snapshot/RegionSnapshotServiceImpl.java  |   2 +
 .../geode/internal/cache/tier/ConnectionProxy.java |   2 +
 .../cache/tier/InternalClientMembership.java       |   7 ++
 .../internal/cache/tier/sockets/AcceptorImpl.java  |   4 +
 .../internal/cache/tier/sockets/BaseCommand.java   |   5 +
 .../cache/tier/sockets/CacheClientNotifier.java    |   3 +
 .../tier/sockets/CacheClientNotifierStats.java     |   2 +
 .../cache/tier/sockets/CacheClientProxy.java       |   4 +
 .../cache/tier/sockets/CacheClientProxyStats.java  |   2 +
 .../cache/tier/sockets/CacheClientUpdater.java     |   5 +
 .../cache/tier/sockets/ClientHealthMonitor.java    |   3 +
 .../tier/sockets/ClientProxyMembershipID.java      |   5 +
 .../cache/tier/sockets/CommandInitializer.java     |   2 +
 .../internal/cache/tier/sockets/EncryptorImpl.java |  11 +++
 .../internal/cache/tier/sockets/Handshake.java     |   2 +
 .../geode/internal/cache/tier/sockets/Message.java |   5 +
 .../geode/internal/cache/tier/sockets/Part.java    |   5 +
 .../cache/tier/sockets/ServerConnection.java       |   7 ++
 .../tier/sockets/ServerSideHandshakeFactory.java   |   3 +
 .../tier/sockets/ServerSideHandshakeImpl.java      |   2 +
 .../cache/tier/sockets/UnregisterAllInterest.java  |   3 +
 .../cache/tier/sockets/VersionedObjectList.java    |   2 +
 .../cache/tier/sockets/command/AddPdxEnum.java     |   2 +
 .../cache/tier/sockets/command/AddPdxType.java     |   2 +
 .../cache/tier/sockets/command/ClearRegion.java    |   2 +
 .../cache/tier/sockets/command/ClientReady.java    |   2 +
 .../tier/sockets/command/CloseConnection.java      |   2 +
 .../cache/tier/sockets/command/CommitCommand.java  |   2 +
 .../cache/tier/sockets/command/ContainsKey.java    |   2 +
 .../cache/tier/sockets/command/ContainsKey66.java  |   2 +
 .../cache/tier/sockets/command/CreateRegion.java   |   2 +
 .../cache/tier/sockets/command/Default.java        |   2 +
 .../cache/tier/sockets/command/Destroy.java        |   2 +
 .../cache/tier/sockets/command/Destroy65.java      |   2 +
 .../cache/tier/sockets/command/Destroy70.java      |   2 +
 .../cache/tier/sockets/command/DestroyRegion.java  |   2 +
 .../tier/sockets/command/ExecuteFunction.java      |   2 +
 .../tier/sockets/command/ExecuteFunction65.java    |   2 +
 .../tier/sockets/command/ExecuteFunction66.java    |   6 +-
 .../tier/sockets/command/ExecuteFunction70.java    |   2 +
 .../sockets/command/ExecuteRegionFunction.java     |   2 +
 .../sockets/command/ExecuteRegionFunction61.java   |   2 +
 .../sockets/command/ExecuteRegionFunction65.java   |   2 +
 .../sockets/command/ExecuteRegionFunction66.java   |   2 +
 .../command/ExecuteRegionFunctionGeode18.java      |   2 +
 .../command/ExecuteRegionFunctionSingleHop.java    |   2 +
 .../sockets/command/GatewayReceiverCommand.java    |   2 +
 .../internal/cache/tier/sockets/command/Get70.java |   2 +
 .../cache/tier/sockets/command/GetAll.java         |   2 +
 .../cache/tier/sockets/command/GetAll651.java      |   2 +
 .../cache/tier/sockets/command/GetAll70.java       |   2 +
 .../cache/tier/sockets/command/GetAllForRI.java    |   2 +
 .../tier/sockets/command/GetAllWithCallback.java   |   2 +
 .../command/GetClientPRMetadataCommand.java        |   2 +
 .../command/GetClientPRMetadataCommand66.java      |   2 +
 .../GetClientPartitionAttributesCommand.java       |   2 +
 .../GetClientPartitionAttributesCommand66.java     |   2 +
 .../cache/tier/sockets/command/GetEntry70.java     |   2 +
 .../tier/sockets/command/GetEntryCommand.java      |   2 +
 .../tier/sockets/command/GetFunctionAttribute.java |   2 +
 .../cache/tier/sockets/command/GetPDXEnumById.java |   2 +
 .../tier/sockets/command/GetPDXIdForEnum.java      |   2 +
 .../tier/sockets/command/GetPDXIdForType.java      |   2 +
 .../cache/tier/sockets/command/GetPDXTypeById.java |   2 +
 .../cache/tier/sockets/command/GetPdxEnums70.java  |   2 +
 .../cache/tier/sockets/command/GetPdxTypes70.java  |   2 +
 .../cache/tier/sockets/command/Invalid.java        |   2 +
 .../cache/tier/sockets/command/Invalidate.java     |   2 +
 .../cache/tier/sockets/command/Invalidate70.java   |   2 +
 .../cache/tier/sockets/command/KeySet.java         |   2 +
 .../cache/tier/sockets/command/MakePrimary.java    |   2 +
 .../cache/tier/sockets/command/PeriodicAck.java    |   2 +
 .../internal/cache/tier/sockets/command/Ping.java  |   2 +
 .../internal/cache/tier/sockets/command/Put.java   |   2 +
 .../internal/cache/tier/sockets/command/Put61.java |   2 +
 .../internal/cache/tier/sockets/command/Put65.java |   2 +
 .../internal/cache/tier/sockets/command/Put70.java |   2 +
 .../cache/tier/sockets/command/PutAll.java         |   2 +
 .../cache/tier/sockets/command/PutAll70.java       |   2 +
 .../cache/tier/sockets/command/PutAll80.java       |   2 +
 .../tier/sockets/command/PutAllWithCallback.java   |   2 +
 .../tier/sockets/command/PutUserCredentials.java   |   2 +
 .../internal/cache/tier/sockets/command/Query.java |   2 +
 .../cache/tier/sockets/command/Query651.java       |   2 +
 .../cache/tier/sockets/command/QueryGeode10.java   |   2 +
 .../command/QueryWithParametersGeode10.java        |   2 +
 .../sockets/command/RegisterDataSerializers.java   |   2 +
 .../sockets/command/RegisterInstantiators.java     |   2 +
 .../tier/sockets/command/RegisterInterest.java     |   2 +
 .../tier/sockets/command/RegisterInterest61.java   |   2 +
 .../tier/sockets/command/RegisterInterestList.java |   2 +
 .../sockets/command/RegisterInterestList61.java    |   2 +
 .../sockets/command/RegisterInterestList66.java    |   2 +
 .../cache/tier/sockets/command/RemoveAll.java      |   2 +
 .../cache/tier/sockets/command/RemoveUserAuth.java |   2 +
 .../cache/tier/sockets/command/Request.java        |   2 +
 .../tier/sockets/command/RequestEventValue.java    |   2 +
 .../tier/sockets/command/RollbackCommand.java      |   2 +
 .../internal/cache/tier/sockets/command/Size.java  |   2 +
 .../tier/sockets/command/TXFailoverCommand.java    |   2 +
 .../sockets/command/TXSynchronizationCommand.java  |   2 +
 .../tier/sockets/command/UnregisterInterest.java   |   2 +
 .../sockets/command/UnregisterInterestList.java    |   2 +
 .../sockets/command/UpdateClientNotification.java  |   2 +
 .../geode/internal/cache/tx/ClientTXStateStub.java |   2 +
 .../internal/cache/versions/RVVException.java      |   2 +
 .../cache/versions/RegionVersionHolder.java        |   4 +
 .../cache/vmotion/VMotionObserverHolder.java       |   4 +
 .../internal/cache/wan/AbstractGatewaySender.java  |   5 +
 .../internal/cache/wan/GatewaySenderAdvisor.java   |   2 +
 .../internal/cache/wan/GatewaySenderStats.java     |  35 +++++++
 .../internal/cache/wan/WANServiceProvider.java     |   2 +
 .../wan/parallel/ParallelGatewaySenderQueue.java   |   2 +
 .../cache/wan/serial/SerialGatewaySenderQueue.java |   2 +
 .../internal/cache/xmlcache/CacheCreation.java     |   2 +
 .../internal/cache/xmlcache/CacheXmlGenerator.java |   2 +
 .../xmlcache/CacheXmlPropertyResolverHelper.java   |   2 +
 .../internal/cache/xmlcache/CacheXmlVersion.java   |   3 +
 .../cache/xmlcache/ClientCacheCreation.java        |   2 +
 .../cache/xmlcache/RegionAttributesCreation.java   |   2 +
 .../concurrent/CompactConcurrentHashSet2.java      |   7 ++
 .../internal/datasource/AbstractDataSource.java    |   2 +
 .../internal/datasource/DataSourceFactory.java     |   4 +
 .../apache/geode/internal/hll/HyperLogLogPlus.java |  10 +-
 .../i18n/AbstractStringIdResourceBundle.java       |   2 +
 .../apache/geode/internal/jndi/ContextImpl.java    |   2 +
 .../internal/jndi/InitialContextFactoryImpl.java   |   4 +
 .../apache/geode/internal/jndi/JNDIInvoker.java    |   8 ++
 .../apache/geode/internal/jndi/NameParserImpl.java |   3 +
 .../geode/internal/jta/GlobalTransaction.java      |   6 ++
 .../geode/internal/jta/TransactionManagerImpl.java |   2 +
 .../geode/internal/jta/TransactionUtils.java       |   4 +-
 .../org/apache/geode/internal/lang/ClassUtils.java |   3 +
 .../geode/internal/logging/DateFormatter.java      |   3 +
 .../geode/internal/logging/InternalLogWriter.java  |   3 +
 .../geode/internal/logging/LogWriterImpl.java      |   2 +
 .../internal/logging/LoggingSessionListeners.java  |   2 +
 .../geode/internal/logging/LoggingThreadGroup.java |   4 +
 .../logging/LoggingUncaughtExceptionHandler.java   |   2 +
 .../geode/internal/logging/MergeLogFiles.java      |   3 +
 .../apache/geode/internal/logging/NullLogFile.java |   3 +
 .../apache/geode/internal/logging/SortLogFile.java |   3 +
 .../internal/logging/log4j/AlertAppender.java      |   2 +
 .../internal/logging/log4j/ConfigLocator.java      |   3 +
 .../geode/internal/logging/log4j/FastLogger.java   |   3 +
 .../logging/log4j/GeodeConsoleAppender.java        |   5 +
 .../logging/log4j/HexThreadIdPatternConverter.java |   3 +
 .../geode/internal/logging/log4j/LogLevel.java     |   3 +
 .../geode/internal/logging/log4j/LogMarker.java    |  42 ++++++++
 .../logging/log4j/MemberNamePatternConverter.java  |   3 +
 .../internal/logging/log4j/MemberNameSupplier.java |   3 +
 .../GemFireParameterizedMessageFactory.java        |   3 +
 .../internal/memcached/ConnectionHandler.java      |   2 +
 .../geode/internal/memcached/RequestReader.java    |   4 +
 .../geode/internal/memcached/ValueWrapper.java     |   2 +
 .../memcached/commands/AbstractCommand.java        |   2 +
 .../internal/memcached/commands/GetCommand.java    |   3 +
 .../memcached/commands/StorageCommand.java         |   3 +
 .../org/apache/geode/internal/net/Buffers.java     |   2 +
 .../internal/net/SSLConfigurationFactory.java      |   2 +
 .../apache/geode/internal/net/SocketCreator.java   |   5 +
 .../geode/internal/net/SocketCreatorFactory.java   |   3 +
 .../internal/offheap/AddressableMemoryManager.java |   8 ++
 .../geode/internal/offheap/LifecycleListener.java  |   3 +
 .../internal/offheap/MemoryAllocatorImpl.java      |   2 +
 .../internal/offheap/OffHeapRegionEntryHelper.java |   2 +
 .../geode/internal/offheap/OffHeapStorage.java     |   2 +
 .../internal/offheap/ReferenceCountHelper.java     |   2 +
 .../internal/offheap/ReferenceCountHelperImpl.java |   2 +
 .../geode/internal/process/NativeProcessUtils.java |   2 +
 .../internal/process/ProcessLauncherContext.java   |   2 +
 .../geode/internal/process/ProcessUtils.java       |   3 +
 .../geode/internal/process/StartupStatus.java      |   2 +
 .../signal/AbstractSignalNotificationHandler.java  |   4 +
 .../geode/internal/sequencelog/EntryLogger.java    |   2 +
 .../internal/sequencelog/MembershipLogger.java     |   2 +
 .../geode/internal/sequencelog/MessageLogger.java  |   2 +
 .../geode/internal/sequencelog/RegionLogger.java   |   2 +
 .../internal/sequencelog/SequenceLoggerImpl.java   |   2 +
 .../sequencelog/io/GemfireLogConverter.java        |   2 +
 .../apache/geode/internal/shared/NativeCalls.java  |   2 +
 .../geode/internal/shared/NativeCallsJNAImpl.java  |   8 ++
 .../geode/internal/shared/StringPrintWriter.java   |   3 +
 .../size/InstrumentationSingleObjectSizer.java     |   3 +
 .../geode/internal/size/ObjectGraphSizer.java      |   3 +
 .../geode/internal/size/ObjectTraverser.java       |   4 +
 .../geode/internal/size/ReflectionObjectSizer.java |   3 +
 .../internal/size/ReflectionSingleObjectSizer.java |   2 +
 .../internal/size/SizeClassOnceObjectSizer.java    |   2 +
 .../statistics/DummyStatisticsFactory.java         |   2 +
 .../statistics/DummyStatisticsRegistry.java        |   2 +
 .../geode/internal/statistics/SampleCollector.java |   2 +
 .../internal/statistics/StatArchiveReader.java     |   2 +
 .../internal/statistics/StatArchiveWriter.java     |   4 +
 .../internal/statistics/StatSamplerStats.java      |   2 +
 .../geode/internal/statistics/StatisticsImpl.java  |   2 +
 .../statistics/StatisticsTypeFactoryImpl.java      |   2 +
 .../internal/statistics/StatisticsTypeImpl.java    |   2 +
 .../apache/geode/internal/statistics/VMStats.java  |   2 +
 .../statistics/platform/LinuxProcFsStatistics.java |  13 +++
 .../statistics/platform/LinuxProcessStats.java     |   2 +
 .../statistics/platform/LinuxSystemStats.java      |   2 +
 .../statistics/platform/OSXProcessStats.java       |   2 +
 .../statistics/platform/OSXSystemStats.java        |   2 +
 .../statistics/platform/SolarisProcessStats.java   |   2 +
 .../statistics/platform/SolarisSystemStats.java    |   2 +
 .../statistics/platform/WindowsProcessStats.java   |   2 +
 .../statistics/platform/WindowsSystemStats.java    |   2 +
 .../apache/geode/internal/stats50/VMStats50.java   |  17 ++++
 .../org/apache/geode/internal/tcp/Connection.java  |   7 ++
 .../apache/geode/internal/tcp/ConnectionTable.java |   4 +
 .../geode/internal/tcp/DirectReplySender.java      |   2 +
 .../apache/geode/internal/tcp/MsgIdGenerator.java  |   2 +
 .../org/apache/geode/internal/tcp/TCPConduit.java  |   3 +
 .../geode/internal/util/ArgumentRedactor.java      |   3 +
 .../apache/geode/internal/util/Breadcrumbs.java    |   4 +
 .../apache/geode/internal/util/DscodeHelper.java   |   2 +
 .../java/org/apache/geode/internal/util/Hex.java   |   3 +
 .../apache/geode/internal/util/PasswordUtil.java   |   3 +
 .../apache/geode/internal/util/TransformUtils.java |   4 +
 .../geode/management/cli/CommandService.java       |   4 +
 .../management/internal/BaseManagementService.java |   3 +
 .../ContextAwareSSLRMIClientSocketFactory.java     |   2 +
 .../internal/JmxManagerLocatorRequest.java         |   2 +
 .../geode/management/internal/MBeanJMXAdapter.java |   2 +
 .../internal/MXBeanProxyInvocationHandler.java     |   2 +
 .../management/internal/ManagementConstants.java   |   4 +
 .../geode/management/internal/OpenMethod.java      |   3 +
 .../management/internal/OpenTypeConverter.java     |   7 ++
 .../internal/beans/DistributedSystemBridge.java    |   2 +
 .../management/internal/beans/MBeanAggregator.java |   2 +
 .../internal/beans/ManagementAdapter.java          |   6 ++
 .../internal/beans/MemberMBeanBridge.java          |   3 +
 .../internal/beans/MetricsCalculator.java          |   3 +
 .../management/internal/beans/SequenceNumber.java  |   3 +
 .../geode/management/internal/cli/CliUtil.java     |   2 +
 .../management/internal/cli/CommandManager.java    |   2 +
 .../geode/management/internal/cli/LogWrapper.java  |   2 +
 .../internal/cli/commands/ConnectCommand.java      |   2 +
 .../cli/commands/CreateDefinedIndexesCommand.java  |   2 +
 .../internal/cli/commands/CreateIndexCommand.java  |   2 +
 .../cli/commands/DescribeMemberCommand.java        |   2 +
 .../cli/commands/DescribeRegionCommand.java        |   2 +
 .../internal/cli/commands/DestroyIndexCommand.java |   2 +
 .../internal/cli/commands/IndexDefinition.java     |   2 +
 .../cli/commands/ListJndiBindingCommand.java       |   2 +
 .../internal/cli/commands/ListRegionCommand.java   |   2 +
 .../internal/cli/commands/RegionCommandsUtils.java |   2 +
 .../internal/cli/commands/ShowMetricsCommand.java  |   6 ++
 .../internal/cli/commands/StartMemberUtils.java    |   2 +
 .../internal/cli/commands/UserInputProperty.java   |  12 +++
 .../cli/commands/lifecycle/StartVsdCommand.java    |   3 +
 .../cli/converters/ConfigPropertyConverter.java    |   2 +
 .../cli/converters/ExpirationActionConverter.java  |   2 +
 .../cli/functions/DescribeDiskStoreFunction.java   |   2 +
 .../functions/DestroyGatewayReceiverFunction.java  |   2 +
 .../functions/FetchRegionAttributesFunction.java   |   2 +
 .../functions/GatewayReceiverCreateFunction.java   |   2 +
 .../cli/functions/GatewaySenderCreateFunction.java |   2 +
 .../functions/GatewaySenderDestroyFunction.java    |   2 +
 .../internal/cli/functions/NetstatFunction.java    |   2 +
 .../cli/functions/RegionCreateFunction.java        |   3 +
 .../cli/functions/RegionDestroyFunction.java       |   2 +
 .../cli/functions/UpdateCacheFunction.java         |   2 +
 .../internal/cli/modes/CommandModes.java           |   2 +
 .../cli/remote/CommandExecutionContext.java        |   2 +
 .../internal/cli/result/ModelCommandResult.java    |   3 +
 .../geode/management/internal/cli/shell/Gfsh.java  |   5 +
 .../management/internal/cli/shell/GfshConfig.java  |   2 +
 .../internal/cli/shell/jline/ANSIHandler.java      |   3 +
 .../internal/cli/util/LogLevelExtractor.java       |   2 +
 .../internal/cli/util/RegionAttributesDefault.java |   3 +
 .../internal/messages/CompactRequest.java          |   2 +
 .../internal/security/MBeanServerWrapper.java      |   2 +
 .../internal/security/ResourcePermissions.java     |  15 +++
 .../web/controllers/ShellCommandsController.java   |   2 +
 .../internal/web/shell/HttpOperationInvoker.java   |   2 +
 .../geode/memcached/GemFireMemcachedServer.java    |   2 +
 .../pdx/internal/AutoSerializableManager.java      |   2 +
 .../org/apache/geode/pdx/internal/EnumInfo.java    |   2 +
 .../apache/geode/pdx/internal/PdxInstanceEnum.java |   2 +
 .../apache/geode/pdx/internal/PdxInstanceImpl.java |   2 +
 .../apache/geode/pdx/internal/PdxReaderImpl.java   |   2 +
 .../apache/geode/pdx/internal/TypeRegistry.java    |   5 +
 .../apache/geode/pdx/internal/json/PdxToJSON.java  |   3 +
 .../org/apache/geode/redis/GeodeRedisServer.java   |   2 +
 .../org/apache/geode/redis/internal/Coder.java     |   8 ++
 .../geode/redis/internal/RegionProvider.java       |   2 +
 .../redis/internal/executor/list/PushExecutor.java |   2 -
 .../apache/geode/security/ResourcePermission.java  |   2 +
 .../build.gradle => gradle/pmd.gradle              |  19 ++--
 settings.gradle                                    |   1 +
 .../pmd}/build.gradle                              |  15 +--
 .../java/org/apache/geode/pmd/Annotations.java     |  23 ++---
 .../apache/geode/pmd/StaticFieldsMustBeFinal.java  |  23 ++---
 .../geode/pmd/StaticFieldsMustBeImmutable.java     |  77 +++++++++++++++
 .../pmd/src/main/resources/geodepmd.xml            |  19 +++-
 .../resources/org/apache/geode/pmd/staticfinal.xml |  44 +++++++++
 .../org/apache/geode/pmd/staticimmutable.xml       |  48 +++++++++
 .../geode/pmd/StaticFieldsMustBeFinalTest.java     |  10 +-
 .../geode/pmd/StaticFieldsMustBeImmutableTest.java |  10 +-
 .../geode/pmd/xml/StaticFieldsMustBeFinal.xml      |  65 +++++++++++++
 .../geode/pmd/xml/StaticFieldsMustBeImmutable.xml  |  96 ++++++++++++++++++
 582 files changed, 2447 insertions(+), 222 deletions(-)
 delete mode 100644 geode-assembly/geode-assembly-test/src/main/java/org/apache/geode/rest/internal/web/controllers/RestTestUtils.java
 copy geode-common/src/main/java/org/apache/geode/annotations/{VisibleForTesting.java =>
Immutable.java} (67%)
 copy geode-common/src/main/java/org/apache/geode/annotations/{VisibleForTesting.java =>
internal/MakeImmutable.java} (65%)
 copy geode-common/src/main/java/org/apache/geode/annotations/{VisibleForTesting.java =>
internal/MakeNotStatic.java} (65%)
 copy geode-common/src/main/java/org/apache/geode/annotations/{VisibleForTesting.java =>
internal/MutableForTesting.java} (65%)
 copy extensions/session-testing-war/build.gradle => gradle/pmd.gradle (72%)
 copy {extensions/session-testing-war => static-analysis/pmd}/build.gradle (81%)
 copy geode-core/src/main/java/org/apache/geode/distributed/internal/unsafe/RegisterSignalHandlerSupport.java
=> static-analysis/pmd/src/main/java/org/apache/geode/pmd/Annotations.java (60%)
 copy geode-dunit/src/main/java/org/apache/geode/test/dunit/rules/CleanupDUnitVMsRule.java
=> static-analysis/pmd/src/main/java/org/apache/geode/pmd/StaticFieldsMustBeFinal.java
(61%)
 create mode 100644 static-analysis/pmd/src/main/java/org/apache/geode/pmd/StaticFieldsMustBeImmutable.java
 copy geode-core/src/test/resources/org/apache/geode/management/internal/configuration/utils/SharedConfigurationJUnitTest.xml
=> static-analysis/pmd/src/main/resources/geodepmd.xml (59%)
 create mode 100644 static-analysis/pmd/src/main/resources/org/apache/geode/pmd/staticfinal.xml
 create mode 100644 static-analysis/pmd/src/main/resources/org/apache/geode/pmd/staticimmutable.xml
 copy geode-core/src/main/java/org/apache/geode/internal/EmptyInputStreamFilter.java =>
static-analysis/pmd/src/test/java/org/apache/geode/pmd/StaticFieldsMustBeFinalTest.java (76%)
 copy geode-core/src/main/java/org/apache/geode/distributed/internal/HighPriorityDistributionMessage.java
=> static-analysis/pmd/src/test/java/org/apache/geode/pmd/StaticFieldsMustBeImmutableTest.java
(76%)
 create mode 100644 static-analysis/pmd/src/test/resources/org/apache/geode/pmd/xml/StaticFieldsMustBeFinal.xml
 create mode 100644 static-analysis/pmd/src/test/resources/org/apache/geode/pmd/xml/StaticFieldsMustBeImmutable.xml


Mime
View raw message