geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbarr...@apache.org
Subject [geode-native] 01/02: GEODE-5766: Fixes google-readability-namespace-comments warning
Date Tue, 09 Oct 2018 00:12:44 GMT
This is an automated email from the ASF dual-hosted git repository.

jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git

commit 156431c5d3f321949cec422a866225b7b1dad0e6
Author: Jacob Barrett <jbarrett@pivotal.io>
AuthorDate: Thu Sep 20 22:03:16 2018 -0700

    GEODE-5766: Fixes google-readability-namespace-comments warning
---
 .clang-tidy                            | 2 +-
 cppcache/src/MapSegment.hpp            | 2 +-
 cppcache/src/SerializationRegistry.hpp | 4 ++--
 cppcache/src/TcrConnectionManager.hpp  | 7 ++-----
 4 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index 09a1256..57c3abe 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,6 +1,6 @@
 ---
 Checks:          '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-google-default-arguments'
-WarningsAsErrors: 'google-build-using-namespace,google-readability-redundant-smartptr-get,google-explicit-constructor,google-global-names-in-headers,google-runtime-int,google-readability-casting'
+WarningsAsErrors: 'google-build-using-namespace,google-readability-redundant-smartptr-get,google-explicit-constructor,google-global-names-in-headers,google-runtime-int,google-readability-casting,google-readability-namespace-comments'
 HeaderFilterRegex: '.*'
 AnalyzeTemporaryDtors: false
 FormatStyle:     file
diff --git a/cppcache/src/MapSegment.hpp b/cppcache/src/MapSegment.hpp
index e756798..b3ccb74 100644
--- a/cppcache/src/MapSegment.hpp
+++ b/cppcache/src/MapSegment.hpp
@@ -66,7 +66,7 @@ class ACE_Equal_To<std::shared_ptr<apache::geode::client::CacheableKey>>
{
   }
 };
 
-}  // namespace ACE_VERSIONED_NAMESPACE_NAME
+}  // namespace ACE_VERSIONED_NAMESPACE_NAME NOLINT
 
 namespace apache {
 namespace geode {
diff --git a/cppcache/src/SerializationRegistry.hpp b/cppcache/src/SerializationRegistry.hpp
index 7da00a3..ca4a431 100644
--- a/cppcache/src/SerializationRegistry.hpp
+++ b/cppcache/src/SerializationRegistry.hpp
@@ -48,7 +48,7 @@
 #include "MemberListForVersionStamp.hpp"
 #include "config.h"
 
-namespace ACE_VERSIONED_NAMESPACE_NAME {
+namespace ACE_VERSIONED_NAMESPACE_NAME { // NOLINT
 
 #if defined(_MACOSX)
 // TODO CMake check type int64_t
@@ -71,7 +71,7 @@ class ACE_Hash<DSCode> {
   }
 };
 
-}  // namespace ACE_VERSIONED_NAMESPACE_NAME
+}  // namespace ACE_VERSIONED_NAMESPACE_NAME  NOLINT
 
 namespace apache {
 namespace geode {
diff --git a/cppcache/src/TcrConnectionManager.hpp b/cppcache/src/TcrConnectionManager.hpp
index 7b97c30..b6078d2 100644
--- a/cppcache/src/TcrConnectionManager.hpp
+++ b/cppcache/src/TcrConnectionManager.hpp
@@ -25,9 +25,9 @@
 #include <list>
 #include <unordered_map>
 
+#include <ace/config-lite.h>
 #include <ace/Map_Manager.h>
 #include <ace/Semaphore.h>
-#include <ace/config-lite.h>
 #include <ace/Versioned_Namespace.h>
 #include <ace/Recursive_Thread_Mutex.h>
 
@@ -38,13 +38,10 @@
 #include "ThinClientRedundancyManager.hpp"
 #include "ExpiryTaskManager.hpp"
 
-namespace ACE_VERSIONED_NAMESPACE_NAME {
-class ACE_Task_Base;
-}  // namespace ACE_VERSIONED_NAMESPACE_NAME
-
 namespace apache {
 namespace geode {
 namespace client {
+
 class TcrConnection;
 class TcrEndpoint;
 class TcrMessage;


Mime
View raw message