From commits-return-28080-archive-asf-public=cust-asf.ponee.io@geode.apache.org Sat Aug 25 00:47:28 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9D60A180677 for ; Sat, 25 Aug 2018 00:47:27 +0200 (CEST) Received: (qmail 46222 invoked by uid 500); 24 Aug 2018 22:47:26 -0000 Mailing-List: contact commits-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list commits@geode.apache.org Received: (qmail 46213 invoked by uid 99); 24 Aug 2018 22:47:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Aug 2018 22:47:26 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 29A96853FD; Fri, 24 Aug 2018 22:47:26 +0000 (UTC) Date: Fri, 24 Aug 2018 22:47:24 +0000 To: "commits@geode.apache.org" Subject: [geode] 03/03: GEODE-5614: update RegionManagementDUnitTest usage of DistributedRule MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: klund@apache.org In-Reply-To: <153515084133.29077.683495843883136304@gitbox.apache.org> References: <153515084133.29077.683495843883136304@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: geode X-Git-Refname: refs/heads/develop X-Git-Reftype: branch X-Git-Rev: f91c2dfa319073ddb1222c3f50c26735d19332fe X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20180824224726.29A96853FD@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. klund pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/geode.git commit f91c2dfa319073ddb1222c3f50c26735d19332fe Author: Kirk Lund AuthorDate: Fri Aug 24 10:53:15 2018 -0700 GEODE-5614: update RegionManagementDUnitTest usage of DistributedRule --- .../apache/geode/management/RegionManagementDUnitTest.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/geode-core/src/distributedTest/java/org/apache/geode/management/RegionManagementDUnitTest.java b/geode-core/src/distributedTest/java/org/apache/geode/management/RegionManagementDUnitTest.java index c12052a..2a75128 100644 --- a/geode-core/src/distributedTest/java/org/apache/geode/management/RegionManagementDUnitTest.java +++ b/geode-core/src/distributedTest/java/org/apache/geode/management/RegionManagementDUnitTest.java @@ -85,7 +85,7 @@ import org.apache.geode.management.internal.MBeanJMXAdapter; import org.apache.geode.management.internal.SystemManagementService; import org.apache.geode.test.dunit.VM; import org.apache.geode.test.dunit.rules.CacheRule; -import org.apache.geode.test.dunit.rules.DistributedTestRule; +import org.apache.geode.test.dunit.rules.DistributedRule; import org.apache.geode.test.junit.rules.serializable.SerializableTestName; /** @@ -99,7 +99,7 @@ import org.apache.geode.test.junit.rules.serializable.SerializableTestName; * Goal of the Test : RegionMBean gets created once region is created. Data like Region Attributes * data and stats are of proper value */ -@SuppressWarnings("serial,unused") +@SuppressWarnings("serial") public class RegionManagementDUnitTest implements Serializable { private static final AtomicReference> MEMBER_NOTIFICATIONS = @@ -116,7 +116,7 @@ public class RegionManagementDUnitTest implements Serializable { private VM[] memberVMs; @Rule - public DistributedTestRule distributedTestRule = new DistributedTestRule(); + public DistributedRule distributedRule = new DistributedRule(); @Rule public CacheRule cacheRule = new CacheRule(); @@ -692,6 +692,11 @@ public class RegionManagementDUnitTest implements Serializable { // Destroyed/Closed With Name /MANAGEMENT_TEST_REGION]]> } + /** + * Please don't delete verifySystemNotifications. We need to improve verification in this test + * class and fix whatever flakiness is in this method. + */ + @SuppressWarnings("unused") private void verifySystemNotifications(final String regionName, final int expectedMembers) { assertThat(SYSTEM_NOTIFICATIONS.get()).isNotNull(); assertThat(SYSTEM_NOTIFICATIONS.get()).hasSize(expectedMembers + 2); // 2 for the manager