geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sai_boorlaga...@apache.org
Subject [geode] branch develop updated: GEODE-5212: Fix gfsh rule to use gfsh.bat on windows (#2036)
Date Thu, 07 Jun 2018 17:22:50 GMT
This is an automated email from the ASF dual-hosted git repository.

sai_boorlagadda pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new a58d8d2  GEODE-5212: Fix gfsh rule to use gfsh.bat on windows (#2036)
a58d8d2 is described below

commit a58d8d2d201bd9816609dfb4c39a87efbf57e167
Author: Sai Boorlagadda <sai.boorlagadda@gmail.com>
AuthorDate: Thu Jun 7 10:22:42 2018 -0700

    GEODE-5212: Fix gfsh rule to use gfsh.bat on windows (#2036)
---
 .../java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java  | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java
b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java
index afed73b..8d822eb 100644
--- a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java
+++ b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java
@@ -101,7 +101,15 @@ public class GfshRule extends ExternalResource {
       geodeHome = Paths.get(VersionManager.getInstance().getInstall(version));
     }
 
-    return geodeHome.resolve("bin/gfsh");
+    if (isWindows()) {
+      return geodeHome.resolve("bin/gfsh.bat");
+    } else {
+      return geodeHome.resolve("bin/gfsh");
+    }
+  }
+
+  private boolean isWindows() {
+    return System.getProperty("os.name").toLowerCase().contains("win");
   }
 
   public TemporaryFolder getTemporaryFolder() {

-- 
To stop receiving notification emails like this one, please contact
sai_boorlagadda@apache.org.

Mime
View raw message