geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bschucha...@apache.org
Subject [geode] branch develop updated: GEODE-3692 Intermittent test failure: ClientAuthDUnitTest
Date Tue, 05 Jun 2018 16:53:06 GMT
This is an automated email from the ASF dual-hosted git repository.

bschuchardt pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new c4e7fb8  GEODE-3692 Intermittent test failure: ClientAuthDUnitTest
c4e7fb8 is described below

commit c4e7fb8e96f84eb4a999149a16122e3c528850d3
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
AuthorDate: Tue Jun 5 09:51:46 2018 -0700

    GEODE-3692 Intermittent test failure: ClientAuthDUnitTest
    
    Re-adding Flaky category to this test.
---
 .../java/org/apache/geode/security/ClientAuthDUnitTest.java | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/geode-core/src/test/java/org/apache/geode/security/ClientAuthDUnitTest.java b/geode-core/src/test/java/org/apache/geode/security/ClientAuthDUnitTest.java
index 06840cb..d9c572b 100644
--- a/geode-core/src/test/java/org/apache/geode/security/ClientAuthDUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/security/ClientAuthDUnitTest.java
@@ -15,10 +15,12 @@
 package org.apache.geode.security;
 
 import static org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static org.apache.geode.test.dunit.Disconnect.disconnectAllFromDS;
 import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
 
 import java.io.Serializable;
 
+import org.junit.After;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
@@ -29,10 +31,12 @@ import org.apache.geode.cache.client.ClientRegionShortcut;
 import org.apache.geode.test.dunit.IgnoredException;
 import org.apache.geode.test.dunit.rules.ClusterStartupRule;
 import org.apache.geode.test.junit.categories.DistributedTest;
+import org.apache.geode.test.junit.categories.FlakyTest;
 import org.apache.geode.test.junit.categories.SecurityTest;
 import org.apache.geode.test.junit.rules.ServerStarterRule;
 
-@Category({DistributedTest.class, SecurityTest.class})
+// flaky: GEODE-3692
+@Category({DistributedTest.class, SecurityTest.class, FlakyTest.class})
 public class ClientAuthDUnitTest {
   @Rule
   public ClusterStartupRule lsRule = new ClusterStartupRule();
@@ -41,9 +45,14 @@ public class ClientAuthDUnitTest {
   public ServerStarterRule server = new ServerStarterRule()
       .withProperty(SECURITY_MANAGER, SimpleTestSecurityManager.class.getName()).withAutoStart();
 
+  @After
+  public void tearDown() throws Exception {
+    disconnectAllFromDS();
+  }
+
   @Test
   public void authWithCorrectPasswordShouldPass() throws Exception {
-    lsRule.startClientVM(0, "test", "test", true, server.getPort());
+    lsRule.startClientVM(0, "test", "test", true, server.getPort(), new ClientCacheHook(lsRule));
   }
 
   @Test

-- 
To stop receiving notification emails like this one, please contact
bschuchardt@apache.org.

Mime
View raw message