geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbarr...@apache.org
Subject [geode-native] branch develop updated: Revert "GEODE-4410: Prevent future unused paramters from MSVC."
Date Wed, 18 Apr 2018 00:28:07 GMT
This is an automated email from the ASF dual-hosted git repository.

jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git


The following commit(s) were added to refs/heads/develop by this push:
     new 91f3626  Revert "GEODE-4410: Prevent future unused paramters from MSVC."
91f3626 is described below

commit 91f3626a24ae46dd95014b8abd9278fe8edccbc8
Author: Jacob Barrett <jbarrett@pivotal.io>
AuthorDate: Wed Apr 18 00:27:49 2018 +0000

    Revert "GEODE-4410: Prevent future unused paramters from MSVC."
    
    This reverts commit 4e09a7cb59bc1512d02c8af80b1ea8ada9900e1d.
---
 CMakeLists.txt | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ab106bd..a9783df 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -245,11 +245,9 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
     /EHa)
 
   target_compile_options(_WarningsAsError INTERFACE
-    /W3
     /WX
-    /w34100 # -Wunused-parameter
-    /wd4068 # TODO fix
-    )
+	/wd4068 # TODO fix
+	)
 
   # TODO error on warnings
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4996")

-- 
To stop receiving notification emails like this one, please contact
jbarrett@apache.org.

Mime
View raw message