geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bschucha...@apache.org
Subject [geode] branch develop updated: GEODE-4980 CI failure: AutoConnectionSourceImplJUnitTest. testServerLocationUsedInListenerNotification
Date Mon, 02 Apr 2018 16:04:18 GMT
This is an automated email from the ASF dual-hosted git repository.

bschuchardt pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new c2a06a1  GEODE-4980 CI failure: AutoConnectionSourceImplJUnitTest. testServerLocationUsedInListenerNotification
c2a06a1 is described below

commit c2a06a1eef814a584970b9e1d812c59763796b09
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
AuthorDate: Mon Apr 2 09:02:41 2018 -0700

    GEODE-4980 CI failure: AutoConnectionSourceImplJUnitTest. testServerLocationUsedInListenerNotification
    
    Modified the test to not expect a numeric host name for an InetAddress of
    "1.1.1.1".  That address has been seen to resolve to a host name and when
    that happened the test failed.
---
 .../cache/client/internal/AutoConnectionSourceImplJUnitTest.java      | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
b/geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
index e199654..714da68 100644
--- a/geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
@@ -17,6 +17,7 @@ package org.apache.geode.cache.client.internal;
 import static org.apache.geode.distributed.ConfigurationProperties.LOCATORS;
 import static org.apache.geode.distributed.ConfigurationProperties.MCAST_PORT;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.fail;
 
 import java.io.IOException;
@@ -74,6 +75,7 @@ import org.apache.geode.internal.cache.tier.sockets.TcpServerFactory;
 import org.apache.geode.management.membership.ClientMembershipEvent;
 import org.apache.geode.management.membership.ClientMembershipListener;
 import org.apache.geode.test.junit.categories.ClientServerTest;
+import org.apache.geode.test.junit.categories.FlakyTest;
 import org.apache.geode.test.junit.categories.IntegrationTest;
 
 /**
@@ -266,7 +268,7 @@ public class AutoConnectionSourceImplJUnitTest {
       }
     });
 
-    assertEquals("1.1.1.1", listenerEvents[0].getMember().getHost());
+    assertNotNull(listenerEvents[0].getMember().getHost());
 
     InetAddress addr = InetAddress.getLocalHost();
     location = new ServerLocation(addr.getHostAddress(), 0);

-- 
To stop receiving notification emails like this one, please contact
bschuchardt@apache.org.

Mime
View raw message