geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From esh...@apache.org
Subject [geode] branch feature/GEODE-3583-storage updated: GEODE-4210: spotless changes.
Date Thu, 11 Jan 2018 23:35:11 GMT
This is an automated email from the ASF dual-hosted git repository.

eshu11 pushed a commit to branch feature/GEODE-3583-storage
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/feature/GEODE-3583-storage by this push:
     new 4e38224  GEODE-4210: spotless changes.
4e38224 is described below

commit 4e38224f87f0c7618cf851366e714765cfc340cc
Author: eshu <eshu@pivotal.io>
AuthorDate: Thu Jan 11 15:34:17 2018 -0800

    GEODE-4210: spotless changes.
---
 .../geode/internal/cache/TXStateProxyImpl.java     | 40 +++++++++++-----------
 .../apache/geode/internal/cache/TXStateStub.java   | 38 ++++++++++----------
 .../tier/sockets/command/TXFailoverCommand.java    |  3 +-
 .../geode/internal/cache/TXStateProxyImplTest.java |  4 +--
 4 files changed, 43 insertions(+), 42 deletions(-)

diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/TXStateProxyImpl.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/TXStateProxyImpl.java
index 3a677b5..64be4af 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/TXStateProxyImpl.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/TXStateProxyImpl.java
@@ -283,7 +283,7 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public void destroyExistingEntry(EntryEventImpl event, boolean cacheWrite,
-                                   Object expectedOldValue) throws EntryNotFoundException
{
+      Object expectedOldValue) throws EntryNotFoundException {
     try {
       this.operationCount++;
       getRealDeal(event.getKeyInfo(), event.getLocalRegion()).destroyExistingEntry(event,
@@ -312,8 +312,8 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public Object getDeserializedValue(KeyInfo keyInfo, LocalRegion localRegion, boolean updateStats,
-                                     boolean disableCopyOnRead, boolean preferCD, EntryEventImpl
clientEvent,
-                                     boolean returnTombstones, boolean retainResult) {
+      boolean disableCopyOnRead, boolean preferCD, EntryEventImpl clientEvent,
+      boolean returnTombstones, boolean retainResult) {
     Object val = getRealDeal(keyInfo, localRegion).getDeserializedValue(keyInfo, localRegion,
         updateStats, disableCopyOnRead, preferCD, null, false, retainResult);
     if (val != null) {
@@ -361,7 +361,7 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public void invalidateExistingEntry(EntryEventImpl event, boolean invokeCallbacks,
-                                      boolean forceNewEntry) {
+      boolean forceNewEntry) {
     try {
       this.operationCount++;
       getRealDeal(event.getKeyInfo(), event.getLocalRegion()).invalidateExistingEntry(event,
@@ -420,7 +420,7 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public boolean txPutEntry(EntryEventImpl event, boolean ifNew, boolean requireOldValue,
-                            boolean checkResources, Object expectedOldValue) {
+      boolean checkResources, Object expectedOldValue) {
     try {
       this.operationCount++;
       boolean retVal = getRealDeal(event.getKeyInfo(), (LocalRegion) event.getRegion())
@@ -434,7 +434,7 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public TXEntryState txReadEntry(KeyInfo keyInfo, LocalRegion localRegion, boolean rememberRead,
-                                  boolean createTxEntryIfAbsent) {
+      boolean createTxEntryIfAbsent) {
     try {
       this.operationCount++;
       TXEntryState retVal = getRealDeal(keyInfo, localRegion).txReadEntry(keyInfo, localRegion,
@@ -530,9 +530,9 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public Object findObject(KeyInfo key, LocalRegion r, boolean isCreate, boolean generateCallbacks,
-                           Object value, boolean disableCopyOnRead, boolean preferCD,
-                           ClientProxyMembershipID requestingClient, EntryEventImpl clientEvent,
-                           boolean returnTombstones) {
+      Object value, boolean disableCopyOnRead, boolean preferCD,
+      ClientProxyMembershipID requestingClient, EntryEventImpl clientEvent,
+      boolean returnTombstones) {
     try {
       this.operationCount++;
       Object retVal = getRealDeal(key, r).findObject(key, r, isCreate, generateCallbacks,
value,
@@ -557,7 +557,7 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public Object getEntryForIterator(KeyInfo key, LocalRegion currRgn, boolean rememberReads,
-                                    boolean allowTombstones) {
+      boolean allowTombstones) {
     boolean resetTxState = isTransactionInternalSuspendNeeded(currRgn);
     TXStateProxy txp = null;
     if (resetTxState) {
@@ -584,7 +584,7 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public Object getKeyForIterator(KeyInfo keyInfo, LocalRegion currRgn, boolean rememberReads,
-                                  boolean allowTombstones) {
+      boolean allowTombstones) {
     boolean resetTxState = isTransactionInternalSuspendNeeded(currRgn);
     TXStateProxy txp = null;
     if (resetTxState) {
@@ -618,8 +618,8 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public boolean putEntry(EntryEventImpl event, boolean ifNew, boolean ifOld,
-                          Object expectedOldValue, boolean requireOldValue, long lastModified,
-                          boolean overwriteDestroyed) {
+      Object expectedOldValue, boolean requireOldValue, long lastModified,
+      boolean overwriteDestroyed) {
     try {
       this.operationCount++;
       boolean retVal = getRealDeal(event.getKeyInfo(), event.getLocalRegion()).putEntry(event,
@@ -643,8 +643,8 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public Object getSerializedValue(LocalRegion localRegion, KeyInfo key, boolean doNotLockEntry,
-                                   ClientProxyMembershipID requestingClient, EntryEventImpl
clientEvent,
-                                   boolean returnTombstones) throws DataLocationException
{
+      ClientProxyMembershipID requestingClient, EntryEventImpl clientEvent,
+      boolean returnTombstones) throws DataLocationException {
     this.operationCount++;
     return getRealDeal(key, localRegion).getSerializedValue(localRegion, key, doNotLockEntry,
         requestingClient, clientEvent, returnTombstones);
@@ -652,8 +652,8 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public boolean putEntryOnRemote(EntryEventImpl event, boolean ifNew, boolean ifOld,
-                                  Object expectedOldValue, boolean requireOldValue, long
lastModified,
-                                  boolean overwriteDestroyed) throws DataLocationException
{
+      Object expectedOldValue, boolean requireOldValue, long lastModified,
+      boolean overwriteDestroyed) throws DataLocationException {
     this.operationCount++;
     TXStateInterface tx = getRealDeal(event.getKeyInfo(), event.getLocalRegion());
     assert (tx instanceof TXState) : tx.getClass().getSimpleName();
@@ -677,7 +677,7 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public void invalidateOnRemote(EntryEventImpl event, boolean invokeCallbacks,
-                                 boolean forceNewEntry) throws DataLocationException {
+      boolean forceNewEntry) throws DataLocationException {
     this.operationCount++;
     TXStateInterface tx = getRealDeal(event.getKeyInfo(), event.getLocalRegion());
     assert (tx instanceof TXState);
@@ -841,7 +841,7 @@ public class TXStateProxyImpl implements TXStateProxy {
 
   @Override
   public void postPutAll(DistributedPutAllOperation putallOp, VersionedObjectList successfulPuts,
-                         LocalRegion region) {
+      LocalRegion region) {
     if (putallOp.putAllData.length == 0) {
       return;
     }
@@ -911,7 +911,7 @@ public class TXStateProxyImpl implements TXStateProxy {
   /** test hook - record a list of ops in the transaction */
   @Override
   public void recordTXOperation(ServerRegionDataAccess region, ServerRegionOperation op,
Object key,
-                                Object arguments[]) {
+      Object arguments[]) {
     if (ClientTXStateStub.transactionRecordingEnabled()) {
       getRealDeal(null, (LocalRegion) region.getRegion()).recordTXOperation(region, op, key,
           arguments);
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/TXStateStub.java b/geode-core/src/main/java/org/apache/geode/internal/cache/TXStateStub.java
index 627432a..91a9a58 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/TXStateStub.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/TXStateStub.java
@@ -149,7 +149,7 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public void destroyExistingEntry(EntryEventImpl event, boolean cacheWrite,
-                                   Object expectedOldValue) throws EntryNotFoundException
{
+      Object expectedOldValue) throws EntryNotFoundException {
     if (event.getOperation().isLocal()) {
       throw new UnsupportedOperationInTransactionException(
           LocalizedStrings.TXStateStub_LOCAL_DESTROY_NOT_ALLOWED_IN_TRANSACTION
@@ -199,8 +199,8 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public Object getDeserializedValue(KeyInfo keyInfo, LocalRegion localRegion, boolean updateStats,
-                                     boolean disableCopyOnRead, boolean preferCD, EntryEventImpl
clientEvent,
-                                     boolean returnTombstones, boolean retainResult) {
+      boolean disableCopyOnRead, boolean preferCD, EntryEventImpl clientEvent,
+      boolean returnTombstones, boolean retainResult) {
     // We never have a local value if we are a stub...
     return null;
   }
@@ -277,7 +277,7 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public void invalidateExistingEntry(EntryEventImpl event, boolean invokeCallbacks,
-                                      boolean forceNewEntry) {
+      boolean forceNewEntry) {
     if (event.getOperation().isLocal()) {
       throw new UnsupportedOperationInTransactionException(
           LocalizedStrings.TXStateStub_LOCAL_INVALIDATE_NOT_ALLOWED_IN_TRANSACTION
@@ -376,7 +376,7 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public boolean txPutEntry(EntryEventImpl event, boolean ifNew, boolean requireOldValue,
-                            boolean checkResources, Object expectedOldValue) {
+      boolean checkResources, Object expectedOldValue) {
     return false;
   }
 
@@ -388,7 +388,7 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public TXEntryState txReadEntry(KeyInfo entryKey, LocalRegion localRegion, boolean rememberRead,
-                                  boolean createTxEntryIfAbsent) {
+      boolean createTxEntryIfAbsent) {
     // TODO Auto-generated method stub
     return null;
   }
@@ -475,9 +475,9 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public Object findObject(KeyInfo keyInfo, LocalRegion r, boolean isCreate,
-                           boolean generateCallbacks, Object value, boolean disableCopyOnRead,
boolean preferCD,
-                           ClientProxyMembershipID requestingClient, EntryEventImpl clientEvent,
-                           boolean returnTombstones) {
+      boolean generateCallbacks, Object value, boolean disableCopyOnRead, boolean preferCD,
+      ClientProxyMembershipID requestingClient, EntryEventImpl clientEvent,
+      boolean returnTombstones) {
     return getTXRegionStub(r).findObject(keyInfo, isCreate, generateCallbacks, value, preferCD,
         requestingClient, clientEvent);
   }
@@ -504,7 +504,7 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public Object getEntryForIterator(KeyInfo keyInfo, LocalRegion currRgn, boolean rememberReads,
-                                    boolean allowTombstones) {
+      boolean allowTombstones) {
     return getTXRegionStub(currRgn).getEntryForIterator(keyInfo, allowTombstones);
   }
 
@@ -516,7 +516,7 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public Object getKeyForIterator(KeyInfo keyInfo, LocalRegion currRgn, boolean rememberReads,
-                                  boolean allowTombstones) {
+      boolean allowTombstones) {
     Object key = keyInfo.getKey();
     if (key instanceof RegionEntry) {
       return ((RegionEntry) key).getKey();
@@ -554,8 +554,8 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public boolean putEntry(EntryEventImpl event, boolean ifNew, boolean ifOld,
-                          Object expectedOldValue, boolean requireOldValue, long lastModified,
-                          boolean overwriteDestroyed) {
+      Object expectedOldValue, boolean requireOldValue, long lastModified,
+      boolean overwriteDestroyed) {
     return getTXRegionStub(event.getRegion()).putEntry(event, ifNew, ifOld, expectedOldValue,
         requireOldValue, lastModified, overwriteDestroyed);
   }
@@ -569,8 +569,8 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public Object getSerializedValue(LocalRegion localRegion, KeyInfo key, boolean doNotLockEntry,
-                                   ClientProxyMembershipID requestingClient, EntryEventImpl
clientEvent,
-                                   boolean returnTombstones) {
+      ClientProxyMembershipID requestingClient, EntryEventImpl clientEvent,
+      boolean returnTombstones) {
     throw new UnsupportedOperationException();
   }
 
@@ -583,8 +583,8 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public boolean putEntryOnRemote(EntryEventImpl event, boolean ifNew, boolean ifOld,
-                                  Object expectedOldValue, boolean requireOldValue, long
lastModified,
-                                  boolean overwriteDestroyed) throws DataLocationException
{
+      Object expectedOldValue, boolean requireOldValue, long lastModified,
+      boolean overwriteDestroyed) throws DataLocationException {
     throw new IllegalStateException();
   }
 
@@ -614,7 +614,7 @@ public abstract class TXStateStub implements TXStateInterface {
    */
   @Override
   public void invalidateOnRemote(EntryEventImpl event, boolean invokeCallbacks,
-                                 boolean forceNewEntry) throws DataLocationException {
+      boolean forceNewEntry) throws DataLocationException {
     throw new IllegalStateException();
   }
 
@@ -699,7 +699,7 @@ public abstract class TXStateStub implements TXStateInterface {
 
   @Override
   public void postPutAll(DistributedPutAllOperation putallOp, VersionedObjectList successfulPuts,
-                         LocalRegion region) {
+      LocalRegion region) {
     getTXRegionStub(region).postPutAll(putallOp, successfulPuts, region);
   }
 
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXFailoverCommand.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXFailoverCommand.java
index 7791df2..cce6853 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXFailoverCommand.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXFailoverCommand.java
@@ -81,7 +81,8 @@ public class TXFailoverCommand extends BaseCommand {
 
     if (!tx.isRealDealLocal()) {
       // send message to all peers to find out who hosts the transaction
-      FindRemoteTXMessageReplyProcessor processor = sendFindRemoteTXMessage(serverConnection.getCache(),
txId);
+      FindRemoteTXMessageReplyProcessor processor =
+          sendFindRemoteTXMessage(serverConnection.getCache(), txId);
       try {
         processor.waitForRepliesUninterruptibly();
       } catch (ReplyException e) {
diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/TXStateProxyImplTest.java
b/geode-core/src/test/java/org/apache/geode/internal/cache/TXStateProxyImplTest.java
index 1fce367..7d0cfec 100644
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/TXStateProxyImplTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/TXStateProxyImplTest.java
@@ -48,8 +48,8 @@ public class TXStateProxyImplTest {
 
   @Test
   public void getKeyForIteratorReturnsKey() {
-    RegionEntryFactory regionEntryFactory = new RegionEntryFactoryBuilder().getRegionEntryFactoryOrNull(false,
-        false, false, false, false);
+    RegionEntryFactory regionEntryFactory = new RegionEntryFactoryBuilder()
+        .getRegionEntryFactoryOrNull(false, false, false, false, false);
     RegionEntry regionEntry = regionEntryFactory.createEntry(region, key, null);
 
     KeyInfo stringKeyInfo = new KeyInfo(key, null, null);

-- 
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <commits@geode.apache.org>'].

Mime
View raw message