geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasonhu...@apache.org
Subject [geode] branch develop updated: Revert "GEODE-4042: Passing down java.io.tmpdir to tests running in geode-assembly (#1145)"
Date Mon, 11 Dec 2017 22:28:43 GMT
This is an automated email from the ASF dual-hosted git repository.

jasonhuynh pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new 437b3cc  Revert "GEODE-4042: Passing down java.io.tmpdir to tests running in geode-assembly
(#1145)"
437b3cc is described below

commit 437b3cc5b890797e1b79908bff599064f837b798
Author: Jason Huynh <jhuynh@pivotal.io>
AuthorDate: Mon Dec 11 14:36:52 2017 -0800

    Revert "GEODE-4042: Passing down java.io.tmpdir to tests running in geode-assembly (#1145)"
    
    This reverts commit 1569dbf7f69c8f80d4a4a6b311b0107efd023788.
---
 geode-assembly/build.gradle                                      | 1 -
 .../session/tests/TomcatSessionBackwardsCompatibilityTest.java   | 5 ++---
 .../java/org/apache/geode/test/junit/rules/GfshCommandRule.java  | 9 ---------
 3 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/geode-assembly/build.gradle b/geode-assembly/build.gradle
index 4b38b46..7be16ab 100755
--- a/geode-assembly/build.gradle
+++ b/geode-assembly/build.gradle
@@ -121,7 +121,6 @@ test {
 
 tasks.withType(Test){
   environment 'GEODE_HOME', "$buildDir/install/${distributions.main.baseName}"
-  systemProperty 'java.io.tmpdir', System.getProperty('java.io.tmpdir', '/tmp')
 }
 
 task defaultDistributionConfig(type: JavaExec, dependsOn: classes) {
diff --git a/geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTest.java
b/geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTest.java
index a0904a5..aae71e4 100644
--- a/geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTest.java
+++ b/geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTest.java
@@ -14,7 +14,6 @@
  */
 package org.apache.geode.session.tests;
 
-import static org.apache.geode.session.tests.ContainerInstall.TMP_DIR;
 import static org.junit.Assert.assertEquals;
 
 import java.io.File;
@@ -62,10 +61,10 @@ public class TomcatSessionBackwardsCompatibilityTest {
   }
 
   @Rule
-  public transient GfshCommandRule gfsh = new GfshCommandRule(new File(TMP_DIR));
+  public transient GfshCommandRule gfsh = new GfshCommandRule();
 
   @Rule
-  public TemporaryFolder tempFolder = new TemporaryFolder(new File(TMP_DIR));
+  public TemporaryFolder tempFolder = new TemporaryFolder();
 
   @Rule
   public transient TestName testName = new TestName();
diff --git a/geode-core/src/test/java/org/apache/geode/test/junit/rules/GfshCommandRule.java
b/geode-core/src/test/java/org/apache/geode/test/junit/rules/GfshCommandRule.java
index 79fb99f..6ab7908 100644
--- a/geode-core/src/test/java/org/apache/geode/test/junit/rules/GfshCommandRule.java
+++ b/geode-core/src/test/java/org/apache/geode/test/junit/rules/GfshCommandRule.java
@@ -89,15 +89,6 @@ public class GfshCommandRule extends DescribedExternalResource {
     }
   }
 
-  public GfshCommandRule(File parentForTempDirectory) {
-    this.temporaryFolder = new TemporaryFolder(parentForTempDirectory);
-    try {
-      temporaryFolder.create();
-    } catch (IOException e) {
-      throw new UncheckedIOException(e);
-    }
-  }
-
   public GfshCommandRule(Supplier<Integer> portSupplier, PortType portType) {
     this();
     this.portType = portType;

-- 
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <commits@geode.apache.org>'].

Mime
View raw message