geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bschucha...@apache.org
Subject [geode] branch develop updated: GEODE-3683 CacheConnectionTimeoutJUnitTest failing intermittently in CI
Date Tue, 05 Dec 2017 23:34:22 GMT
This is an automated email from the ASF dual-hosted git repository.

bschuchardt pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new 5c9caf4  GEODE-3683 CacheConnectionTimeoutJUnitTest failing intermittently in CI
5c9caf4 is described below

commit 5c9caf441ee35621ed7fb948149547cf85cfee40
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
AuthorDate: Tue Dec 5 15:31:31 2017 -0800

    GEODE-3683 CacheConnectionTimeoutJUnitTest failing intermittently in CI
    
    Increased the maximumTimeBetweenPings from 100ms to 2000ms.  Tests on
    a mac with Intellij showed a minimum of 19ms between finishing the setup
    method and commencing the actual test method.  Adding a short sleep at
    the beginning of the test method caused it to fail repeatedly with the
    lower setting.  A 2 second timeout period allowed the test to succeed
    in 200 consecutive runs.
    '
---
 .../protobuf/v1/acceptance/CacheConnectionTimeoutJUnitTest.java      | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/geode-protobuf/src/test/java/org/apache/geode/internal/protocol/protobuf/v1/acceptance/CacheConnectionTimeoutJUnitTest.java
b/geode-protobuf/src/test/java/org/apache/geode/internal/protocol/protobuf/v1/acceptance/CacheConnectionTimeoutJUnitTest.java
index da65172..b8e4417 100644
--- a/geode-protobuf/src/test/java/org/apache/geode/internal/protocol/protobuf/v1/acceptance/CacheConnectionTimeoutJUnitTest.java
+++ b/geode-protobuf/src/test/java/org/apache/geode/internal/protocol/protobuf/v1/acceptance/CacheConnectionTimeoutJUnitTest.java
@@ -37,6 +37,7 @@ import org.junit.rules.TestName;
 import org.apache.geode.cache.Cache;
 import org.apache.geode.cache.CacheFactory;
 import org.apache.geode.cache.RegionFactory;
+import org.apache.geode.cache.Scope;
 import org.apache.geode.cache.server.CacheServer;
 import org.apache.geode.distributed.ConfigurationProperties;
 import org.apache.geode.internal.AvailablePortHelper;
@@ -89,11 +90,11 @@ public class CacheConnectionTimeoutJUnitTest {
     CacheServer cacheServer = cache.addCacheServer();
     int cacheServerPort = AvailablePortHelper.getRandomAvailableTCPPort();
     cacheServer.setPort(cacheServerPort);
-    cacheServer.setMaximumTimeBetweenPings(100);
+    cacheServer.setMaximumTimeBetweenPings(2000);
     cacheServer.start();
 
     RegionFactory<Object, Object> regionFactory = cache.createRegionFactory();
-    regionFactory.create(TEST_REGION);
+    regionFactory.setScope(Scope.DISTRIBUTED_ACK).create(TEST_REGION);
 
     System.setProperty("geode.feature-protobuf-protocol", "true");
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <commits@geode.apache.org>'].

Mime
View raw message