Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 91D8D200D4E for ; Fri, 17 Nov 2017 01:18:44 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 90A70160BF4; Fri, 17 Nov 2017 00:18:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D654F160BEA for ; Fri, 17 Nov 2017 01:18:43 +0100 (CET) Received: (qmail 33351 invoked by uid 500); 17 Nov 2017 00:18:43 -0000 Mailing-List: contact commits-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list commits@geode.apache.org Received: (qmail 33340 invoked by uid 99); 17 Nov 2017 00:18:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Nov 2017 00:18:43 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 2E19B81C62; Fri, 17 Nov 2017 00:18:41 +0000 (UTC) Date: Fri, 17 Nov 2017 00:18:41 +0000 To: "commits@geode.apache.org" Subject: [geode] branch feature/GEODE-3781 updated: Add missing test MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <151087792174.14411.11880258161140066221@gitbox.apache.org> From: nreich@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: geode X-Git-Refname: refs/heads/feature/GEODE-3781 X-Git-Reftype: branch X-Git-Oldrev: 24096e7ac5b484d7df3b1e70f94dc4cca67630ff X-Git-Newrev: ab71e4471f207f5ea8113d8019a9587e7c5caa6f X-Git-Rev: ab71e4471f207f5ea8113d8019a9587e7c5caa6f X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated archived-at: Fri, 17 Nov 2017 00:18:44 -0000 This is an automated email from the ASF dual-hosted git repository. nreich pushed a commit to branch feature/GEODE-3781 in repository https://gitbox.apache.org/repos/asf/geode.git The following commit(s) were added to refs/heads/feature/GEODE-3781 by this push: new ab71e44 Add missing test ab71e44 is described below commit ab71e4471f207f5ea8113d8019a9587e7c5caa6f Author: Nick Reich AuthorDate: Thu Nov 16 16:18:28 2017 -0800 Add missing test --- .../org/apache/geode/connectors/jdbc/internal/ConnectionManager.java | 2 +- .../apache/geode/connectors/jdbc/internal/xml/ElementTypeTest.java | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ConnectionManager.java b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ConnectionManager.java index 67e6b51..4f4a520 100644 --- a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ConnectionManager.java +++ b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ConnectionManager.java @@ -134,8 +134,8 @@ class ConnectionManager { "The table " + tableName + " has more than one primary key column."); } } catch (SQLException e) { + key = null; handleSQLException(e); - key = null; // never reached } return key; } diff --git a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/xml/ElementTypeTest.java b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/xml/ElementTypeTest.java index 42fe507..cca2bec 100644 --- a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/xml/ElementTypeTest.java +++ b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/xml/ElementTypeTest.java @@ -74,6 +74,11 @@ public class ElementTypeTest { } @Test + public void gettingElementTypeThatDoesNotExistThrowsException() { + assertThatThrownBy(() -> ElementType.getTypeFromName("non-existant element")).isInstanceOf(IllegalArgumentException.class); + } + + @Test public void startElementConnectionServiceThrowsWithoutCacheCreation() { stack.push(new Object()); assertThatThrownBy(() -> CONNECTION_SERVICE.startElement(stack, attributes)) -- To stop receiving notification emails like this one, please contact ['"commits@geode.apache.org" '].