geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From esh...@apache.org
Subject [geode] branch feature/GEODE-3190 updated: Fix review comments.
Date Fri, 27 Oct 2017 20:40:17 GMT
This is an automated email from the ASF dual-hosted git repository.

eshu11 pushed a commit to branch feature/GEODE-3190
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/feature/GEODE-3190 by this push:
     new 9f714e6  Fix review comments.
9f714e6 is described below

commit 9f714e6ef547e47b71fe75baba888160b41af48e
Author: eshu <eshu@pivotal.io>
AuthorDate: Fri Oct 27 13:39:39 2017 -0700

    Fix review comments.
---
 .../java/org/apache/geode/internal/cache/AbstractRegionMap.java     | 4 ++--
 .../cache/DestroyEntryWithConcurrentOperationJUnitTest.java         | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
index 0700c31..52d6e62 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
@@ -94,8 +94,8 @@ public abstract class AbstractRegionMap implements RegionMap {
   protected CustomEntryConcurrentHashMap<Object, Object> map;
 
   /**
-   * This test hook is used to force the conditions for defect 48182. This hook is used by
-   * Bug48182JUnitTest.
+   * This test hook is used to force the conditions during entry destroy. This hook is used
by
+   * DestroyEntryWithConcurrentOperationJUnitTest.
    */
   static Runnable testHookRunnableForConcurrentOperation = null;
 
diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/DestroyEntryWithConcurrentOperationJUnitTest.java
b/geode-core/src/test/java/org/apache/geode/internal/cache/DestroyEntryWithConcurrentOperationJUnitTest.java
index 8650e90..98e99a8 100644
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/DestroyEntryWithConcurrentOperationJUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/DestroyEntryWithConcurrentOperationJUnitTest.java
@@ -133,12 +133,12 @@ public class DestroyEntryWithConcurrentOperationJUnitTest {
 
   @Test
   public void testEntryDestroyWithCacheClose() throws Exception {
-    testEntryDestroyWithCacheClose(false);
+    verifyEntryDestroyWithCacheClose(false);
   }
 
   @Test
   public void testOffHeapRegionEntryDestroyWithCacheClose() throws Exception {
-    testEntryDestroyWithCacheClose(true);
+    verifyEntryDestroyWithCacheClose(true);
   }
 
   /**
@@ -147,7 +147,7 @@ public class DestroyEntryWithConcurrentOperationJUnitTest {
    * CacheClosedException is thrown rather than an EntryNotFoundException (or any other exception
    * type for that matter).
    */
-  private void testEntryDestroyWithCacheClose(boolean isOffHeap) {
+  private void verifyEntryDestroyWithCacheClose(boolean isOffHeap) {
     AbstractRegionMap.testHookRunnableForConcurrentOperation = new Runnable() {
       @Override
       public void run() {

-- 
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <commits@geode.apache.org>'].

Mime
View raw message