geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bogle...@apache.org
Subject [geode] branch feature/GEODE-3026 updated: GEMDEO-3026: Renamed RegionService to RegionCacheService
Date Thu, 12 Oct 2017 21:51:30 GMT
This is an automated email from the ASF dual-hosted git repository.

boglesby pushed a commit to branch feature/GEODE-3026
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/feature/GEODE-3026 by this push:
     new 5a2cb6b  GEMDEO-3026: Renamed RegionService to RegionCacheService
5a2cb6b is described below

commit 5a2cb6b0b5a97b52e7bd6352437bded6811b96ee
Author: Barry Oglesby <boglesby@pivotal.io>
AuthorDate: Thu Oct 12 14:47:27 2017 -0700

    GEMDEO-3026: Renamed RegionService to RegionCacheService
---
 .../main/java/org/apache/geode/internal/cache/LocalRegion.java    | 8 ++++----
 .../cache/{RegionService.java => RegionCacheService.java}         | 4 ++--
 .../apache/geode/cache/lucene/internal/InternalLuceneService.java | 4 ++--
 .../apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java   | 2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java b/geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java
index 017ba05..94e5e58 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java
@@ -1128,16 +1128,16 @@ public class LocalRegion extends AbstractRegion implements LoaderHelperFactory,
 
   protected void invokeBeforeRegionDestroyInServices() {
     for (CacheService service : this.cache.getServices()) {
-      if (service instanceof RegionService) {
-        ((RegionService) service).beforeRegionDestroyed(this);
+      if (service instanceof RegionCacheService) {
+        ((RegionCacheService) service).beforeRegionDestroyed(this);
       }
     }
   }
 
   protected void invokeCleanupFailedInitializationInServices() {
     for (CacheService service : this.cache.getServices()) {
-      if (service instanceof RegionService) {
-        ((RegionService) service).cleanupFailedInitialization(this);
+      if (service instanceof RegionCacheService) {
+        ((RegionCacheService) service).cleanupFailedInitialization(this);
       }
     }
   }
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/RegionService.java b/geode-core/src/main/java/org/apache/geode/internal/cache/RegionCacheService.java
similarity index 91%
rename from geode-core/src/main/java/org/apache/geode/internal/cache/RegionService.java
rename to geode-core/src/main/java/org/apache/geode/internal/cache/RegionCacheService.java
index 9d79606..dc1fe83 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/RegionService.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/RegionCacheService.java
@@ -17,9 +17,9 @@ package org.apache.geode.internal.cache;
 import org.apache.geode.cache.Region;
 
 /**
- * Interface for a service that is linked to a region.
+ * Interface for a CacheService that is linked to a region.
  */
-public interface RegionService extends CacheService {
+public interface RegionCacheService extends CacheService {
 
   /**
    * Called before a region is destroyed.
diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/InternalLuceneService.java
b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/InternalLuceneService.java
index 3c27d80..5bc7986 100644
--- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/InternalLuceneService.java
+++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/InternalLuceneService.java
@@ -17,9 +17,9 @@ package org.apache.geode.cache.lucene.internal;
 
 import org.apache.geode.cache.Cache;
 import org.apache.geode.cache.lucene.LuceneService;
-import org.apache.geode.internal.cache.RegionService;
+import org.apache.geode.internal.cache.RegionCacheService;
 import org.apache.geode.internal.cache.extension.Extension;
 
-public interface InternalLuceneService extends LuceneService, Extension<Cache>, RegionService
{
+public interface InternalLuceneService extends LuceneService, Extension<Cache>, RegionCacheService
{
 
 }
diff --git a/geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
b/geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
index fc8441b..33e1ce5 100644
--- a/geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
+++ b/geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java
@@ -345,7 +345,7 @@ public class LuceneIndexCreationDUnitTest extends LuceneDUnitTest {
     // Verify dataStore2 has no AsyncEventQueues
     dataStore2.invoke(() -> verifyAsyncEventQueues(0));
 
-    // Create a Cache in dataStore2 with a PR defining 10 buckets
+    // Create a Cache in dataStore2 with a PR defining 10 buckets. This will succeed.
     dataStore2.invoke(() -> initDataStore(RegionTestableType.PARTITION));
 
     // Verify dataStore2 has two AsyncEventQueues

-- 
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <commits@geode.apache.org>'].

Mime
View raw message