geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bschucha...@apache.org
Subject geode git commit: GEODE-3408 Flood of EOF warnings
Date Thu, 24 Aug 2017 22:59:09 GMT
Repository: geode
Updated Branches:
  refs/heads/develop e96281ee8 -> 6eb8611d3


GEODE-3408 Flood of EOF warnings

Modified the message handler to catch EOFException and effect shutdown
of the connection & server thread.  I also fixed the handling of
IOException.

The methods invoked are the same as for the old protocol's handling
of EOFException and IOException


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/6eb8611d
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/6eb8611d
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/6eb8611d

Branch: refs/heads/develop
Commit: 6eb8611d3f29ffc8514ac8bda5edc4e914c2e94d
Parents: e96281e
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Authored: Thu Aug 24 15:57:53 2017 -0700
Committer: Bruce Schuchardt <bschuchardt@pivotal.io>
Committed: Thu Aug 24 15:59:02 2017 -0700

----------------------------------------------------------------------
 .../cache/tier/sockets/GenericProtocolServerConnection.java   | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/6eb8611d/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
index cd1647a..0b221b0 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
@@ -22,6 +22,7 @@ import org.apache.geode.internal.security.SecurityService;
 import org.apache.geode.security.SecurityManager;
 import org.apache.geode.security.StreamAuthenticator;
 
+import java.io.EOFException;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
@@ -64,9 +65,13 @@ public class GenericProtocolServerConnection extends ServerConnection {
         messageHandler.receiveMessage(inputStream, outputStream,
             new MessageExecutionContext(this.getCache()));
       }
+    } catch (EOFException e) {
+      this.setFlagProcessMessagesAsFalse();
+      setClientDisconnectedException(e);
     } catch (IOException e) {
       logger.warn(e);
-      this.setFlagProcessMessagesAsFalse(); // TODO: better shutdown.
+      this.setFlagProcessMessagesAsFalse();
+      setClientDisconnectedException(e);
     }
   }
 


Mime
View raw message