geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dschnei...@apache.org
Subject [44/47] geode git commit: GEODE-3249 Validate internal client/server messages
Date Thu, 31 Aug 2017 01:26:21 GMT
GEODE-3249 Validate internal client/server messages

The addition of USER_CREDENTIAL_MESSAGE in ServerConnection.isInternalMessage
caused problems for the c++ client.  This message class does require
credentials and shouldn't be included in the set of internal messages.


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/f2492bf0
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/f2492bf0
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/f2492bf0

Branch: refs/heads/feature/GEODE-3543
Commit: f2492bf0abdc662cc080f1e2c0f17257e05604a3
Parents: 17662cd
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Authored: Wed Aug 30 13:50:48 2017 -0700
Committer: Bruce Schuchardt <bschuchardt@pivotal.io>
Committed: Wed Aug 30 13:52:50 2017 -0700

----------------------------------------------------------------------
 .../apache/geode/internal/cache/tier/sockets/ServerConnection.java  | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/f2492bf0/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
index 6f56e85..1925898 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
@@ -1097,7 +1097,6 @@ public abstract class ServerConnection implements Runnable {
   public boolean isInternalMessage(Message message, boolean allowOldInternalMessages) {
     int messageType = message.getMessageType();
     boolean isInternalMessage = messageType == MessageType.PING
-        || messageType == MessageType.USER_CREDENTIAL_MESSAGE
         || messageType == MessageType.REQUEST_EVENT_VALUE || messageType == MessageType.MAKE_PRIMARY
         || messageType == MessageType.REMOVE_USER_AUTH || messageType == MessageType.CLIENT_READY
         || messageType == MessageType.SIZE || messageType == MessageType.TX_FAILOVER


Mime
View raw message