Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 52B18200CAD for ; Wed, 28 Jun 2017 17:15:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 51824160BE8; Wed, 28 Jun 2017 15:15:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 50B64160BFC for ; Wed, 28 Jun 2017 17:15:43 +0200 (CEST) Received: (qmail 15191 invoked by uid 500); 28 Jun 2017 15:15:42 -0000 Mailing-List: contact commits-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list commits@geode.apache.org Received: (qmail 15006 invoked by uid 99); 28 Jun 2017 15:15:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jun 2017 15:15:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 93DDDE96BD; Wed, 28 Jun 2017 15:15:41 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: echobravo@apache.org To: commits@geode.apache.org Date: Wed, 28 Jun 2017 15:15:45 -0000 Message-Id: <00f3e1cb66a7448a9fadba687e7ab9c0@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [05/10] geode-native git commit: Close ACE_SOCK_Stream before deleting it archived-at: Wed, 28 Jun 2017 15:15:44 -0000 Close ACE_SOCK_Stream before deleting it GF_SAFE_DELETE will delete the ACE_SOCK_Stream object but the socket will still be open. Project: http://git-wip-us.apache.org/repos/asf/geode-native/repo Commit: http://git-wip-us.apache.org/repos/asf/geode-native/commit/9ca823f8 Tree: http://git-wip-us.apache.org/repos/asf/geode-native/tree/9ca823f8 Diff: http://git-wip-us.apache.org/repos/asf/geode-native/diff/9ca823f8 Branch: refs/heads/feature/GEODE-3143 Commit: 9ca823f889c53d5603d3e3ecf866a8fe085fc012 Parents: 0b31ccc Author: fdaniel7 Authored: Wed Jun 28 11:10:34 2017 +0300 Committer: fdaniel7 Committed: Wed Jun 28 11:10:34 2017 +0300 ---------------------------------------------------------------------- .gitignore | 8 ++++++++ src/cppcache/src/TcpConn.cpp | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/geode-native/blob/9ca823f8/.gitignore ---------------------------------------------------------------------- diff --git a/.gitignore b/.gitignore index 9943eda..593afa1 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,11 @@ /.settings/ /.cproject /.project +.vs/config/applicationhost.config +src/CMakeSettings.json +.vs/slnx.sqlite +*.json +.vs/geode-native2/v15/Browse.VC.opendb +*.db +.vs/geode-native2/v15/.suo +.vs/geode-native2/v15/ipch/AutoPCH/1f9ac4ce/GEODE_BASE-2ee16599/GEODE_BASE.ipch http://git-wip-us.apache.org/repos/asf/geode-native/blob/9ca823f8/src/cppcache/src/TcpConn.cpp ---------------------------------------------------------------------- diff --git a/src/cppcache/src/TcpConn.cpp b/src/cppcache/src/TcpConn.cpp index 3c3747d..b80aa51 100644 --- a/src/cppcache/src/TcpConn.cpp +++ b/src/cppcache/src/TcpConn.cpp @@ -269,7 +269,7 @@ void TcpConn::connect() { ACE_OS::snprintf(msg, 256, "TcpConn::connect failed with errno: %d: %s", lastError, ACE_OS::strerror(lastError)); // this is only called by constructor, so we must delete m_io - GF_SAFE_DELETE(m_io); + close(); throw GeodeIOException(msg); } int rc = this->m_io->enable(ACE_NONBLOCK);