geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From echobr...@apache.org
Subject geode-native git commit: GEODE-3143: Close socket before deleting it.
Date Wed, 28 Jun 2017 16:06:58 GMT
Repository: geode-native
Updated Branches:
  refs/heads/develop 25f2a923b -> d92d8cdd7


GEODE-3143: Close socket before deleting it.

 - Close ACE_SOCK_Stream before deleting it

 - GF_SAFE_DELETE will delete the ACE_SOCK_Stream
   but the socket will stil be open


Project: http://git-wip-us.apache.org/repos/asf/geode-native/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode-native/commit/d92d8cdd
Tree: http://git-wip-us.apache.org/repos/asf/geode-native/tree/d92d8cdd
Diff: http://git-wip-us.apache.org/repos/asf/geode-native/diff/d92d8cdd

Branch: refs/heads/develop
Commit: d92d8cdd7628bcdd29a8df2dcb1e933e644ee623
Parents: 25f2a92
Author: fdaniel7 <fdaniel@amdocs.com>
Authored: Wed Jun 28 10:33:14 2017 +0300
Committer: Ernest Burghardt <eburghardt@pivotal.io>
Committed: Wed Jun 28 08:37:46 2017 -0700

----------------------------------------------------------------------
 src/cppcache/src/TcpConn.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode-native/blob/d92d8cdd/src/cppcache/src/TcpConn.cpp
----------------------------------------------------------------------
diff --git a/src/cppcache/src/TcpConn.cpp b/src/cppcache/src/TcpConn.cpp
index 3c3747d..b80aa51 100644
--- a/src/cppcache/src/TcpConn.cpp
+++ b/src/cppcache/src/TcpConn.cpp
@@ -269,7 +269,7 @@ void TcpConn::connect() {
     ACE_OS::snprintf(msg, 256, "TcpConn::connect failed with errno: %d: %s",
                      lastError, ACE_OS::strerror(lastError));
     //  this is only called by constructor, so we must delete m_io
-    GF_SAFE_DELETE(m_io);
+	close();
     throw GeodeIOException(msg);
   }
   int rc = this->m_io->enable(ACE_NONBLOCK);


Mime
View raw message