geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject [10/18] geode git commit: GEODE-2980: remove unnecessary explicit keywords from interfaces
Date Wed, 14 Jun 2017 18:39:14 GMT
http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/DMStats.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/DMStats.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/DMStats.java
index 6397c06..b2a7134 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/DMStats.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/DMStats.java
@@ -24,539 +24,539 @@ public interface DMStats {
   /**
    * Returns the total number of messages sent by the distribution manager
    */
-  public long getSentMessages();
+  long getSentMessages();
 
   /**
    * Increments the total number of messages sent by the distribution manager
    */
-  public void incSentMessages(long messages);
+  void incSentMessages(long messages);
 
-  public void incTOSentMsg();
+  void incTOSentMsg();
 
   /**
    * Returns the total number of transaction commit messages sent by the distribution manager
    */
-  public long getSentCommitMessages();
+  long getSentCommitMessages();
 
   /**
    * Increments the total number of transaction commit messages sent by the distribution manager
    */
-  public void incSentCommitMessages(long messages);
+  void incSentCommitMessages(long messages);
 
   /**
    * Returns the total number commits that had to wait for an ack before completion.
    */
-  public long getCommitWaits();
+  long getCommitWaits();
 
   /**
    * Increments the number of commit waits by one.
    */
-  public void incCommitWaits();
+  void incCommitWaits();
 
   /**
    * Returns the total number of nanoseconds spent sending messages.
    */
-  public long getSentMessagesTime();
+  long getSentMessagesTime();
 
   /**
    * Increments the total number of nanoseconds spent sending messages.
    */
-  public void incSentMessagesTime(long nanos);
+  void incSentMessagesTime(long nanos);
 
   /**
    * Returns the total number of messages broadcast by the distribution manager
    */
-  public long getBroadcastMessages();
+  long getBroadcastMessages();
 
   /**
    * Increments the total number of messages broadcast by the distribution manager
    */
-  public void incBroadcastMessages(long messages);
+  void incBroadcastMessages(long messages);
 
   /**
    * Returns the total number of nanoseconds spent sending messages.
    */
-  public long getBroadcastMessagesTime();
+  long getBroadcastMessagesTime();
 
   /**
    * Increments the total number of nanoseconds spend sending messages.
    */
-  public void incBroadcastMessagesTime(long nanos);
+  void incBroadcastMessagesTime(long nanos);
 
   /**
    * Returns the total number of messages received by the distribution manager
    */
-  public long getReceivedMessages();
+  long getReceivedMessages();
 
   /**
    * Increments the total number of messages received by the distribution manager
    */
-  public void incReceivedMessages(long messages);
+  void incReceivedMessages(long messages);
 
   /**
    * Returns the total number of message bytes received by the distribution manager
    */
-  public long getReceivedBytes();
+  long getReceivedBytes();
 
   /**
    * Increments the total number of message bytes received by the distribution manager
    */
-  public void incReceivedBytes(long bytes);
+  void incReceivedBytes(long bytes);
 
   /**
    * Increments the total number of message bytes sent by the distribution manager
    */
-  public void incSentBytes(long bytes);
+  void incSentBytes(long bytes);
 
   /**
    * Returns the total number of messages processed by the distribution manager
    */
-  public long getProcessedMessages();
+  long getProcessedMessages();
 
   /**
    * Increments the total number of messages processed by the distribution manager
    */
-  public void incProcessedMessages(long messages);
+  void incProcessedMessages(long messages);
 
   /**
    * Returns the total number of nanoseconds spent processing messages.
    */
-  public long getProcessedMessagesTime();
+  long getProcessedMessagesTime();
 
   /**
    * Increments the total number of nanoseconds spent processing messages.
    */
-  public void incProcessedMessagesTime(long nanos);
+  void incProcessedMessagesTime(long nanos);
 
   /**
    * Returns the total number of nanoseconds spent scheduling messages to be processed.
    */
-  public long getMessageProcessingScheduleTime();
+  long getMessageProcessingScheduleTime();
 
-  public void incBatchSendTime(long start);
+  void incBatchSendTime(long start);
 
-  public void incBatchCopyTime(long start);
+  void incBatchCopyTime(long start);
 
-  public void incBatchWaitTime(long start);
+  void incBatchWaitTime(long start);
 
-  public void incBatchFlushTime(long start);
+  void incBatchFlushTime(long start);
 
   /**
    * Increments the total number of nanoseconds spent scheduling messages to be processed.
    */
-  public void incMessageProcessingScheduleTime(long nanos);
+  void incMessageProcessingScheduleTime(long nanos);
 
-  public int getOverflowQueueSize();
+  int getOverflowQueueSize();
 
-  public void incOverflowQueueSize(int messages);
+  void incOverflowQueueSize(int messages);
 
-  public int getNumProcessingThreads();
+  int getNumProcessingThreads();
 
-  public void incNumProcessingThreads(int threads);
+  void incNumProcessingThreads(int threads);
 
-  public int getNumSerialThreads();
+  int getNumSerialThreads();
 
-  public void incNumSerialThreads(int threads);
+  void incNumSerialThreads(int threads);
 
-  public void incMessageChannelTime(long val);
+  void incMessageChannelTime(long val);
 
-  public void incUDPDispatchRequestTime(long val);
+  void incUDPDispatchRequestTime(long val);
 
-  public long getUDPDispatchRequestTime();
+  long getUDPDispatchRequestTime();
 
-  public long getReplyMessageTime();
+  long getReplyMessageTime();
 
-  public void incReplyMessageTime(long val);
+  void incReplyMessageTime(long val);
 
-  public long getDistributeMessageTime();
+  long getDistributeMessageTime();
 
-  public void incDistributeMessageTime(long val);
+  void incDistributeMessageTime(long val);
 
-  public long startSocketWrite(boolean sync);
+  long startSocketWrite(boolean sync);
 
-  public void endSocketWrite(boolean sync, long start, int bytesWritten, int retries);
+  void endSocketWrite(boolean sync, long start, int bytesWritten, int retries);
 
   /**
    * increments the number of unicast writes performed and the number of bytes written
    * 
    * @since GemFire 5.0
    */
-  public void incUcastWriteBytes(int bytesWritten);
+  void incUcastWriteBytes(int bytesWritten);
 
   /**
    * increment the number of unicast datagram payload bytes received and the number of unicast reads
    * performed
    */
-  public void incUcastReadBytes(int amount);
+  void incUcastReadBytes(int amount);
 
   /**
    * increment the number of multicast datagrams sent and the number of multicast bytes transmitted
    */
-  public void incMcastWriteBytes(int bytesWritten);
+  void incMcastWriteBytes(int bytesWritten);
 
   /**
    * increment the number of multicast datagram payload bytes received, and the number of mcast
    * messages read
    */
-  public void incMcastReadBytes(int amount);
+  void incMcastReadBytes(int amount);
 
   /**
    * returns the current value of the mcastWrites statistic
    */
-  public int getMcastWrites();
+  int getMcastWrites();
 
-  public int getMcastReads();
+  int getMcastReads();
 
-  public long startSerialization();
+  long startSerialization();
 
-  public void endSerialization(long start, int bytes);
+  void endSerialization(long start, int bytes);
 
-  public long startDeserialization();
+  long startDeserialization();
 
-  public void endDeserialization(long start, int bytes);
+  void endDeserialization(long start, int bytes);
 
-  public long startMsgSerialization();
+  long startMsgSerialization();
 
-  public void endMsgSerialization(long start);
+  void endMsgSerialization(long start);
 
-  public long startUDPMsgEncryption();
+  long startUDPMsgEncryption();
 
-  public void endUDPMsgEncryption(long start);
+  void endUDPMsgEncryption(long start);
 
-  public long startUDPMsgDecryption();
+  long startUDPMsgDecryption();
 
-  public void endUDPMsgDecryption(long start);
+  void endUDPMsgDecryption(long start);
 
-  public long startMsgDeserialization();
+  long startMsgDeserialization();
 
-  public void endMsgDeserialization(long start);
+  void endMsgDeserialization(long start);
 
-  public long getUDPMsgEncryptionTiime();
+  long getUDPMsgEncryptionTiime();
 
-  public long getUDPMsgDecryptionTime();
+  long getUDPMsgDecryptionTime();
 
-  public int getNodes();
+  int getNodes();
 
-  public void setNodes(int val);
+  void setNodes(int val);
 
-  public void incNodes(int val);
+  void incNodes(int val);
 
-  public int getReplyWaitsInProgress();
+  int getReplyWaitsInProgress();
 
-  public int getReplyWaitsCompleted();
+  int getReplyWaitsCompleted();
 
-  public long getReplyWaitTime();
+  long getReplyWaitTime();
 
   /**
    * @return the timestamp that marks the start of the operation
    */
-  public long startReplyWait();
+  long startReplyWait();
 
   /**
    * @param startNanos the timestamp taken when the operation started
    * @param initTime the time the operation begain (before msg transmission)
    */
-  public void endReplyWait(long startNanos, long initTime);
+  void endReplyWait(long startNanos, long initTime);
 
   /**
    * Increments the number of message replies that have timed out
    *
    * @since GemFire 3.5
    */
-  public void incReplyTimeouts();
+  void incReplyTimeouts();
 
   /**
    * Returns the number of message replies that have timed out
    *
    * @since GemFire 3.5
    */
-  public long getReplyTimeouts();
+  long getReplyTimeouts();
 
   /**
    * @since GemFire 4.1
    */
-  public void incReceivers();
+  void incReceivers();
 
   /**
    * @since GemFire 4.1
    */
-  public void decReceivers();
+  void decReceivers();
 
   /**
    * @since GemFire 4.1
    */
-  public void incFailedAccept();
+  void incFailedAccept();
 
   /**
    * @since GemFire 4.1
    */
-  public void incFailedConnect();
+  void incFailedConnect();
 
   /**
    * @since GemFire 4.1.1
    */
-  public void incReconnectAttempts();
+  void incReconnectAttempts();
 
   /**
    * @since GemFire 4.1
    */
-  public void incLostLease();
+  void incLostLease();
 
   /**
    * @since GemFire 4.1
    */
-  public void incSenders(boolean shared, boolean preserveOrder);
+  void incSenders(boolean shared, boolean preserveOrder);
 
   /**
    * @since GemFire 4.1
    */
-  public void decSenders(boolean shared, boolean preserveOrder);
+  void decSenders(boolean shared, boolean preserveOrder);
 
   /**
    * @since GemFire 4.1
    */
-  public int getSendersSU();
+  int getSendersSU();
 
   /**
    * increment the number of unicast UDP retransmission requests received from other processes
    * 
    * @since GemFire 5.0
    */
-  public void incUcastRetransmits();
+  void incUcastRetransmits();
 
   /**
    * increment the number of multicast UDP retransmissions sent to other processes
    * 
    * @since GemFire 5.0
    */
-  public void incMcastRetransmits();
+  void incMcastRetransmits();
 
   /**
    * returns the current number of multicast retransmission requests processed
    */
-  public int getMcastRetransmits();
+  int getMcastRetransmits();
 
   /**
    * increment the number of multicast UDP retransmission requests sent to other processes
    * 
    * @since GemFire 5.0
    */
-  public void incMcastRetransmitRequests();
+  void incMcastRetransmitRequests();
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncSocketWritesInProgress();
+  int getAsyncSocketWritesInProgress();
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncSocketWrites();
+  int getAsyncSocketWrites();
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncSocketWriteRetries();
+  int getAsyncSocketWriteRetries();
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncSocketWriteBytes();
+  long getAsyncSocketWriteBytes();
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncSocketWriteTime();
+  long getAsyncSocketWriteTime();
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncQueues();
+  int getAsyncQueues();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncQueues(int inc);
+  void incAsyncQueues(int inc);
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncQueueFlushesInProgress();
+  int getAsyncQueueFlushesInProgress();
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncQueueFlushesCompleted();
+  int getAsyncQueueFlushesCompleted();
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncQueueFlushTime();
+  long getAsyncQueueFlushTime();
 
   /**
    * @since GemFire 4.2.2
    */
-  public long startAsyncQueueFlush();
+  long startAsyncQueueFlush();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void endAsyncQueueFlush(long start);
+  void endAsyncQueueFlush(long start);
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncQueueTimeouts();
+  int getAsyncQueueTimeouts();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncQueueTimeouts(int inc);
+  void incAsyncQueueTimeouts(int inc);
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncQueueSizeExceeded();
+  int getAsyncQueueSizeExceeded();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncQueueSizeExceeded(int inc);
+  void incAsyncQueueSizeExceeded(int inc);
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncDistributionTimeoutExceeded();
+  int getAsyncDistributionTimeoutExceeded();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncDistributionTimeoutExceeded();
+  void incAsyncDistributionTimeoutExceeded();
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncQueueSize();
+  long getAsyncQueueSize();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncQueueSize(long inc);
+  void incAsyncQueueSize(long inc);
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncQueuedMsgs();
+  long getAsyncQueuedMsgs();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncQueuedMsgs();
+  void incAsyncQueuedMsgs();
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncDequeuedMsgs();
+  long getAsyncDequeuedMsgs();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncDequeuedMsgs();
+  void incAsyncDequeuedMsgs();
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncConflatedMsgs();
+  long getAsyncConflatedMsgs();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncConflatedMsgs();
+  void incAsyncConflatedMsgs();
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncThreads();
+  int getAsyncThreads();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncThreads(int inc);
+  void incAsyncThreads(int inc);
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncThreadInProgress();
+  int getAsyncThreadInProgress();
 
   /**
    * @since GemFire 4.2.2
    */
-  public int getAsyncThreadCompleted();
+  int getAsyncThreadCompleted();
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncThreadTime();
+  long getAsyncThreadTime();
 
   /**
    * @since GemFire 4.2.2
    */
-  public long startAsyncThread();
+  long startAsyncThread();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void endAsyncThread(long start);
+  void endAsyncThread(long start);
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncQueueAddTime();
+  long getAsyncQueueAddTime();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncQueueAddTime(long inc);
+  void incAsyncQueueAddTime(long inc);
 
   /**
    * @since GemFire 4.2.2
    */
-  public long getAsyncQueueRemoveTime();
+  long getAsyncQueueRemoveTime();
 
   /**
    * @since GemFire 4.2.2
    */
-  public void incAsyncQueueRemoveTime(long inc);
+  void incAsyncQueueRemoveTime(long inc);
 
   /**
    * @since GemFire 5.0.2.4
    */
-  public void incReceiverBufferSize(int inc, boolean direct);
+  void incReceiverBufferSize(int inc, boolean direct);
 
   /**
    * @since GemFire 5.0.2.4
    */
-  public void incSenderBufferSize(int inc, boolean direct);
+  void incSenderBufferSize(int inc, boolean direct);
 
   /**
    * @since GemFire 5.0.2.4
    */
-  public long startSocketLock();
+  long startSocketLock();
 
   /**
    * @since GemFire 5.0.2.4
    */
-  public void endSocketLock(long start);
+  void endSocketLock(long start);
 
   /**
    * @since GemFire 5.0.2.4
    */
-  public long startBufferAcquire();
+  long startBufferAcquire();
 
   /**
    * @since GemFire 5.0.2.4
    */
-  public void endBufferAcquire(long start);
+  void endBufferAcquire(long start);
 
   /**
    * increment/decrement the number of thread-owned receivers with the given domino count
@@ -564,7 +564,7 @@ public interface DMStats {
    * @param value
    * @param dominoCount thread-owned connection chain count
    */
-  public void incThreadOwnedReceivers(long value, int dominoCount);
+  void incThreadOwnedReceivers(long value, int dominoCount);
 
   /**
    * Called when a new message is received.
@@ -574,7 +574,7 @@ public interface DMStats {
    * @param bytes the number of bytes read, so far, for the message being received.
    * @since GemFire 5.0.2
    */
-  public void incMessagesBeingReceived(boolean newMsg, int bytes);
+  void incMessagesBeingReceived(boolean newMsg, int bytes);
 
   /**
    * Called when we finish processing a received message.
@@ -582,108 +582,108 @@ public interface DMStats {
    * @param bytes the number of bytes read off the wire for the message we have finished with.
    * @since GemFire 5.0.2
    */
-  public void decMessagesBeingReceived(int bytes);
+  void decMessagesBeingReceived(int bytes);
 
-  public void incReplyHandOffTime(long start);
+  void incReplyHandOffTime(long start);
 
   /**
    * Returns 1 if the system elder is this member, else returns 0.
    * 
    * @return 1 if the system elder is this member, else returns 0
    */
-  public int getElders();
+  int getElders();
 
-  public void incElders(int val);
+  void incElders(int val);
 
   /**
    * Returns the number of initial image reply messages sent from this member which have not yet
    * been acked.
    */
-  public int getInitialImageMessagesInFlight();
+  int getInitialImageMessagesInFlight();
 
-  public void incInitialImageMessagesInFlight(int val);
+  void incInitialImageMessagesInFlight(int val);
 
   /**
    * Returns the number of initial images this member is currently requesting.
    */
-  public int getInitialImageRequestsInProgress();
+  int getInitialImageRequestsInProgress();
 
-  public void incInitialImageRequestsInProgress(int val);
+  void incInitialImageRequestsInProgress(int val);
 
-  public void incPdxSerialization(int bytesWritten);
+  void incPdxSerialization(int bytesWritten);
 
-  public void incPdxDeserialization(int i);
+  void incPdxDeserialization(int i);
 
-  public long startPdxInstanceDeserialization();
+  long startPdxInstanceDeserialization();
 
-  public void endPdxInstanceDeserialization(long start);
+  void endPdxInstanceDeserialization(long start);
 
-  public void incPdxInstanceCreations();
+  void incPdxInstanceCreations();
 
   // Stats for GMSHealthMonitor
-  public long getHeartbeatRequestsSent();
+  long getHeartbeatRequestsSent();
 
-  public void incHeartbeatRequestsSent();
+  void incHeartbeatRequestsSent();
 
-  public long getHeartbeatRequestsReceived();
+  long getHeartbeatRequestsReceived();
 
-  public void incHeartbeatRequestsReceived();
+  void incHeartbeatRequestsReceived();
 
-  public long getHeartbeatsSent();
+  long getHeartbeatsSent();
 
-  public void incHeartbeatsSent();
+  void incHeartbeatsSent();
 
-  public long getHeartbeatsReceived();
+  long getHeartbeatsReceived();
 
-  public void incHeartbeatsReceived();
+  void incHeartbeatsReceived();
 
 
-  public long getSuspectsSent();
+  long getSuspectsSent();
 
-  public void incSuspectsSent();
+  void incSuspectsSent();
 
-  public long getSuspectsReceived();
+  long getSuspectsReceived();
 
-  public void incSuspectsReceived();
+  void incSuspectsReceived();
 
 
-  public long getFinalCheckRequestsSent();
+  long getFinalCheckRequestsSent();
 
-  public void incFinalCheckRequestsSent();
+  void incFinalCheckRequestsSent();
 
-  public long getFinalCheckRequestsReceived();
+  long getFinalCheckRequestsReceived();
 
-  public void incFinalCheckRequestsReceived();
+  void incFinalCheckRequestsReceived();
 
-  public long getFinalCheckResponsesSent();
+  long getFinalCheckResponsesSent();
 
-  public void incFinalCheckResponsesSent();
+  void incFinalCheckResponsesSent();
 
-  public long getFinalCheckResponsesReceived();
+  long getFinalCheckResponsesReceived();
 
-  public void incFinalCheckResponsesReceived();
+  void incFinalCheckResponsesReceived();
 
 
-  public long getTcpFinalCheckRequestsSent();
+  long getTcpFinalCheckRequestsSent();
 
-  public void incTcpFinalCheckRequestsSent();
+  void incTcpFinalCheckRequestsSent();
 
-  public long getTcpFinalCheckRequestsReceived();
+  long getTcpFinalCheckRequestsReceived();
 
-  public void incTcpFinalCheckRequestsReceived();
+  void incTcpFinalCheckRequestsReceived();
 
-  public long getTcpFinalCheckResponsesSent();
+  long getTcpFinalCheckResponsesSent();
 
-  public void incTcpFinalCheckResponsesSent();
+  void incTcpFinalCheckResponsesSent();
 
-  public long getTcpFinalCheckResponsesReceived();
+  long getTcpFinalCheckResponsesReceived();
 
-  public void incTcpFinalCheckResponsesReceived();
+  void incTcpFinalCheckResponsesReceived();
 
 
-  public long getUdpFinalCheckRequestsSent();
+  long getUdpFinalCheckRequestsSent();
 
-  public void incUdpFinalCheckRequestsSent();
+  void incUdpFinalCheckRequestsSent();
 
   // UDP final check is implemented using HeartbeatRequestMessage and HeartbeatMessage
   // So the following code is commented out.
@@ -696,7 +696,7 @@ public interface DMStats {
   //
   // public void incUdpFinalCheckResponsesSent();
 
-  public long getUdpFinalCheckResponsesReceived();
+  long getUdpFinalCheckResponsesReceived();
 
-  public void incUdpFinalCheckResponsesReceived();
+  void incUdpFinalCheckResponsesReceived();
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/DSClock.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/DSClock.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/DSClock.java
index 70bf2c2..9ac8d13 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/DSClock.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/DSClock.java
@@ -295,12 +295,12 @@ public class DSClock implements CacheTime {
     }
   }
 
-  public static interface DSClockTestHook {
-    public void suspendAtBreakPoint(int breakPoint);
+  public interface DSClockTestHook {
+    void suspendAtBreakPoint(int breakPoint);
 
-    public void addInformation(Object key, Object value);
+    void addInformation(Object key, Object value);
 
-    public Object getInformation(Object key);
+    Object getInformation(Object key);
   }
 
   public DSClockTestHook getTestHook() {

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisee.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisee.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisee.java
index 764d3a9..5a2d840 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisee.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisee.java
@@ -31,19 +31,19 @@ public interface DistributionAdvisee {
    * 
    * @return the underlying <code>DistributionManager</code>
    */
-  public DM getDistributionManager();
+  DM getDistributionManager();
 
   /**
    * @return the cancellation object for the advisee
    */
-  public CancelCriterion getCancelCriterion();
+  CancelCriterion getCancelCriterion();
 
   /**
    * Returns the <code>DistributionAdvisor</code> that provides advice for this advisee.
    * 
    * @return the <code>DistributionAdvisor</code>
    */
-  public DistributionAdvisor getDistributionAdvisor();
+  DistributionAdvisor getDistributionAdvisor();
 
   /**
    * Returns the <code>Profile</code> representing this member in the
@@ -51,48 +51,48 @@ public interface DistributionAdvisee {
    * 
    * @return the <code>Profile</code> representing this member
    */
-  public Profile getProfile();
+  Profile getProfile();
 
   /**
    * Returns this advisees parent or null if no parent exists.
    * 
    * @return parent advisee
    */
-  public DistributionAdvisee getParentAdvisee();
+  DistributionAdvisee getParentAdvisee();
 
   /**
    * Returns the underlying <code>InternalDistributedSystem</code> connection.
    * 
    * @return the underlying <code>InternalDistributedSystem</code>
    */
-  public InternalDistributedSystem getSystem();
+  InternalDistributedSystem getSystem();
 
   /**
    * Returns the simple name of this resource.
    * 
    * @return the simple name of this resource
    */
-  public String getName();
+  String getName();
 
   /**
    * Returns the full path of this resource.
    * 
    * @return the full path of this resource.
    */
-  public String getFullPath();
+  String getFullPath();
 
   /**
    * Fill in the <code>Profile</code> with details from the advisee.
    * 
    * @param profile the <code>Profile</code> to fill in with details
    */
-  public void fillInProfile(Profile profile);
+  void fillInProfile(Profile profile);
 
   /**
    * @return the serial number which identifies the static order in which this region was created in
    *         relation to other regions or other instances of this region during the life of this
    *         JVM.
    */
-  public int getSerialNumber();
+  int getSerialNumber();
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java
index 0acc6c2..f5bf255 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java
@@ -1328,7 +1328,7 @@ public class DistributionAdvisor {
    * an arbitrary aggregator that has been passed to the {@link #visit} method. In addition this is
    * public for use by other classes.
    */
-  public static interface ProfileVisitor<T> {
+  public interface ProfileVisitor<T> {
 
     /**
      * Visit a given {@link Profile} accumulating the results in the given aggregate. Returns false
@@ -1510,15 +1510,15 @@ public class DistributionAdvisor {
 
 
   /** Filter interface */
-  protected static interface Filter {
-    public boolean include(Profile profile);
+  protected interface Filter {
+    boolean include(Profile profile);
   }
 
   /**
    * Marker interface to designate on object that serves and the unique id that identifies a
    * Profile.
    */
-  public static interface ProfileId {
+  public interface ProfileId {
   }
   /**
    * Profile information for a remote counterpart.

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/HealthMonitor.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/HealthMonitor.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/HealthMonitor.java
index 531dfaa..a11df19 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/HealthMonitor.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/HealthMonitor.java
@@ -26,20 +26,20 @@ public interface HealthMonitor {
   /**
    * Returns the id of this monitor instance. Each instance is given a unique id when it is created.
    */
-  public int getId();
+  int getId();
 
   /**
    * Resets the current health status to zero.
    */
-  public void resetStatus();
+  void resetStatus();
 
   /**
    * Returns the diagnosis of the desired status.
    */
-  public String[] getDiagnosis(GemFireHealth.Health healthCode);
+  String[] getDiagnosis(GemFireHealth.Health healthCode);
 
   /**
    * Stops the monitor so it no longer checks for health. Once stopped a monitor can not be started.
    */
-  public void stop();
+  void stop();
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
index 22edb6f..7983cfa 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
@@ -1870,7 +1870,7 @@ public class InternalDistributedSystem extends DistributedSystem
    */
   public interface StatisticsVisitor {
 
-    public void visit(Statistics stat);
+    void visit(Statistics stat);
   }
 
   public Set<String> getAllFunctionExecutionIds() {
@@ -2337,7 +2337,7 @@ public class InternalDistributedSystem extends DistributedSystem
      * 
      * @param sys the the system we are disconnecting from process should take before returning.
      */
-    public void onDisconnect(InternalDistributedSystem sys);
+    void onDisconnect(InternalDistributedSystem sys);
 
   }
 
@@ -2352,7 +2352,7 @@ public class InternalDistributedSystem extends DistributedSystem
      * @param oldSystem the old DS, which is in a partially disconnected state and cannot be used
      *        for messaging
      */
-    public void reconnecting(InternalDistributedSystem oldSystem);
+    void reconnecting(InternalDistributedSystem oldSystem);
 
     /**
      * Invoked after a reconnect to the distributed system
@@ -2360,8 +2360,7 @@ public class InternalDistributedSystem extends DistributedSystem
      * @param oldSystem the old DS
      * @param newSystem the new DS
      */
-    public void onReconnect(InternalDistributedSystem oldSystem,
-        InternalDistributedSystem newSystem);
+    void onReconnect(InternalDistributedSystem oldSystem, InternalDistributedSystem newSystem);
   }
 
   /**
@@ -2374,7 +2373,7 @@ public class InternalDistributedSystem extends DistributedSystem
      * 
      * @param sys
      */
-    public void onShutdown(InternalDistributedSystem sys);
+    void onShutdown(InternalDistributedSystem sys);
   }
 
   /**
@@ -2962,7 +2961,7 @@ public class InternalDistributedSystem extends DistributedSystem
     /**
      * Invoked after a connection to the distributed system is created
      */
-    public void onConnect(InternalDistributedSystem sys);
+    void onConnect(InternalDistributedSystem sys);
   }
 
   public String forceStop() {
@@ -3064,8 +3063,8 @@ public class InternalDistributedSystem extends DistributedSystem
    * Privacy Violations that Fortify will complain about.
    * </p>
    */
-  public static interface CreationStackGenerator {
+  public interface CreationStackGenerator {
 
-    public Throwable generateCreationStack(final DistributionConfig config);
+    Throwable generateCreationStack(final DistributionConfig config);
   }
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/MQueue.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/MQueue.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/MQueue.java
index 2b90f7b..7ad58f6 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/MQueue.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/MQueue.java
@@ -25,6 +25,6 @@ public interface MQueue extends BlockingQueue {
   /**
    * Signals the semaphore on which this queue is waiting.
    */
-  public void wakeUp();
+  void wakeUp();
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/MembershipListener.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/MembershipListener.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/MembershipListener.java
index a701c24..a271b85 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/MembershipListener.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/MembershipListener.java
@@ -35,7 +35,7 @@ public interface MembershipListener {
    *
    * @param id The id of the new member that has joined the system
    */
-  public void memberJoined(InternalDistributedMember id);
+  void memberJoined(InternalDistributedMember id);
 
   /**
    * This method is invoked after a member has explicitly left the system. It may not get invoked if
@@ -44,7 +44,7 @@ public interface MembershipListener {
    * @param id The id of the new member that has joined the system
    * @param crashed True if member did not depart in an orderly manner.
    */
-  public void memberDeparted(InternalDistributedMember id, boolean crashed);
+  void memberDeparted(InternalDistributedMember id, boolean crashed);
 
   /**
    * This method is invoked after the group membership service has suspected that a member is no
@@ -54,7 +54,7 @@ public interface MembershipListener {
    * @param whoSuspected the member that initiated suspect processing
    * @param reason the reason the member was suspected
    */
-  public void memberSuspect(InternalDistributedMember id, InternalDistributedMember whoSuspected,
+  void memberSuspect(InternalDistributedMember id, InternalDistributedMember whoSuspected,
       String reason);
 
   /**
@@ -64,7 +64,7 @@ public interface MembershipListener {
    * @param failures members that have been lost
    * @param remaining members that remain
    */
-  public void quorumLost(Set<InternalDistributedMember> failures,
+  void quorumLost(Set<InternalDistributedMember> failures,
       List<InternalDistributedMember> remaining);
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/MessageWithReply.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/MessageWithReply.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/MessageWithReply.java
index e3b8df2..eea6ec9 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/MessageWithReply.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/MessageWithReply.java
@@ -29,10 +29,10 @@ public interface MessageWithReply {
    * Returns the id of the {@link org.apache.geode.distributed.internal.ReplyProcessor21} that is
    * used to handle the reply to this message.
    */
-  public int getProcessorId();
+  int getProcessorId();
 
   /**
    * Returns the id the sender who is waiting for a reply.
    */
-  public InternalDistributedMember getSender();
+  InternalDistributedMember getSender();
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/PoolStatHelper.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/PoolStatHelper.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/PoolStatHelper.java
index d3064d2..b8b2785 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/PoolStatHelper.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/PoolStatHelper.java
@@ -27,10 +27,10 @@ public interface PoolStatHelper {
   /**
    * Called each time the pool starts working on a job.
    */
-  public void startJob();
+  void startJob();
 
   /**
    * Called each time the pool finishes a job it started.
    */
-  public void endJob();
+  void endJob();
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/QueueStatHelper.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/QueueStatHelper.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/QueueStatHelper.java
index 16efe60..a7dd04a 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/QueueStatHelper.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/QueueStatHelper.java
@@ -27,15 +27,15 @@ public interface QueueStatHelper {
   /**
    * Called when an item is added to the queue.
    */
-  public void add();
+  void add();
 
   /**
    * Called when an item is removed from the queue.
    */
-  public void remove();
+  void remove();
 
   /**
    * Called when count items are removed from the queue.
    */
-  public void remove(int count);
+  void remove(int count);
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/ReplySender.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/ReplySender.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/ReplySender.java
index 41ad1bc..eb75181 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/ReplySender.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/ReplySender.java
@@ -30,6 +30,6 @@ import org.apache.geode.internal.cache.DirectReplyMessage;
  */
 public interface ReplySender {
 
-  public Set putOutgoing(DistributionMessage msg);
+  Set putOutgoing(DistributionMessage msg);
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/Sizeable.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/Sizeable.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/Sizeable.java
index bf6785a..eaecb1f 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/Sizeable.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/Sizeable.java
@@ -22,5 +22,5 @@ package org.apache.geode.distributed.internal;
 
 public interface Sizeable {
   /** returns the approximate size of this object */
-  public int getSize();
+  int getSize();
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledMemQueueStatHelper.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledMemQueueStatHelper.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledMemQueueStatHelper.java
index d1aeceb..233e7e6 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledMemQueueStatHelper.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledMemQueueStatHelper.java
@@ -27,26 +27,26 @@ public interface ThrottledMemQueueStatHelper extends QueueStatHelper {
   /**
    * Called each time a thread was delayed by the throttle.
    */
-  public void incThrottleCount();
+  void incThrottleCount();
 
   /**
    * Called after a throttled operation has completed.
    * 
    * @param nanos the amount of time, in nanoseconds, the throttle caused us to wait.
    */
-  public void throttleTime(long nanos);
+  void throttleTime(long nanos);
 
   /**
    * Increments the amount of memory consumed by queue contents.
    * 
    * @param amount number of bytes added to the queue
    */
-  public void addMem(int amount);
+  void addMem(int amount);
 
   /**
    * Decrements the amount of memory consumed by queue contents.
    * 
    * @param amount number of bytes removed from the queue
    */
-  public void removeMem(int amount);
+  void removeMem(int amount);
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledQueueStatHelper.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledQueueStatHelper.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledQueueStatHelper.java
index 46a3d13..88240c6 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledQueueStatHelper.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/ThrottledQueueStatHelper.java
@@ -27,12 +27,12 @@ public interface ThrottledQueueStatHelper extends QueueStatHelper {
   /**
    * Called each time a thread was delayed by the throttle.
    */
-  public void incThrottleCount();
+  void incThrottleCount();
 
   /**
    * Called after a throttled operation has completed.
    * 
    * @param nanos the amount of time, in nanoseconds, the throttle caused us to wait.
    */
-  public void throttleTime(long nanos);
+  void throttleTime(long nanos);
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/WanLocatorDiscoverer.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/WanLocatorDiscoverer.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/WanLocatorDiscoverer.java
index b0c0bfb..fdb2150 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/WanLocatorDiscoverer.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/WanLocatorDiscoverer.java
@@ -18,7 +18,7 @@ import org.apache.geode.cache.client.internal.locator.wan.LocatorMembershipListe
 
 public interface WanLocatorDiscoverer {
 
-  public static final int WAN_LOCATOR_CONNECTION_TIMEOUT =
+  int WAN_LOCATOR_CONNECTION_TIMEOUT =
       Integer.getInteger("WANLocator.CONNECTION_TIMEOUT", 50000).intValue();
 
   /**

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/deadlock/DependencyMonitor.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/deadlock/DependencyMonitor.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/deadlock/DependencyMonitor.java
index 5d43f4d..7adab37 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/deadlock/DependencyMonitor.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/deadlock/DependencyMonitor.java
@@ -29,11 +29,11 @@ public interface DependencyMonitor {
    * Return a map of resource identifiers to the threads that are blocked waiting for those
    * resources.
    */
-  public Set<Dependency<Thread, Serializable>> getBlockedThreads(Thread[] allThreads);
+  Set<Dependency<Thread, Serializable>> getBlockedThreads(Thread[] allThreads);
 
   /**
    * Return a map of resource indentifiers to the threads that hold that particular resource.
    */
-  public Set<Dependency<Serializable, Thread>> getHeldResources(Thread[] allThreads);
+  Set<Dependency<Serializable, Thread>> getHeldResources(Thread[] allThreads);
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/direct/DirectChannelListener.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/direct/DirectChannelListener.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/direct/DirectChannelListener.java
index 6953330..ed68b6b 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/direct/DirectChannelListener.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/direct/DirectChannelListener.java
@@ -24,7 +24,7 @@ public interface DirectChannelListener {
    * 
    * @param o the message that should be processed.
    */
-  public void messageReceived(DistributionMessage o);
+  void messageReceived(DistributionMessage o);
 
 
   /**
@@ -32,6 +32,6 @@ public interface DirectChannelListener {
    * 
    * @return the distribution manager
    */
-  public DistributionManager getDM();
+  DistributionManager getDM();
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatch.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatch.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatch.java
index 54d91e9..3f142ee 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatch.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatch.java
@@ -25,20 +25,20 @@ import org.apache.geode.distributed.internal.membership.*;
 public interface DLockBatch {
 
   /** Returns the originator (owner) of this batch of locks */
-  public InternalDistributedMember getOwner();
+  InternalDistributedMember getOwner();
 
   /** Returns the identity object of the batch; like a hash map key */
-  public DLockBatchId getBatchId();
+  DLockBatchId getBatchId();
 
   /** Returns the list of TXRegionLockRequest instances */
-  public List getReqs();
+  List getReqs();
 
   /**
    * Specifies the lock grantor id that granted this lock batch.
    * 
    * @param lockGrantorId the lock grantor id that granted this lock batch
    */
-  public void grantedBy(LockGrantorId lockGrantorId);
+  void grantedBy(LockGrantorId lockGrantorId);
 
 }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatchId.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatchId.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatchId.java
index cbe00fa..b90b5b5 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatchId.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockBatchId.java
@@ -23,6 +23,6 @@ import org.apache.geode.distributed.internal.locks.LockGrantorId;
  */
 public interface DLockBatchId extends DataSerializable {
   /** Gets the lock grantor id that granted this lock */
-  public LockGrantorId getLockGrantorId();
+  LockGrantorId getLockGrantorId();
 }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockLessorDepartureHandler.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockLessorDepartureHandler.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockLessorDepartureHandler.java
index 36c122b..03c8b85 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockLessorDepartureHandler.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockLessorDepartureHandler.java
@@ -26,7 +26,7 @@ import org.apache.geode.distributed.internal.membership.*;
  */
 public interface DLockLessorDepartureHandler {
 
-  public void handleDepartureOf(InternalDistributedMember owner, DLockGrantor grantor);
+  void handleDepartureOf(InternalDistributedMember owner, DLockGrantor grantor);
 
 }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRecoverGrantorProcessor.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRecoverGrantorProcessor.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRecoverGrantorProcessor.java
index 0ed4890..baad632 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRecoverGrantorProcessor.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRecoverGrantorProcessor.java
@@ -382,8 +382,8 @@ public class DLockRecoverGrantorProcessor extends ReplyProcessor21 {
     }
   }
 
-  public static interface MessageProcessor {
-    public void process(DM dm, DLockRecoverGrantorMessage msg);
+  public interface MessageProcessor {
+    void process(DM dm, DLockRecoverGrantorMessage msg);
   }
 
   static class DefaultMessageProcessor implements MessageProcessor {

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedLockStats.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedLockStats.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedLockStats.java
index 629efce..c4015b4 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedLockStats.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedLockStats.java
@@ -29,242 +29,242 @@ public interface DistributedLockStats {
   /**
    * Returns the number of threads currently waiting for a distributed lock
    */
-  public int getLockWaitsInProgress();
+  int getLockWaitsInProgress();
 
   /**
    * Returns the total number of waits for a distributed lock
    */
-  public int getLockWaitsCompleted();
+  int getLockWaitsCompleted();
 
-  public int getLockWaitsFailed();
+  int getLockWaitsFailed();
 
   /**
    * Returns the total number of nanoseconds spent waiting for a distributed lock.
    */
-  public long getLockWaitTime();
+  long getLockWaitTime();
 
-  public long getLockWaitFailedTime();
+  long getLockWaitFailedTime();
 
   /**
    * @return the timestamp that marks the start of the operation
    */
-  public long startLockWait();
+  long startLockWait();
 
   /**
    * @param start the timestamp taken when the operation started
    */
-  public void endLockWait(long start, boolean success);
+  void endLockWait(long start, boolean success);
 
   // incSerialQueueSize everytime getWaitingQueueHelper add/remove called
-  public int getWaitingQueueSize();
+  int getWaitingQueueSize();
 
-  public void incWaitingQueueSize(int messages);
+  void incWaitingQueueSize(int messages);
 
   // incSerialQueueSize everytime getSerialQueueHelper add/remove called
-  public int getSerialQueueSize();
+  int getSerialQueueSize();
 
-  public void incSerialQueueSize(int messages);
+  void incSerialQueueSize(int messages);
 
   // incNumSerialThreads everytime we execute with dlock getSerialExecutor()
-  public int getNumSerialThreads();
+  int getNumSerialThreads();
 
-  public void incNumSerialThreads(int threads);
+  void incNumSerialThreads(int threads);
 
   // incWaitingThreads for every invoke of getWaitingPoolHelper startJob/endJob
-  public int getWaitingThreads();
+  int getWaitingThreads();
 
-  public void incWaitingThreads(int threads);
+  void incWaitingThreads(int threads);
 
   // current number of lock services used by this system member
-  public int getServices();
+  int getServices();
 
-  public void incServices(int val);
+  void incServices(int val);
 
   // current number of lock grantors hosted by this system member
-  public int getGrantors();
+  int getGrantors();
 
-  public void incGrantors(int val);
+  void incGrantors(int val);
 
   // time spent granting of lock requests to completion
-  public int getGrantWaitsInProgress();
+  int getGrantWaitsInProgress();
 
-  public int getGrantWaitsCompleted();
+  int getGrantWaitsCompleted();
 
-  public int getGrantWaitsFailed();
+  int getGrantWaitsFailed();
 
-  public long getGrantWaitTime();
+  long getGrantWaitTime();
 
-  public long getGrantWaitFailedTime();
+  long getGrantWaitFailedTime();
 
-  public long startGrantWait();
+  long startGrantWait();
 
-  public void endGrantWait(long start);
+  void endGrantWait(long start);
 
-  public void endGrantWaitNotGrantor(long start);
+  void endGrantWaitNotGrantor(long start);
 
-  public void endGrantWaitTimeout(long start);
+  void endGrantWaitTimeout(long start);
 
-  public void endGrantWaitNotHolder(long start);
+  void endGrantWaitNotHolder(long start);
 
-  public void endGrantWaitFailed(long start);
+  void endGrantWaitFailed(long start);
 
-  public void endGrantWaitDestroyed(long start);
+  void endGrantWaitDestroyed(long start);
 
-  public void endGrantWaitSuspended(long start);
+  void endGrantWaitSuspended(long start);
 
   // time spent creating initial grantor for lock service
-  public int getCreateGrantorsInProgress();
+  int getCreateGrantorsInProgress();
 
-  public int getCreateGrantorsCompleted();
+  int getCreateGrantorsCompleted();
 
-  public long getCreateGrantorTime();
+  long getCreateGrantorTime();
 
-  public long startCreateGrantor();
+  long startCreateGrantor();
 
-  public void endCreateGrantor(long start);
+  void endCreateGrantor(long start);
 
   // time spent creating each lock service
-  public int getServiceCreatesInProgress();
+  int getServiceCreatesInProgress();
 
-  public int getServiceCreatesCompleted();
+  int getServiceCreatesCompleted();
 
-  public long startServiceCreate();
+  long startServiceCreate();
 
-  public void serviceCreateLatchReleased(long start);
+  void serviceCreateLatchReleased(long start);
 
-  public void serviceInitLatchReleased(long start);
+  void serviceInitLatchReleased(long start);
 
-  public long getServiceCreateLatchTime();
+  long getServiceCreateLatchTime();
 
-  public long getServiceInitLatchTime();
+  long getServiceInitLatchTime();
 
   // time spent waiting for grantor latches to open
-  public int getGrantorWaitsInProgress();
+  int getGrantorWaitsInProgress();
 
-  public int getGrantorWaitsCompleted();
+  int getGrantorWaitsCompleted();
 
-  public int getGrantorWaitsFailed();
+  int getGrantorWaitsFailed();
 
-  public long getGrantorWaitTime();
+  long getGrantorWaitTime();
 
-  public long getGrantorWaitFailedTime();
+  long getGrantorWaitFailedTime();
 
-  public long startGrantorWait();
+  long startGrantorWait();
 
-  public void endGrantorWait(long start, boolean success);
+  void endGrantorWait(long start, boolean success);
 
   // helpers for executor usage
-  public QueueStatHelper getSerialQueueHelper();
+  QueueStatHelper getSerialQueueHelper();
 
-  public PoolStatHelper getWaitingPoolHelper();
+  PoolStatHelper getWaitingPoolHelper();
 
-  public QueueStatHelper getWaitingQueueHelper();
+  QueueStatHelper getWaitingQueueHelper();
 
   // time spent by grantor threads
-  public int getGrantorThreadsInProgress();
+  int getGrantorThreadsInProgress();
 
-  public int getGrantorThreadsCompleted();
+  int getGrantorThreadsCompleted();
 
-  public long getGrantorThreadTime();
+  long getGrantorThreadTime();
 
-  public long getGrantorThreadExpireAndGrantLocksTime();
+  long getGrantorThreadExpireAndGrantLocksTime();
 
-  public long getGrantorThreadHandleRequestTimeoutsTime();
+  long getGrantorThreadHandleRequestTimeoutsTime();
 
-  public long getGrantorThreadRemoveUnusedTokensTime();
+  long getGrantorThreadRemoveUnusedTokensTime();
 
-  public long startGrantorThread();
+  long startGrantorThread();
 
-  public long endGrantorThreadExpireAndGrantLocks(long start);
+  long endGrantorThreadExpireAndGrantLocks(long start);
 
-  public long endGrantorThreadHandleRequestTimeouts(long timing);
+  long endGrantorThreadHandleRequestTimeouts(long timing);
 
-  public void endGrantorThreadRemoveUnusedTokens(long timing);
+  void endGrantorThreadRemoveUnusedTokens(long timing);
 
-  public void endGrantorThread(long start);
+  void endGrantorThread(long start);
 
   // current number of lock grantors hosted by this system member
-  public int getPendingRequests();
+  int getPendingRequests();
 
-  public void incPendingRequests(int val);
+  void incPendingRequests(int val);
 
   // acquisition of destroyReadLock in DLockService
-  public int getDestroyReadWaitsInProgress();
+  int getDestroyReadWaitsInProgress();
 
-  public int getDestroyReadWaitsCompleted();
+  int getDestroyReadWaitsCompleted();
 
-  public int getDestroyReadWaitsFailed();
+  int getDestroyReadWaitsFailed();
 
-  public long getDestroyReadWaitTime();
+  long getDestroyReadWaitTime();
 
-  public long getDestroyReadWaitFailedTime();
+  long getDestroyReadWaitFailedTime();
 
-  public long startDestroyReadWait();
+  long startDestroyReadWait();
 
-  public void endDestroyReadWait(long start, boolean success);
+  void endDestroyReadWait(long start, boolean success);
 
   // acquisition of destroyWriteLock in DLockService
-  public int getDestroyWriteWaitsInProgress();
+  int getDestroyWriteWaitsInProgress();
 
-  public int getDestroyWriteWaitsCompleted();
+  int getDestroyWriteWaitsCompleted();
 
-  public int getDestroyWriteWaitsFailed();
+  int getDestroyWriteWaitsFailed();
 
-  public long getDestroyWriteWaitTime();
+  long getDestroyWriteWaitTime();
 
-  public long getDestroyWriteWaitFailedTime();
+  long getDestroyWriteWaitFailedTime();
 
-  public long startDestroyWriteWait();
+  long startDestroyWriteWait();
 
-  public void endDestroyWriteWait(long start, boolean success);
+  void endDestroyWriteWait(long start, boolean success);
 
   // current number of DLockService destroy read locks held by this process
-  public int getDestroyReads();
+  int getDestroyReads();
 
-  public void incDestroyReads(int val);
+  void incDestroyReads(int val);
 
   // current number of DLockService destroy write locks held by this process
-  public int getDestroyWrites();
+  int getDestroyWrites();
 
-  public void incDestroyWrites(int val);
+  void incDestroyWrites(int val);
 
   // time for call to unlock() to complete
-  public int getLockReleasesInProgress();
+  int getLockReleasesInProgress();
 
-  public int getLockReleasesCompleted();
+  int getLockReleasesCompleted();
 
-  public long getLockReleaseTime();
+  long getLockReleaseTime();
 
-  public long startLockRelease();
+  long startLockRelease();
 
-  public void endLockRelease(long start);
+  void endLockRelease(long start);
 
   // total number of times this member has requested to become grantor
-  public int getBecomeGrantorRequests();
+  int getBecomeGrantorRequests();
 
-  public void incBecomeGrantorRequests();
+  void incBecomeGrantorRequests();
 
   // current number of lock tokens used by this system member
-  public int getTokens();
+  int getTokens();
 
-  public void incTokens(int val);
+  void incTokens(int val);
 
   // current number of grant tokens used by local grantors
-  public int getGrantTokens();
+  int getGrantTokens();
 
-  public void incGrantTokens(int val);
+  void incGrantTokens(int val);
 
   // current number of lock request queues used by this system member
-  public int getRequestQueues();
+  int getRequestQueues();
 
-  public void incRequestQueues(int val);
+  void incRequestQueues(int val);
 
-  public int getFreeResourcesCompleted();
+  int getFreeResourcesCompleted();
 
-  public void incFreeResourcesCompleted();
+  void incFreeResourcesCompleted();
 
-  public int getFreeResourcesFailed();
+  int getFreeResourcesFailed();
 
-  public void incFreeResourcesFailed();
+  void incFreeResourcesFailed();
 }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedMemberLock.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedMemberLock.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedMemberLock.java
index 9b379c7..52a83e4 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedMemberLock.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DistributedMemberLock.java
@@ -268,7 +268,7 @@ public class DistributedMemberLock implements Lock {
   }
 
   private interface Operation {
-    public boolean operate() throws InterruptedException;
+    boolean operate() throws InterruptedException;
   }
 
   public Condition newCondition() {

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/DistributedMembershipListener.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/DistributedMembershipListener.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/DistributedMembershipListener.java
index b2e2d60..7b91413 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/DistributedMembershipListener.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/DistributedMembershipListener.java
@@ -24,13 +24,13 @@ import org.apache.geode.distributed.internal.direct.DirectChannelListener;
 public interface DistributedMembershipListener extends DirectChannelListener {
 
   /** this method is invoked when the processing of a new view is completed */
-  public void viewInstalled(NetView view);
+  void viewInstalled(NetView view);
 
   /**
    * this is invoked when there has been a loss of quorum and enable-network-partition-detection is
    * not enabled
    */
-  public void quorumLost(Set<InternalDistributedMember> failures,
+  void quorumLost(Set<InternalDistributedMember> failures,
       List<InternalDistributedMember> remainingMembers);
 
   /**
@@ -38,7 +38,7 @@ public interface DistributedMembershipListener extends DirectChannelListener {
    * 
    * @param m the new member
    */
-  public void newMemberConnected(InternalDistributedMember m);
+  void newMemberConnected(InternalDistributedMember m);
 
   /**
    * Event indicating that a member has left the system
@@ -47,7 +47,7 @@ public interface DistributedMembershipListener extends DirectChannelListener {
    * @param crashed true if the departure was unexpected
    * @param reason a characterization of the departure
    */
-  public void memberDeparted(InternalDistributedMember id, boolean crashed, String reason);
+  void memberDeparted(InternalDistributedMember id, boolean crashed, String reason);
 
   /**
    * Event indicating that a member is suspected of having departed but is still in the membership
@@ -55,15 +55,15 @@ public interface DistributedMembershipListener extends DirectChannelListener {
    * 
    * @param reason TODO
    */
-  public void memberSuspect(InternalDistributedMember suspect,
-      InternalDistributedMember whoSuspected, String reason);
+  void memberSuspect(InternalDistributedMember suspect, InternalDistributedMember whoSuspected,
+      String reason);
 
   /**
    * Event indicating a message has been delivered that we need to process.
    * 
    * @param o the message that should be processed.
    */
-  public void messageReceived(DistributionMessage o);
+  void messageReceived(DistributionMessage o);
 
   /**
    * Indicates whether, during the shutdown sequence, if other members of the distributed system
@@ -74,19 +74,19 @@ public interface DistributedMembershipListener extends DirectChannelListener {
    * 
    * @return true if other members of the distributed system have been notified.
    */
-  public boolean isShutdownMsgSent();
+  boolean isShutdownMsgSent();
 
   /**
    * Event indicating that the membership service has failed catastrophically.
    *
    */
-  public void membershipFailure(String reason, Throwable t);
+  void membershipFailure(String reason, Throwable t);
 
   /**
    * Support good logging on this listener
    * 
    * @return a printable string for this listener
    */
-  public String toString();
+  String toString();
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
index c52ccbc..626869d 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
@@ -43,7 +43,7 @@ public interface MemberServices {
    * @param version TODO
    * @return the new NetMember
    */
-  public abstract NetMember newNetMember(InetAddress i, int port, boolean splitBrainEnabled,
+  NetMember newNetMember(InetAddress i, int port, boolean splitBrainEnabled,
       boolean canBeCoordinator, MemberAttributes payload, short version);
 
   /**
@@ -54,7 +54,7 @@ public interface MemberServices {
    * 
    * @return the new NetMember
    */
-  public abstract NetMember newNetMember(InetAddress i, int port);
+  NetMember newNetMember(InetAddress i, int port);
 
   /**
    * Return a new NetMember representing current host
@@ -63,7 +63,7 @@ public interface MemberServices {
    * @param p the membership port being used
    * @return the new member
    */
-  public abstract NetMember newNetMember(String s, int p);
+  NetMember newNetMember(String s, int p);
 
   /**
    * Create a new MembershipManager
@@ -75,7 +75,7 @@ public interface MemberServices {
    * 
    * @return a MembershipManager
    */
-  public abstract MembershipManager newMembershipManager(DistributedMembershipListener listener,
+  MembershipManager newMembershipManager(DistributedMembershipListener listener,
       DistributionConfig config, RemoteTransportConfig transport, DMStats stats,
       SecurityService securityService);
 
@@ -84,7 +84,7 @@ public interface MemberServices {
    * currently this is a test method but it ought to be used by InternalLocator to create the peer
    * location TcpHandler
    */
-  public abstract NetLocator newLocatorHandler(InetAddress bindAddress, File stateFile,
-      String locatorString, boolean usePreferredCoordinators,
-      boolean networkPartitionDetectionEnabled, LocatorStats stats, String securityUDPDHAlgo);
+  NetLocator newLocatorHandler(InetAddress bindAddress, File stateFile, String locatorString,
+      boolean usePreferredCoordinators, boolean networkPartitionDetectionEnabled,
+      LocatorStats stats, String securityUDPDHAlgo);
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
index 2e9f87c..079c045 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
@@ -41,14 +41,14 @@ public interface MembershipManager {
    * this must be sent to the manager after instantiation to allow it to perform post-connection
    * chores
    */
-  public void postConnect();
+  void postConnect();
 
   /**
    * Fetch the current view of memberships in th distributed system, as an ordered list.
    * 
    * @return list of members
    */
-  public NetView getView();
+  NetView getView();
 
   /**
    * Returns an object that is used to sync access to the view. While this lock is held the view
@@ -56,14 +56,14 @@ public interface MembershipManager {
    * 
    * @since GemFire 5.7
    */
-  public ReadWriteLock getViewLock();
+  ReadWriteLock getViewLock();
 
   /**
    * Return a {@link InternalDistributedMember} representing the current system
    * 
    * @return an address corresponding to the current system
    */
-  public InternalDistributedMember getLocalMember();
+  InternalDistributedMember getLocalMember();
 
   /**
    * Sanity checking, esp. for elder processing. Does the existing member (still) exist in our view?
@@ -71,7 +71,7 @@ public interface MembershipManager {
    * @param m the member
    * @return true if it still exists
    */
-  public boolean memberExists(DistributedMember m);
+  boolean memberExists(DistributedMember m);
 
   /**
    * Is this manager still connected? If it has not been initialized, this method will return true;
@@ -79,28 +79,28 @@ public interface MembershipManager {
    * 
    * @return true if the manager is still connected.
    */
-  public boolean isConnected();
+  boolean isConnected();
 
 
   /**
    * A test hook for healthiness tests
    */
-  public boolean isBeingSick();
+  boolean isBeingSick();
 
   /**
    * Instruct this manager to release resources
    */
-  public void shutdown();
+  void shutdown();
 
   /**
    * Forcibly shut down the manager and inform its listeners of the failure
    */
-  public void uncleanShutdown(String reason, Exception e);
+  void uncleanShutdown(String reason, Exception e);
 
   /**
    * A shutdown message has been received from another member
    */
-  public void shutdownMessageReceived(InternalDistributedMember id, String reason);
+  void shutdownMessageReceived(InternalDistributedMember id, String reason);
 
   /**
    * Stall the current thread until we are ready to accept view events
@@ -108,14 +108,14 @@ public interface MembershipManager {
    * @throws InterruptedException if the thread is interrupted while waiting
    * @see #startEventProcessing()
    */
-  public void waitForEventProcessing() throws InterruptedException;
+  void waitForEventProcessing() throws InterruptedException;
 
   /**
    * Commence delivering events to my listener.
    * 
    * @see #waitForEventProcessing()
    */
-  public void startEventProcessing();
+  void startEventProcessing();
 
 
   /**
@@ -129,8 +129,8 @@ public interface MembershipManager {
    *         not receive the message because they departed the distributed system.
    * @throws NotSerializableException If content cannot be serialized
    */
-  public Set send(InternalDistributedMember[] destinations, DistributionMessage content,
-      DMStats stats) throws NotSerializableException;
+  Set send(InternalDistributedMember[] destinations, DistributionMessage content, DMStats stats)
+      throws NotSerializableException;
 
   /**
    * Indicates to the membership manager that the system is shutting down. Typically speaking, this
@@ -138,7 +138,7 @@ public interface MembershipManager {
    * tolerated.
    *
    */
-  public void setShutdown();
+  void setShutdown();
 
 
   /**
@@ -146,7 +146,7 @@ public interface MembershipManager {
    * 
    * @return true if it is shutting down
    */
-  public boolean shutdownInProgress();
+  boolean shutdownInProgress();
 
   /**
    * Returns a serializable map of communications state for use in state stabilization.
@@ -157,7 +157,7 @@ public interface MembershipManager {
    *         distributed member
    * @since GemFire 5.1
    */
-  public Map getMessageState(DistributedMember member, boolean includeMulticast);
+  Map getMessageState(DistributedMember member, boolean includeMulticast);
 
   /**
    * Waits for the given communications to reach the associated state
@@ -167,7 +167,7 @@ public interface MembershipManager {
    * @throws InterruptedException Thrown if the thread is interrupted
    * @since GemFire 5.1
    */
-  public void waitForMessageState(DistributedMember member, Map state) throws InterruptedException;
+  void waitForMessageState(DistributedMember member, Map state) throws InterruptedException;
 
   /**
    * Wait for the given member to not be in the membership view and for all direct-channel receivers
@@ -178,8 +178,7 @@ public interface MembershipManager {
    * @throws InterruptedException if interrupted by another thread
    * @throws TimeoutException if we wait too long for the member to go away
    */
-  public boolean waitForDeparture(DistributedMember mbr)
-      throws TimeoutException, InterruptedException;
+  boolean waitForDeparture(DistributedMember mbr) throws TimeoutException, InterruptedException;
 
   /**
    * Returns true if remoteId is an existing member, otherwise waits till timeout. Returns false if
@@ -188,19 +187,19 @@ public interface MembershipManager {
    * @param remoteId
    * @return true if membership is confirmed, else timeout and false
    */
-  public boolean waitForNewMember(InternalDistributedMember remoteId);
+  boolean waitForNewMember(InternalDistributedMember remoteId);
 
   /**
    * Release critical resources, avoiding any possibility of deadlock
    * 
    * @see SystemFailure#emergencyClose()
    */
-  public void emergencyClose();
+  void emergencyClose();
 
   /**
    * Request the current membership coordinator to remove the given member
    */
-  public boolean requestMemberRemoval(DistributedMember member, String reason);
+  boolean requestMemberRemoval(DistributedMember member, String reason);
 
   /**
    * like memberExists() this checks to see if the given ID is in the current membership view. If it
@@ -212,20 +211,20 @@ public interface MembershipManager {
    * @param reason why the check is being done (must not be blank/null)
    * @return true if the member checks out
    */
-  public boolean verifyMember(DistributedMember mbr, String reason);
+  boolean verifyMember(DistributedMember mbr, String reason);
 
 
   /**
    * Initiate SUSPECT processing for the given members. This may be done if the members have not
    * been responsive. If they fail SUSPECT processing, they will be removed from membership.
    */
-  public void suspectMembers(Set members, String reason);
+  void suspectMembers(Set members, String reason);
 
   /**
    * Initiate SUSPECT processing for the given member. This may be done if the member has not been
    * responsive. If it fails SUSPECT processing, it will be removed from membership.
    */
-  public void suspectMember(DistributedMember member, String reason);
+  void suspectMember(DistributedMember member, String reason);
 
   /**
    * if the manager initiated shutdown, this will return the cause of abnormal termination of
@@ -233,28 +232,28 @@ public interface MembershipManager {
    * 
    * @return the exception causing shutdown
    */
-  public Throwable getShutdownCause();
+  Throwable getShutdownCause();
 
   /**
    * register a test hook for membership events
    * 
    * @see MembershipTestHook
    */
-  public void registerTestHook(MembershipTestHook mth);
+  void registerTestHook(MembershipTestHook mth);
 
   /**
    * remove a test hook previously registered with the manager
    */
-  public void unregisterTestHook(MembershipTestHook mth);
+  void unregisterTestHook(MembershipTestHook mth);
 
   /**
    * If this member is shunned, ensure that a warning is generated at least once.
    * 
    * @param mbr the member that may be shunned
    */
-  public void warnShun(DistributedMember mbr);
+  void warnShun(DistributedMember mbr);
 
-  public boolean addSurpriseMember(DistributedMember mbr);
+  boolean addSurpriseMember(DistributedMember mbr);
 
   /**
    * if a StartupMessage is going to reject a new member, this should be used to make sure we don't
@@ -263,12 +262,12 @@ public interface MembershipManager {
    * @param mbr the failed member
    * @param failureMessage the reason for the failure (e.g., license limitation)
    */
-  public void startupMessageFailed(DistributedMember mbr, String failureMessage);
+  void startupMessageFailed(DistributedMember mbr, String failureMessage);
 
   /**
    * @return true if multicast is disabled, or if multicast is enabled and seems to be working
    */
-  public boolean testMulticast();
+  boolean testMulticast();
 
   /**
    * Returns true if the member is a surprise member.
@@ -276,25 +275,25 @@ public interface MembershipManager {
    * @param m the member in question
    * @return true if the member is a surprise member
    */
-  public boolean isSurpriseMember(DistributedMember m);
+  boolean isSurpriseMember(DistributedMember m);
 
   /**
    * Returns true if the member is being shunned
    */
-  public boolean isShunned(DistributedMember m);
+  boolean isShunned(DistributedMember m);
 
   /**
    * Forces use of UDP for communications in the current thread. UDP is connectionless, so no tcp/ip
    * connections will be created or used for messaging until this setting is released with
    * releaseUDPMessagingForCurrentThread.
    */
-  public void forceUDPMessagingForCurrentThread();
+  void forceUDPMessagingForCurrentThread();
 
   /**
    * Releases use of UDP for all communications in the current thread, as established by
    * forceUDPMessagingForCurrentThread.
    */
-  public void releaseUDPMessagingForCurrentThread();
+  void releaseUDPMessagingForCurrentThread();
 
 
   /**
@@ -303,7 +302,7 @@ public interface MembershipManager {
    * 
    * @return the quorum checker to be used in reconnecting the system
    */
-  public QuorumChecker getQuorumChecker();
+  QuorumChecker getQuorumChecker();
 
 
   /**
@@ -312,6 +311,6 @@ public interface MembershipManager {
    * 
    * @param checker the QuorumChecker instance
    */
-  public void releaseQuorumChecker(QuorumChecker checker);
+  void releaseQuorumChecker(QuorumChecker checker);
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipTestHook.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipTestHook.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipTestHook.java
index 9ef6343..b78ca5e 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipTestHook.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipTestHook.java
@@ -26,11 +26,11 @@ public interface MembershipTestHook {
   /**
    * test hook invoked prior to shutting down distributed system
    */
-  public void beforeMembershipFailure(String reason, Throwable cause);
+  void beforeMembershipFailure(String reason, Throwable cause);
 
   /**
    * test hook invoked after shutting down distributed system
    */
-  public void afterMembershipFailure(String reason, Throwable cause);
+  void afterMembershipFailure(String reason, Throwable cause);
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetMember.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetMember.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetMember.java
index 1f909f2..d82bbb7 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetMember.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetMember.java
@@ -30,35 +30,35 @@ import org.apache.geode.internal.shared.StringPrintWriter;
  */
 public interface NetMember extends Comparable<NetMember> {
 
-  public void setAttributes(MemberAttributes args);
+  void setAttributes(MemberAttributes args);
 
-  public MemberAttributes getAttributes();
+  MemberAttributes getAttributes();
 
-  public InetAddress getInetAddress();
+  InetAddress getInetAddress();
 
-  public int getPort();
+  int getPort();
 
-  public void setPort(int p);
+  void setPort(int p);
 
-  public boolean isMulticastAddress();
+  boolean isMulticastAddress();
 
-  public short getVersionOrdinal();
+  short getVersionOrdinal();
 
   /**
    * return a flag stating whether the member has network partition detection enabled
    * 
    * @since GemFire 5.6
    */
-  public boolean isNetworkPartitionDetectionEnabled();
+  boolean isNetworkPartitionDetectionEnabled();
 
-  public void setNetworkPartitionDetectionEnabled(boolean enabled);
+  void setNetworkPartitionDetectionEnabled(boolean enabled);
 
   /**
    * return a flag stating whether the member can be the membership coordinator
    * 
    * @since GemFire 5.6
    */
-  public boolean preferredForCoordinator();
+  boolean preferredForCoordinator();
 
   /**
    * Set whether this member ID is preferred for coordinator. This is mostly useful for unit tests
@@ -66,50 +66,50 @@ public interface NetMember extends Comparable<NetMember> {
    * 
    * @param preferred
    */
-  public void setPreferredForCoordinator(boolean preferred);
+  void setPreferredForCoordinator(boolean preferred);
 
-  public byte getMemberWeight();
+  byte getMemberWeight();
 
-  public void setVersion(Version v);
+  void setVersion(Version v);
 
-  public int getProcessId();
+  int getProcessId();
 
-  public void setProcessId(int id);
+  void setProcessId(int id);
 
-  public byte getVmKind();
+  byte getVmKind();
 
-  public void setVmKind(int kind);
+  void setVmKind(int kind);
 
-  public int getVmViewId();
+  int getVmViewId();
 
-  public void setVmViewId(int id);
+  void setVmViewId(int id);
 
-  public int getDirectPort();
+  int getDirectPort();
 
-  public void setDirectPort(int port);
+  void setDirectPort(int port);
 
-  public String getName();
+  String getName();
 
-  public void setName(String name);
+  void setName(String name);
 
-  public DurableClientAttributes getDurableClientAttributes();
+  DurableClientAttributes getDurableClientAttributes();
 
-  public void setDurableClientAttributes(DurableClientAttributes attributes);
+  void setDurableClientAttributes(DurableClientAttributes attributes);
 
-  public String[] getGroups();
+  String[] getGroups();
 
-  public void setGroups(String[] groups);
+  void setGroups(String[] groups);
 
   /** whether this NetMember has additional data to be serialized as part of a DistributedMember */
-  public boolean hasAdditionalData();
+  boolean hasAdditionalData();
 
   /** write identity information not known by DistributedMember instances */
-  public void writeAdditionalData(DataOutput out) throws IOException;
+  void writeAdditionalData(DataOutput out) throws IOException;
 
   /** read identity information not known by DistributedMember instances */
-  public void readAdditionalData(DataInput in) throws ClassNotFoundException, IOException;
+  void readAdditionalData(DataInput in) throws ClassNotFoundException, IOException;
 
   /** compare data that is not known to DistributedMember instances */
-  public int compareAdditionalData(NetMember other);
+  int compareAdditionalData(NetMember other);
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/QuorumChecker.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/QuorumChecker.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/QuorumChecker.java
index 838039c..6527ccc 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/QuorumChecker.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/QuorumChecker.java
@@ -28,32 +28,32 @@ public interface QuorumChecker {
    * 
    * @param timeoutMS time to wait for responses, in milliseconds
    */
-  public boolean checkForQuorum(long timeoutMS) throws InterruptedException;
+  boolean checkForQuorum(long timeoutMS) throws InterruptedException;
 
   /**
    * suspends the quorum checker for an attempt to connect to the distributed system
    */
-  public void suspend();
+  void suspend();
 
   /**
    * resumes the quorum checker after having invoked suspend();
    */
-  public void resume();
+  void resume();
 
   /**
    * closes the quorum checker and releases resources. Use this if the distributed system is not
    * going to be reconnected and you want to release resources.
    */
-  public void close();
+  void close();
 
   /**
    * Get the membership info from the old system that needs to be passed to the one that is
    * reconnecting.
    */
-  public Object getMembershipInfo();
+  Object getMembershipInfo();
 
   /**
    * Returns the membership view that is being used to establish a quorum
    */
-  public NetView getView();
+  NetView getView();
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/NetLocator.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/NetLocator.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/NetLocator.java
index ede1516..e66ad58 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/NetLocator.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/NetLocator.java
@@ -26,6 +26,6 @@ public interface NetLocator extends TcpHandler {
    * @param mgr
    * @return true if the membership manager was accepted
    */
-  public boolean setMembershipManager(MembershipManager mgr);
+  boolean setMembershipManager(MembershipManager mgr);
 
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/interfaces/HealthMonitor.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/interfaces/HealthMonitor.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/interfaces/HealthMonitor.java
index 9aed555..4fad2f8 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/interfaces/HealthMonitor.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/interfaces/HealthMonitor.java
@@ -29,7 +29,7 @@ public interface HealthMonitor extends Service {
    * 
    * @param sender
    */
-  public void contactedBy(InternalDistributedMember sender);
+  void contactedBy(InternalDistributedMember sender);
 
   /**
    * initiate, asynchronously, suspicion that the member is no longer available
@@ -37,7 +37,7 @@ public interface HealthMonitor extends Service {
    * @param mbr
    * @param reason
    */
-  public void suspect(InternalDistributedMember mbr, String reason);
+  void suspect(InternalDistributedMember mbr, String reason);
 
   /**
    * Check on the health of the given member, initiating suspicion if it fails. Return true if the
@@ -47,17 +47,17 @@ public interface HealthMonitor extends Service {
    * @param reason the reason this check is being performed
    * @param initiateRemoval if the member should be removed if it is not available
    */
-  public boolean checkIfAvailable(DistributedMember mbr, String reason, boolean initiateRemoval);
+  boolean checkIfAvailable(DistributedMember mbr, String reason, boolean initiateRemoval);
 
   /**
    * Invoked by the Manager, this notifies the HealthMonitor that a ShutdownMessage has been
    * received from the given member
    */
-  public void memberShutdown(DistributedMember mbr, String reason);
+  void memberShutdown(DistributedMember mbr, String reason);
 
   /**
    * Returns the failure detection port for this member, or -1 if there is no such port
    */
-  public int getFailureDetectionPort();
+  int getFailureDetectionPort();
 
 }


Mime
View raw message