geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject [2/5] geode git commit: GEODE-269 : Fixing RollingUpgrade2DUnitTest. After removing deprecated API withArgs, setArgument alternative API is not available in older version of server causing NoSuchMethodFound exception. The role of setArgument with functio
Date Mon, 05 Jun 2017 18:22:30 GMT
GEODE-269 : Fixing RollingUpgrade2DUnitTest. After removing deprecated API withArgs, setArgument
alternative API is not available in older version of server causing NoSuchMethodFound exception.
The role of setArgument with function is passing class name to load inside the function. As
the relevant function is used on in the context of this test, instead of using setArgument
method made class name as a field in GetDataSerializableFunction.


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/ad9e3025
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/ad9e3025
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/ad9e3025

Branch: refs/heads/develop
Commit: ad9e30254d0d0d39ecda94b04ae8b8eedce95d36
Parents: 32be4c2
Author: Deepak Dixit <deepakdixit2011@gmail.com>
Authored: Thu May 11 15:14:58 2017 +0530
Committer: nabarun <nnag@pivotal.io>
Committed: Mon Jun 5 11:14:16 2017 -0700

----------------------------------------------------------------------
 .../internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/ad9e3025/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
index c628fe1..cb86c01 100755
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
@@ -1161,7 +1161,7 @@ public class RollingUpgrade2DUnitTest extends JUnit4DistributedTestCase
{
       DistributedMember... members) {
     Set<DistributedMember> membersSet = new HashSet<>();
     Collections.addAll(membersSet, members);
-    Execution execution = FunctionService.onMembers(membersSet).setArguments(dsClassName);
+    Execution execution = FunctionService.onMembers(membersSet);
     ResultCollector rc = execution.execute(functionId);
     List result = (List) rc.getResult();
     assertEquals(membersSet.size(), result.size());
@@ -1914,10 +1914,9 @@ public class RollingUpgrade2DUnitTest extends JUnit4DistributedTestCase
{
   }
 
   public static class GetDataSerializableFunction implements Function {
-
+    String dsClassName = "org.apache.geode.management.internal.configuration.domain.XmlEntity";
     @Override
     public void execute(FunctionContext context) {
-      String dsClassName = (String) context.getArguments();
       try {
         Class aClass = Thread.currentThread().getContextClassLoader().loadClass(dsClassName);
         Constructor constructor = aClass.getConstructor(new Class[0]);


Mime
View raw message