geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject geode git commit: GEODE-2879: Shutdown() called from close() in LonerDistributionManager
Date Mon, 08 May 2017 23:54:26 GMT
Repository: geode
Updated Branches:
  refs/heads/develop 24076f15d -> 6f9fb4cda


GEODE-2879: Shutdown() called from close() in LonerDistributionManager

	* LonerDistributionManager shutdown was not being called from close() method call.
	* This resulted in the thread pool's threads to wait for 1 minute of inactivity for them
to be killed.
	* This resulted in an extra delay while test executions.
	* shutdown called from close method

	This closes #499


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/6f9fb4cd
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/6f9fb4cd
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/6f9fb4cd

Branch: refs/heads/develop
Commit: 6f9fb4cdabd9c59536acf6c5654da840de7394a0
Parents: 24076f1
Author: nabarun <nnag@pivotal.io>
Authored: Fri May 5 16:28:17 2017 -0700
Committer: nabarun <nnag@pivotal.io>
Committed: Mon May 8 16:53:58 2017 -0700

----------------------------------------------------------------------
 .../geode/distributed/internal/LonerDistributionManager.java   | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/6f9fb4cd/geode-core/src/main/java/org/apache/geode/distributed/internal/LonerDistributionManager.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/LonerDistributionManager.java
b/geode-core/src/main/java/org/apache/geode/distributed/internal/LonerDistributionManager.java
index fdb6a13..3df0196 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/LonerDistributionManager.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/LonerDistributionManager.java
@@ -101,7 +101,7 @@ public class LonerDistributionManager implements DM {
   private ConcurrentMap<InternalDistributedMember, InternalDistributedMember> canonicalIds
=
       new ConcurrentHashMap();
   static private final DummyDMStats stats = new DummyDMStats();
-  static private final ExecutorService executor = Executors.newCachedThreadPool();
+  private final ExecutorService executor = Executors.newCachedThreadPool();
 
   @Override
   public long cacheTimeMillis() {
@@ -284,7 +284,9 @@ public class LonerDistributionManager implements DM {
     return null;
   }
 
-  public void close() {}
+  public void close() {
+    shutdown();
+  }
 
   public void restartCommunications() {
 


Mime
View raw message