geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject geode git commit: Review fixups
Date Wed, 03 May 2017 22:30:24 GMT
Repository: geode
Updated Branches:
  refs/heads/feature/GEODE-2632-10 88d3dd11f -> ea4083848


Review fixups


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/ea408384
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/ea408384
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/ea408384

Branch: refs/heads/feature/GEODE-2632-10
Commit: ea40838480de6ad55350ff7b073445ae4ce17b4e
Parents: 88d3dd1
Author: Kirk Lund <klund@apache.org>
Authored: Wed May 3 15:30:12 2017 -0700
Committer: Kirk Lund <klund@apache.org>
Committed: Wed May 3 15:30:12 2017 -0700

----------------------------------------------------------------------
 .../org/apache/geode/internal/ra/spi/JCALocalTransaction.java    | 3 ++-
 .../org/apache/geode/admin/internal/CacheHealthEvaluator.java    | 4 +---
 2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/ea408384/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
----------------------------------------------------------------------
diff --git a/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
b/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
index 7ee1f4e..a4ae25e 100644
--- a/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
+++ b/geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
@@ -106,7 +106,8 @@ public class JCALocalTransaction implements LocalTransaction {
       this.gfTxMgr.commit();
       this.tid = null;
     } catch (Exception e) {
-      throw new LocalTransactionException(e.toString(), e);
+      // TODO: consider wrapping the cause
+      throw new LocalTransactionException(e.toString());
     }
   }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/ea408384/geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
b/geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
index 434ea5a..c93d0f4 100644
--- a/geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
+++ b/geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
@@ -14,8 +14,6 @@
  */
 package org.apache.geode.admin.internal;
 
-import static java.lang.Long.*;
-
 import java.util.List;
 
 import org.apache.logging.log4j.Logger;
@@ -254,7 +252,7 @@ class CacheHealthEvaluator extends AbstractHealthEvaluator implements
CacheLifec
     if (eventQueueSize > threshold) {
       String s =
           LocalizedStrings.CacheHealthEvaluator_THE_SIZE_OF_THE_CACHE_EVENT_QUEUE_0_MS_EXCEEDS_THE_THRESHOLD_1_MS
-              .toLocalizedString(valueOf(eventQueueSize), valueOf(threshold));
+              .toLocalizedString(eventQueueSize, threshold);
       status.add(okayHealth(s));
     }
   }


Mime
View raw message