geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject [38/78] geode git commit: GEODE-2929: remove final from methods on internal classes
Date Tue, 16 May 2017 02:19:48 GMT
http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/management/internal/configuration/domain/XmlEntity.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/configuration/domain/XmlEntity.java
b/geode-core/src/main/java/org/apache/geode/management/internal/configuration/domain/XmlEntity.java
index c630aa9..be74e84 100644
--- a/geode-core/src/main/java/org/apache/geode/management/internal/configuration/domain/XmlEntity.java
+++ b/geode-core/src/main/java/org/apache/geode/management/internal/configuration/domain/XmlEntity.java
@@ -174,7 +174,7 @@ public class XmlEntity implements VersionedDataSerializable {
    * 
    * @since GemFire 8.1
    */
-  private final void init() {
+  private void init() {
     Assert.assertTrue(!StringUtils.isBlank(type));
     Assert.assertTrue(!StringUtils.isBlank(prefix));
     Assert.assertTrue(!StringUtils.isBlank(namespace));
@@ -190,7 +190,7 @@ public class XmlEntity implements VersionedDataSerializable {
    * 
    * @return XML string representation of the entity.
    */
-  private final String loadXmlDefinition() {
+  private String loadXmlDefinition() {
     final Cache cache = CacheFactory.getAnyInstance();
 
     final StringWriter stringWriter = new StringWriter();
@@ -208,7 +208,7 @@ public class XmlEntity implements VersionedDataSerializable {
    * @return XML for {@link XmlEntity} if found, otherwise <code>null</code>.
    * @since GemFire 8.1
    */
-  private final String loadXmlDefinition(final String xmlDocument) {
+  private String loadXmlDefinition(final String xmlDocument) {
     final Cache cache = CacheFactory.getAnyInstance();
     try {
       InputSource inputSource = new InputSource(new StringReader(xmlDocument));
@@ -229,7 +229,7 @@ public class XmlEntity implements VersionedDataSerializable {
    * @throws TransformerFactoryConfigurationError
    * @since GemFire 8.1
    */
-  private final String loadXmlDefinition(final Document document)
+  private String loadXmlDefinition(final Document document)
       throws XPathExpressionException, TransformerFactoryConfigurationError, TransformerException
{
     final Cache cache = CacheFactory.getAnyInstance();
 
@@ -446,7 +446,7 @@ public class XmlEntity implements VersionedDataSerializable {
    * @return new {@link XmlEntityBuilder}.
    * @since GemFire 8.1
    */
-  public static final XmlEntityBuilder builder() {
+  public static XmlEntityBuilder builder() {
     return new XmlEntityBuilder();
   }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/XmlUtils.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/XmlUtils.java
b/geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/XmlUtils.java
index a6fafaa..c10dc4b 100644
--- a/geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/XmlUtils.java
+++ b/geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/XmlUtils.java
@@ -281,7 +281,7 @@ public class XmlUtils {
    * @return {@link Map} of schema namespace URIs to location URLs.
    * @since GemFire 8.1
    */
-  public static final Map<String, List<String>> buildSchemaLocationMap(
+  public static Map<String, List<String>> buildSchemaLocationMap(
       final String schemaLocation) {
     return buildSchemaLocationMap(new HashMap<String, List<String>>(), schemaLocation);
   }
@@ -298,7 +298,7 @@ public class XmlUtils {
    * @return {@link Map} of schema namespace URIs to location URLs.
    * @since GemFire 8.1
    */
-  static final Map<String, List<String>> buildSchemaLocationMap(
+  static Map<String, List<String>> buildSchemaLocationMap(
       Map<String, List<String>> schemaLocationMap, final String schemaLocation)
{
     if (null == schemaLocation) {
       return schemaLocationMap;
@@ -419,14 +419,14 @@ public class XmlUtils {
     return transform(transformer, doc);
   }
 
-  public static final String elementToString(Node element)
+  public static String elementToString(Node element)
       throws TransformerFactoryConfigurationError, TransformerException {
     Transformer transformer = TransformerFactory.newInstance().newTransformer();
 
     return transform(transformer, element);
   }
 
-  private static final String transform(Transformer transformer, Node element)
+  private static String transform(Transformer transformer, Node element)
       throws TransformerException {
     StreamResult result = new StreamResult(new StringWriter());
     DOMSource source = new DOMSource(element);
@@ -585,7 +585,7 @@ public class XmlUtils {
    * @param schemaLocationMap {@link Map} to get schema locations from.
    * @since GemFire 8.1
    */
-  private static final String getSchemaLocationValue(
+  private static String getSchemaLocationValue(
       final Map<String, List<String>> schemaLocationMap) {
     final StringBuilder sb = new StringBuilder();
     for (final Map.Entry<String, List<String>> entry : schemaLocationMap.entrySet())
{
@@ -606,7 +606,7 @@ public class XmlUtils {
    * @return {@link Map} of namespace URIs to prefixes.
    * @since GemFire 8.1
    */
-  private static final Map<String, String> buildNamespacePrefixMap(final Element root)
{
+  private static Map<String, String> buildNamespacePrefixMap(final Element root) {
     final HashMap<String, String> namespacePrefixMap = new HashMap<>();
 
     // Look for all of the attributes of cache that start with
@@ -646,7 +646,7 @@ public class XmlUtils {
    * @return the modified version of the passed in node.
    * @since GemFire 8.1
    */
-  static final Node changeNamespace(final Node node, final String oldNamespaceUri,
+  static Node changeNamespace(final Node node, final String oldNamespaceUri,
       final String newNamespaceUri) throws XPathExpressionException {
     Node result = null;
     final NodeList nodes = query(node, "//*");

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/management/internal/web/io/MultipartFileResourceAdapter.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/web/io/MultipartFileResourceAdapter.java
b/geode-core/src/main/java/org/apache/geode/management/internal/web/io/MultipartFileResourceAdapter.java
index e782dc0..d4aa268 100644
--- a/geode-core/src/main/java/org/apache/geode/management/internal/web/io/MultipartFileResourceAdapter.java
+++ b/geode-core/src/main/java/org/apache/geode/management/internal/web/io/MultipartFileResourceAdapter.java
@@ -41,7 +41,7 @@ public class MultipartFileResourceAdapter extends AbstractResource {
     this.file = file;
   }
 
-  protected final MultipartFile getMultipartFile() {
+  protected MultipartFile getMultipartFile() {
     return file;
   }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java
b/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java
index 25f972e..b342c66 100644
--- a/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java
+++ b/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java
@@ -362,7 +362,7 @@ public abstract class AbstractHttpOperationInvoker implements HttpOperationInvok
    * @return an instance of the ScheduledExecutorService for scheduling periodic or delayed
tasks.
    * @see java.util.concurrent.ScheduledExecutorService
    */
-  protected final ScheduledExecutorService getExecutorService() {
+  protected ScheduledExecutorService getExecutorService() {
     assertState(this.executorService != null,
         "The ExecutorService for this HTTP OperationInvoker (%1$s) was not properly initialized!",
         getClass().getName());
@@ -377,7 +377,7 @@ public abstract class AbstractHttpOperationInvoker implements HttpOperationInvok
    *         OperationInvoker to process commands.
    * @see org.apache.geode.management.internal.cli.shell.Gfsh
    */
-  protected final Gfsh getGfsh() {
+  protected Gfsh getGfsh() {
     return this.gfsh;
   }
 
@@ -388,7 +388,7 @@ public abstract class AbstractHttpOperationInvoker implements HttpOperationInvok
    * @return an instance of the Spring RestTemplate used to make REST API web service calls.
    * @see org.springframework.web.client.RestTemplate
    */
-  protected final RestTemplate getRestTemplate() {
+  protected RestTemplate getRestTemplate() {
     return this.restTemplate;
   }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/support/HttpInvocationHandler.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/support/HttpInvocationHandler.java
b/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/support/HttpInvocationHandler.java
index b8e7506..a87948e 100644
--- a/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/support/HttpInvocationHandler.java
+++ b/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/support/HttpInvocationHandler.java
@@ -47,11 +47,11 @@ public class HttpInvocationHandler implements InvocationHandler {
     this.objectName = objectName;
   }
 
-  protected final ObjectName getObjectName() {
+  protected ObjectName getObjectName() {
     return objectName;
   }
 
-  protected final HttpOperationInvoker getOperationInvoker() {
+  protected HttpOperationInvoker getOperationInvoker() {
     return operationInvoker;
   }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java
b/geode-core/src/main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java
index 2f2d0e3..e5de960 100644
--- a/geode-core/src/main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java
+++ b/geode-core/src/main/java/org/apache/geode/pdx/ReflectionBasedAutoSerializer.java
@@ -247,7 +247,7 @@ public class ReflectionBasedAutoSerializer implements PdxSerializer, Declarable
    * @param patterns the list of definitions to apply
    * @deprecated as of 6.6.2 use {@link #reconfigure(String...)} instead.
    */
-  public final void setSerializableClasses(List<String> patterns) {
+  public void setSerializableClasses(List<String> patterns) {
     reconfigure(listToArray(patterns));
   }
 
@@ -288,7 +288,7 @@ public class ReflectionBasedAutoSerializer implements PdxSerializer, Declarable
    * @param patterns the definitions to apply
    * @since GemFire 6.6.2
    */
-  public final void reconfigure(String... patterns) {
+  public void reconfigure(String... patterns) {
     reconfigure(false, patterns);
   }
 
@@ -330,7 +330,7 @@ public class ReflectionBasedAutoSerializer implements PdxSerializer, Declarable
    *        throw an exception if the object it not portable to non-java languages.
    * @since GemFire 6.6.2
    */
-  public final void reconfigure(boolean checkPortability, String... patterns) {
+  public void reconfigure(boolean checkPortability, String... patterns) {
     this.manager.reconfigure(checkPortability, patterns);
   }
 
@@ -570,7 +570,7 @@ public class ReflectionBasedAutoSerializer implements PdxSerializer, Declarable
    * 
    * @since GemFire 6.6.2
    */
-  public final RegionService getRegionService() {
+  public RegionService getRegionService() {
     return this.manager.getRegionService();
   }
 
@@ -579,7 +579,7 @@ public class ReflectionBasedAutoSerializer implements PdxSerializer, Declarable
    * 
    * @since GemFire 8.2
    */
-  public final Object getManager() {
+  public Object getManager() {
     // The result is not AutoSerializableManager because
     // that class is not part of our public APIs.
     return this.manager;

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/pdx/internal/AutoSerializableManager.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/pdx/internal/AutoSerializableManager.java
b/geode-core/src/main/java/org/apache/geode/pdx/internal/AutoSerializableManager.java
index 5aaca91..354a9f7 100644
--- a/geode-core/src/main/java/org/apache/geode/pdx/internal/AutoSerializableManager.java
+++ b/geode-core/src/main/java/org/apache/geode/pdx/internal/AutoSerializableManager.java
@@ -744,14 +744,14 @@ public class AutoSerializableManager {
 
     public abstract void orderedDeserialize(InternalPdxReader reader, Object obj);
 
-    protected final Object readTransformIf(Object o, Object serializedValue)
+    protected Object readTransformIf(Object o, Object serializedValue)
         throws IllegalArgumentException, IllegalAccessException {
       if (!transform())
         return serializedValue;
       return readTransform(o, serializedValue);
     }
 
-    protected final Object readTransform(Object o, Object serializedValue)
+    protected Object readTransform(Object o, Object serializedValue)
         throws IllegalArgumentException, IllegalAccessException {
       return this.owner.getOwner().readTransform(getField(), o.getClass(), serializedValue);
     }

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java
b/geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java
index 1de73a0..94ff50c 100644
--- a/geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java
+++ b/geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java
@@ -475,7 +475,7 @@ public class RegionProvider implements Closeable {
    * @param delay The delay in milliseconds of the expiration
    * @return True is expiration set, false otherwise
    */
-  public final boolean setExpiration(ByteArrayWrapper key, long delay) {
+  public boolean setExpiration(ByteArrayWrapper key, long delay) {
     RedisDataType type = getRedisDataType(key);
     if (type == null)
       return false;
@@ -492,7 +492,7 @@ public class RegionProvider implements Closeable {
    * @param delay Delay in milliseconds to reset the expiration to
    * @return True if reset, false if not
    */
-  public final boolean modifyExpiration(ByteArrayWrapper key, long delay) {
+  public boolean modifyExpiration(ByteArrayWrapper key, long delay) {
     /*
      * Attempt to cancel future task
      */
@@ -517,7 +517,7 @@ public class RegionProvider implements Closeable {
    * @param key Key
    * @return True is expiration cancelled on the key, false otherwise
    */
-  public final boolean cancelKeyExpiration(ByteArrayWrapper key) {
+  public boolean cancelKeyExpiration(ByteArrayWrapper key) {
     ScheduledFuture<?> future = expirationsMap.remove(key);
     if (future == null)
       return false;
@@ -544,7 +544,7 @@ public class RegionProvider implements Closeable {
    * @param key Key
    * @return Remaining time in milliseconds or 0 if no delay or key doesn't exist
    */
-  public final long getExpirationDelayMillis(ByteArrayWrapper key) {
+  public long getExpirationDelayMillis(ByteArrayWrapper key) {
     ScheduledFuture<?> future = this.expirationsMap.get(key);
     return future != null ? future.getDelay(TimeUnit.MILLISECONDS) : 0L;
   }

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/HllExecutor.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/HllExecutor.java
b/geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/HllExecutor.java
index e440c09..c1b0488 100755
--- a/geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/HllExecutor.java
+++ b/geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/HllExecutor.java
@@ -26,7 +26,7 @@ public abstract class HllExecutor extends AbstractExecutor {
   public static final Integer DEFAULT_HLL_DENSE = 18;
   public static final Integer DEFAULT_HLL_SPARSE = 32;
 
-  protected final void checkAndSetDataType(ByteArrayWrapper key, ExecutionHandlerContext
context) {
+  protected void checkAndSetDataType(ByteArrayWrapper key, ExecutionHandlerContext context)
{
     Object oldVal = context.getRegionProvider().metaPutIfAbsent(key, RedisDataType.REDIS_HLL);
     if (oldVal == RedisDataType.REDIS_PROTECTED)
       throw new RedisDataTypeMismatchException("The key name \"" + key + "\" is protected");

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/ListExecutor.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/ListExecutor.java
b/geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/ListExecutor.java
index fd518b9..cb365e6 100755
--- a/geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/ListExecutor.java
+++ b/geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/ListExecutor.java
@@ -32,7 +32,7 @@ public abstract class ListExecutor extends AbstractExecutor {
     LEFT, RIGHT
   };
 
-  protected final static QueryService getQueryService() {
+  protected static QueryService getQueryService() {
     return GemFireCacheImpl.getInstance().getQueryService();
   }
 

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRangeByLexExecutor.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRangeByLexExecutor.java
b/geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRangeByLexExecutor.java
index 4466521..19bd199 100755
--- a/geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRangeByLexExecutor.java
+++ b/geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRangeByLexExecutor.java
@@ -197,7 +197,7 @@ public class ZRangeByLexExecutor extends SortedSetExecutor {
 
   }
 
-  private final ByteBuf getCustomBulkStringArrayResponse(Collection<ByteArrayWrapper>
items,
+  private ByteBuf getCustomBulkStringArrayResponse(Collection<ByteArrayWrapper> items,
       ExecutionHandlerContext context) {
     Iterator<ByteArrayWrapper> it = items.iterator();
     ByteBuf response = context.getByteBufAllocator().buffer();

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/StringExecutor.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/StringExecutor.java
b/geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/StringExecutor.java
index fb91f09..eb17e41 100755
--- a/geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/StringExecutor.java
+++ b/geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/StringExecutor.java
@@ -22,7 +22,7 @@ import org.apache.geode.redis.internal.executor.AbstractExecutor;
 
 public abstract class StringExecutor extends AbstractExecutor {
 
-  protected final void checkAndSetDataType(ByteArrayWrapper key, ExecutionHandlerContext
context) {
+  protected void checkAndSetDataType(ByteArrayWrapper key, ExecutionHandlerContext context)
{
     Object oldVal = context.getRegionProvider().metaPutIfAbsent(key, RedisDataType.REDIS_STRING);
     if (oldVal == RedisDataType.REDIS_PROTECTED)
       throw new RedisDataTypeMismatchException("The key name \"" + key + "\" is protected");

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-core/src/main/java/org/apache/geode/security/GemFireSecurityException.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/security/GemFireSecurityException.java
b/geode-core/src/main/java/org/apache/geode/security/GemFireSecurityException.java
index 22c0302..2cab06c 100644
--- a/geode-core/src/main/java/org/apache/geode/security/GemFireSecurityException.java
+++ b/geode-core/src/main/java/org/apache/geode/security/GemFireSecurityException.java
@@ -76,7 +76,7 @@ public class GemFireSecurityException extends GemFireException {
   }
 
   @Override
-  public final synchronized Throwable getCause() {
+  public synchronized Throwable getCause() {
     return (this.cause == this ? null : this.cause);
   }
 
@@ -86,7 +86,7 @@ public class GemFireSecurityException extends GemFireException {
    * @param object the {@code object} to test for implementing {@code Serializable}.
    * @return true if the provided {@code object} implements {@code Serializable}.
    */
-  protected final boolean isSerializable(final Object object) {
+  protected boolean isSerializable(final Object object) {
     if (object == null) {
       return true;
     }
@@ -100,7 +100,7 @@ public class GemFireSecurityException extends GemFireException {
    * @return {@code NamingException#getResolvedObj()} if the {@code cause} is a
    *         {@code NamingException}.
    */
-  protected final Object getResolvedObj() {
+  protected Object getResolvedObj() {
     final Throwable thisCause = this.cause;
     if (thisCause != null && NamingException.class.isInstance(thisCause)) {
       return ((NamingException) thisCause).getResolvedObj();

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqConflatable.java
----------------------------------------------------------------------
diff --git a/geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqConflatable.java
b/geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqConflatable.java
index 652f052..be6520b 100644
--- a/geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqConflatable.java
+++ b/geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqConflatable.java
@@ -124,28 +124,28 @@ public class CqConflatable implements Conflatable, Serializable {
   /**
    * @return Returns the conflate.
    */
-  final boolean isConflate() {
+  boolean isConflate() {
     return conflate;
   }
 
   /**
    * @param conflate The conflate to set.
    */
-  final void setConflate(boolean conflate) {
+  void setConflate(boolean conflate) {
     this.conflate = conflate;
   }
 
   /**
    * @return Returns the id.
    */
-  final EventID getId() {
+  EventID getId() {
     return id;
   }
 
   /**
    * @param id The id to set.
    */
-  final void setId(EventID id) {
+  void setId(EventID id) {
     this.id = id;
   }
 
@@ -159,35 +159,35 @@ public class CqConflatable implements Conflatable, Serializable {
   /**
    * @param key The key to set.
    */
-  final void setKey(Object key) {
+  void setKey(Object key) {
     this.key = key;
   }
 
   /**
    * @return Returns the regionname.
    */
-  final String getRegionname() {
+  String getRegionname() {
     return regionname;
   }
 
   /**
    * @param regionname The regionname to set.
    */
-  final void setRegionname(String regionname) {
+  void setRegionname(String regionname) {
     this.regionname = regionname;
   }
 
   /**
    * @return Returns the value.
    */
-  final Object getValue() {
+  Object getValue() {
     return value;
   }
 
   /**
    * @param value The value to set.
    */
-  final void setValue(Object value) {
+  void setValue(Object value) {
     this.value = value;
   }
 }

http://git-wip-us.apache.org/repos/asf/geode/blob/5abc4863/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java
----------------------------------------------------------------------
diff --git a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java
b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java
index 0cfcc37..f5a8fcf 100644
--- a/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java
+++ b/geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java
@@ -86,7 +86,7 @@ public class LocatorDiscovery {
   private static final int FAILURE_LOG_MAX_INTERVAL = Integer.getInteger(
       DistributionConfig.GEMFIRE_PREFIX + "LocatorDiscovery.FAILURE_LOG_MAX_INTERVAL", 300000);
 
-  public final boolean skipFailureLogging(DistributionLocatorId locatorId) {
+  public boolean skipFailureLogging(DistributionLocatorId locatorId) {
     boolean skipLogging = false;
     if (this.failureLogInterval.size() < FAILURE_MAP_MAXSIZE) {
       long[] logInterval = this.failureLogInterval.get(locatorId);


Mime
View raw message