geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject [10/19] geode git commit: GEM-1351: Move a test to the open side and fix the other tests
Date Fri, 07 Apr 2017 19:34:09 GMT
GEM-1351: Move a test to the open side and fix the other tests

* move ImportClusterConfigDistributedTest to open side
* remove @Ignore from other two tests.
* rework GfshShellConnectionRule to not create gfsh shell at class initialization time.


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/02ccc5ca
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/02ccc5ca
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/02ccc5ca

Branch: refs/heads/feature/GEODE-2632
Commit: 02ccc5ca06ee5fe07cdb3924a5b1bbce507d2b58
Parents: 82034c9
Author: Jinmei Liao <jiliao@pivotal.io>
Authored: Wed Apr 5 07:50:09 2017 -0700
Committer: Jinmei Liao <jiliao@pivotal.io>
Committed: Wed Apr 5 07:50:09 2017 -0700

----------------------------------------------------------------------
 .../apache/geode/test/dunit/rules/GfshShellConnectionRule.java   | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/02ccc5ca/geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
b/geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
index bfb77e7..1c72bba 100644
--- a/geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
+++ b/geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
@@ -121,6 +121,10 @@ public class GfshShellConnectionRule extends DescribedExternalResource
{
 
   public void connect(int port, PortType type, String... options) throws Exception {
     CliUtil.isGfshVM = true;
+    if(gfsh == null){
+      this.gfsh = new HeadlessGfsh(getClass().getName(), 30,
+          temporaryFolder.newFolder("gfsh_files").getAbsolutePath());
+    }
     final CommandStringBuilder connectCommand = new CommandStringBuilder(CliStrings.CONNECT);
     String endpoint;
     if (type == PortType.locator) {


Mime
View raw message