geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jstew...@apache.org
Subject [01/50] [abbrv] geode git commit: GEODE-2488: Remove lsof from netstat command tests [Forced Update!]
Date Mon, 13 Mar 2017 17:42:28 GMT
Repository: geode
Updated Branches:
  refs/heads/GEODE-2290 02fac3100 -> 5934e7e39 (forced update)


GEODE-2488: Remove lsof from netstat command tests

Removed the --with-lsof option from netstat command to reduce the
command response size. Avoids OOME's on JVMs in the test environment
with small heaps.

The original tests with lsof have been retained, but annotated with
@Ignore.


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/6118d54c
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/6118d54c
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/6118d54c

Branch: refs/heads/GEODE-2290
Commit: 6118d54c88401d52a9cd829252349a62e84a8afb
Parents: 9766cf2
Author: Ken Howe <khowe@pivotal.io>
Authored: Thu Mar 2 09:40:55 2017 -0800
Committer: Ken Howe <khowe@pivotal.io>
Committed: Thu Mar 2 13:52:26 2017 -0800

----------------------------------------------------------------------
 .../internal/cli/NetstatDUnitTest.java          | 26 +++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/6118d54c/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
index c6248e0..e987fc2 100644
--- a/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
@@ -24,6 +24,7 @@ import org.apache.geode.test.junit.categories.FlakyTest;
 import org.junit.After;
 import org.junit.BeforeClass;
 import org.junit.ClassRule;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
@@ -40,6 +41,7 @@ public class NetstatDUnitTest {
   private static int[] ports = AvailablePortHelper.getRandomAvailableTCPPorts(3);
 
   private static String netStatCommand = null;
+  private static String netStatLsofCommand = null;
 
   @BeforeClass
   public static void beforeClass() throws Exception {
@@ -67,7 +69,8 @@ public class NetstatDUnitTest {
     // start another server
     lsRule.startServerVM(3, properties);
 
-    netStatCommand = "netstat --with-lsof=true --member=" + server.getName();
+    netStatCommand = "netstat --with-lsof=false --member=" + server.getName();
+    netStatLsofCommand = "netstat --with-lsof=true --member=" + server.getName();
   }
 
   @Test
@@ -88,6 +91,27 @@ public class NetstatDUnitTest {
     gfshConnector.executeAndVerifyCommand(netStatCommand);
   }
 
+  @Ignore
+  @Test
+  public void testConnectToLocatorWithLargeCommandResponse() throws Exception {
+    gfshConnector.connect(ports[0], GfshShellConnectionRule.PortType.locator);
+    gfshConnector.executeAndVerifyCommand(netStatLsofCommand);
+  }
+
+  @Ignore
+  @Test
+  public void testConnectToJmxManagerOneWithLargeCommandResponse() throws Exception {
+    gfshConnector.connect(ports[1], GfshShellConnectionRule.PortType.jmxManger);
+    gfshConnector.executeAndVerifyCommand(netStatLsofCommand);
+  }
+
+  @Ignore
+  @Test
+  public void testConnectToJmxManagerTwoWithLargeCommandResponse() throws Exception {
+    gfshConnector.connect(ports[2], GfshShellConnectionRule.PortType.jmxManger);
+    gfshConnector.executeAndVerifyCommand(netStatLsofCommand);
+  }
+
   @After
   public void after() throws Exception {
     gfshConnector.disconnect();


Mime
View raw message