geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject [02/11] geode git commit: GEODE-2433 Backwards compatibility tests are not actually running
Date Mon, 06 Feb 2017 23:26:22 GMT
GEODE-2433 Backwards compatibility tests are not actually running

Tests will now fail of there are no older versions of Geode to test
against.


Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/c8d21665
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/c8d21665
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/c8d21665

Branch: refs/heads/feature/GEODE-1930-2
Commit: c8d216654ac436797fc703faf63de36b300bf116
Parents: 3ce2a12
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Authored: Mon Feb 6 11:38:47 2017 -0800
Committer: Bruce Schuchardt <bschuchardt@pivotal.io>
Committed: Mon Feb 6 11:38:47 2017 -0800

----------------------------------------------------------------------
 .../cache/rollingupgrade/RollingUpgrade2DUnitTest.java       | 8 +++++++-
 .../cache/rollingupgrade/RollingUpgradeDUnitTest.java        | 8 +++++++-
 .../cache/tier/sockets/ClientServerMiscBCDUnitTest.java      | 2 +-
 3 files changed, 15 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/geode/blob/c8d21665/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
index 14d87f9..5106935 100755
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java
@@ -112,7 +112,13 @@ public class RollingUpgrade2DUnitTest extends JUnit4DistributedTestCase
{
 
   @Parameterized.Parameters
   public static Collection<String> data() {
-    return VersionManager.getInstance().getVersionsWithoutCurrent();
+    List<String> result = VersionManager.getInstance().getVersionsWithoutCurrent();
+    if (result.size() < 1) {
+      throw new RuntimeException("No older versions of Geode were found to test against");
+    } else {
+      System.out.println("running against these versions: " + result);
+    }
+    return result;
   }
 
   // just a test flag that can be set when trying to run a test in eclipse and avoiding IllegalState

http://git-wip-us.apache.org/repos/asf/geode/blob/c8d21665/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java
index 369bc3b..54b51de 100644
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java
@@ -74,7 +74,13 @@ public class RollingUpgradeDUnitTest extends JUnit4DistributedTestCase
{
 
   @Parameterized.Parameters
   public static Collection<String> data() {
-    return VersionManager.getInstance().getVersionsWithoutCurrent();
+    List<String> result = VersionManager.getInstance().getVersionsWithoutCurrent();
+    if (result.size() < 1) {
+      throw new RuntimeException("No older versions of Geode were found to test against");
+    } else {
+      System.out.println("running against these versions: " + result);
+    }
+    return result;
   }
 
   private File[] testingDirs = new File[3];

http://git-wip-us.apache.org/repos/asf/geode/blob/c8d21665/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
index 28fe3f2..be0ac6b 100755
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscBCDUnitTest.java
@@ -32,7 +32,7 @@ import java.util.List;
 public class ClientServerMiscBCDUnitTest extends ClientServerMiscDUnitTest {
   @Parameterized.Parameters
   public static Collection<String> data() {
-    List<String> result =  VersionManager.getInstance().getVersionsWithoutCurrent();
+    List<String> result = VersionManager.getInstance().getVersionsWithoutCurrent();
     if (result.size() < 1) {
       throw new RuntimeException("No older versions of Geode were found to test against");
     } else {


Mime
View raw message