geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinmeil...@apache.org
Subject incubator-geode git commit: GEODE-2084 - When executing a rest api in a browser, the login page presented in the browser is not setting the username/password correctly
Date Thu, 10 Nov 2016 22:39:59 GMT
Repository: incubator-geode
Updated Branches:
  refs/heads/develop df2f0c964 -> aac49f3f0


GEODE-2084 - When executing a rest api in a browser, the login page presented in the browser
is not setting the username/password correctly

* Changed RestSecurityConfiguration to not call login(), which will bring up the browsers
Authentication dialog instead.
* this closes #281


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/aac49f3f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/aac49f3f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/aac49f3f

Branch: refs/heads/develop
Commit: aac49f3f0c17c1e396e6dbe9fb84849bd6c9b2c6
Parents: df2f0c9
Author: Kevin Duling <kduling@pivotal.io>
Authored: Thu Nov 10 10:44:37 2016 -0800
Committer: Jinmei Liao <jiliao@pivotal.io>
Committed: Thu Nov 10 14:39:13 2016 -0800

----------------------------------------------------------------------
 .../rest/internal/web/security/RestSecurityConfiguration.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/aac49f3f/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityConfiguration.java
----------------------------------------------------------------------
diff --git a/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityConfiguration.java
b/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityConfiguration.java
index 3aa5622..f0491b7 100644
--- a/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityConfiguration.java
+++ b/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityConfiguration.java
@@ -56,7 +56,7 @@ public class RestSecurityConfiguration extends WebSecurityConfigurerAdapter
{
         .authorizeRequests()
         .antMatchers("/ping", "/docs/**", "/swagger-ui.html", "/v2/api-docs/**",
             "/webjars/springfox-swagger-ui/**", "/swagger-resources/**")
-        .permitAll().anyRequest().authenticated().and().formLogin().and().csrf().disable();
+        .permitAll().anyRequest().authenticated().and().csrf().disable();
 
     if (securityService.isIntegratedSecurity()) {
       http.httpBasic();


Mime
View raw message