Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4040E200B7C for ; Thu, 25 Aug 2016 02:38:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3EEE3160AB1; Thu, 25 Aug 2016 00:38:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 85B27160AC1 for ; Thu, 25 Aug 2016 02:38:40 +0200 (CEST) Received: (qmail 71677 invoked by uid 500); 25 Aug 2016 00:38:39 -0000 Mailing-List: contact commits-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list commits@geode.incubator.apache.org Received: (qmail 71668 invoked by uid 99); 25 Aug 2016 00:38:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2016 00:38:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1A05CC2FB9 for ; Thu, 25 Aug 2016 00:38:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.739 X-Spam-Level: X-Spam-Status: No, score=-3.739 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.519] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1Ktzk_D1n_Dk for ; Thu, 25 Aug 2016 00:38:37 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 263EA5FE5A for ; Thu, 25 Aug 2016 00:38:36 +0000 (UTC) Received: (qmail 70851 invoked by uid 99); 25 Aug 2016 00:38:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2016 00:38:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 245E7EEF4D; Thu, 25 Aug 2016 00:38:35 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: udo@apache.org To: commits@geode.incubator.apache.org Date: Thu, 25 Aug 2016 00:38:42 -0000 Message-Id: In-Reply-To: <48b3c9c0090f4169a29090a9ede17837@git.apache.org> References: <48b3c9c0090f4169a29090a9ede17837@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [09/18] incubator-geode git commit: GEODE-1768: CI failure: ResourceManagerDUnitTest.testRemoveDuringKeySet archived-at: Thu, 25 Aug 2016 00:38:41 -0000 GEODE-1768: CI failure: ResourceManagerDUnitTest.testRemoveDuringKeySet - Marked the test as flaky - added one new assertion - Improved the assertion error message to help debug Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/9b9215b8 Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/9b9215b8 Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/9b9215b8 Branch: refs/heads/feature/GEODE-420 Commit: 9b9215b86c623f769887e77bbab988fb3ddb76b7 Parents: efe09a3 Author: Swapnil Bawaskar Authored: Fri Aug 19 14:52:18 2016 -0700 Committer: Swapnil Bawaskar Committed: Mon Aug 22 17:56:04 2016 -0700 ---------------------------------------------------------------------- .../gemfire/cache/management/ResourceManagerDUnitTest.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/9b9215b8/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java b/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java index 361ac2e..e94dc1b 100644 --- a/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java +++ b/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java @@ -922,7 +922,7 @@ public class ResourceManagerDUnitTest extends JUnit4CacheTestCase { public void run() { invoked[0] = true; logger.debug("In bucketReadHook"); - prds.removeBucket(0, false); + assertTrue(prds.removeBucket(0, false)); } }); try { @@ -950,8 +950,8 @@ public class ResourceManagerDUnitTest extends JUnit4CacheTestCase { Bucket bucket = pr.getRegionAdvisor().getBucket(0); BucketRegion bucketRegion = bucket.getBucketAdvisor() .getProxyBucketRegion().getHostedBucketRegion(); - - assertFalse("Target member is still hosting removed bucket", + + assertFalse("Target member is still hosting removed bucket. Bucket:"+ bucket+" Advisor state:"+bucket.getBucketAdvisor(), bucket.isHosting()); assertNull(bucketRegion); @@ -1005,6 +1005,7 @@ public class ResourceManagerDUnitTest extends JUnit4CacheTestCase { }); } + @Category(FlakyTest.class) // GEODE-1768: thread unsafe test hook (bucketReadHook), remove bucket fails, possible product bug in rebalancing @Test public void testRemoveDuringKeySet() { doOpDuringBucketRemove(new OpDuringBucketRemove() {