geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dschnei...@apache.org
Subject [4/5] incubator-geode git commit: comments
Date Thu, 04 Aug 2016 00:28:38 GMT
comments


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/b93aba1f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/b93aba1f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/b93aba1f

Branch: refs/heads/feature/GEODE-1714
Commit: b93aba1fb371d017fde3a8ce37e94cdbd2083054
Parents: 8a1269a
Author: Darrel Schneider <dschneider@pivotal.io>
Authored: Thu Jul 28 15:35:46 2016 -0700
Committer: Darrel Schneider <dschneider@pivotal.io>
Committed: Thu Jul 28 15:35:46 2016 -0700

----------------------------------------------------------------------
 .../main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/b93aba1f/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java
index 1b8fde0..78cea8c 100644
--- a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java
+++ b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java
@@ -1416,7 +1416,7 @@ public interface DiskEntry extends RegionEntry {
       dr.acquireReadLock();
       try {
       synchronized (did) {
-        // check for a concurrent freeAllEntriesOnDisk which removes entries synced on did
but not on entry
+        // check for a concurrent freeAllEntriesOnDisk which syncs on DiskId but not on the
entry
         if (entry.isRemovedFromDisk()) {
           return 0;
         }
@@ -1446,6 +1446,8 @@ public interface DiskEntry extends RegionEntry {
           entry.handleValueOverflow(region);
           entry.setValueWithContext(region,null);
           change = ((LRUClockNode)entry).updateEntrySize(ccHelper);
+          // the caller checked to make sure we had something to overflow
+          // so dec inVM and inc onDisk
           updateStats(dr, region, -1/*InVM*/, 1/*OnDisk*/, getValueLength(did));
         }
       }


Mime
View raw message