geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sbawas...@apache.org
Subject [2/2] incubator-geode git commit: GEODE-1768: CI failure: ResourceManagerDUnitTest.testRemoveDuringKeySet
Date Tue, 23 Aug 2016 00:56:16 GMT
GEODE-1768: CI failure: ResourceManagerDUnitTest.testRemoveDuringKeySet

- Marked the test as flaky
- added one new assertion
- Improved the assertion error message to help debug


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/9b9215b8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/9b9215b8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/9b9215b8

Branch: refs/heads/develop
Commit: 9b9215b86c623f769887e77bbab988fb3ddb76b7
Parents: efe09a3
Author: Swapnil Bawaskar <sbawaskar@pivotal.io>
Authored: Fri Aug 19 14:52:18 2016 -0700
Committer: Swapnil Bawaskar <sbawaskar@pivotal.io>
Committed: Mon Aug 22 17:56:04 2016 -0700

----------------------------------------------------------------------
 .../gemfire/cache/management/ResourceManagerDUnitTest.java    | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/9b9215b8/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
index 361ac2e..e94dc1b 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
@@ -922,7 +922,7 @@ public class ResourceManagerDUnitTest extends JUnit4CacheTestCase {
             public void run() {
               invoked[0] = true;
               logger.debug("In bucketReadHook");
-              prds.removeBucket(0, false);
+              assertTrue(prds.removeBucket(0, false));
             }
           });
         try {
@@ -950,8 +950,8 @@ public class ResourceManagerDUnitTest extends JUnit4CacheTestCase {
         Bucket bucket = pr.getRegionAdvisor().getBucket(0);
         BucketRegion bucketRegion = bucket.getBucketAdvisor()
             .getProxyBucketRegion().getHostedBucketRegion();
-        
-        assertFalse("Target member is still hosting removed bucket", 
+
+        assertFalse("Target member is still hosting removed bucket. Bucket:"+ bucket+" Advisor
state:"+bucket.getBucketAdvisor(),
                     bucket.isHosting());
         
         assertNull(bucketRegion);
@@ -1005,6 +1005,7 @@ public class ResourceManagerDUnitTest extends JUnit4CacheTestCase {
       });
   }
 
+  @Category(FlakyTest.class) // GEODE-1768: thread unsafe test hook (bucketReadHook), remove
bucket fails, possible product bug in rebalancing
   @Test
   public void testRemoveDuringKeySet() {
     doOpDuringBucketRemove(new OpDuringBucketRemove() {


Mime
View raw message