geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject incubator-geode git commit: GEODE-1147: Remove FlakyTest Tag
Date Mon, 01 Aug 2016 21:20:55 GMT
Repository: incubator-geode
Updated Branches:
  refs/heads/develop 80ac9956e -> b9387fb57


GEODE-1147: Remove FlakyTest Tag

	* Refactored the test in correct order of creation of cache, region and sender/receiver.
	* The WANTestBase.preTearDown was refactored in GEODE-1588
	* FlakyTest tag removed till failure is noticed again.


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/b9387fb5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/b9387fb5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/b9387fb5

Branch: refs/heads/develop
Commit: b9387fb573d3d2a15964f6435fd9247ee56cd856
Parents: 80ac995
Author: nabarun <nnag@pivotal.io>
Authored: Mon Aug 1 14:18:28 2016 -0700
Committer: nabarun <nnag@pivotal.io>
Committed: Mon Aug 1 14:18:28 2016 -0700

----------------------------------------------------------------------
 ...NPropogation_PartitionedRegionDUnitTest.java | 33 +++++++++++---------
 1 file changed, 18 insertions(+), 15 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/b9387fb5/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java
b/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java
index be8c353..c51c992 100644
--- a/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java
+++ b/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogation_PartitionedRegionDUnitTest.java
@@ -368,7 +368,6 @@ public class SerialWANPropogation_PartitionedRegionDUnitTest extends WANTestBase
         getTestMethodName() + "_PR", 1000 ));
   }
 
-  @Category(FlakyTest.class) // GEODE-1147: random ports, time sensitive, waitForCriterion,
eats exceptions
   @Test
   public void testPartitionedSerialPropagationWithParallelThreads() throws Exception {
 
@@ -378,32 +377,36 @@ public class SerialWANPropogation_PartitionedRegionDUnitTest extends
WANTestBase
     createCacheInVMs(nyPort, vm2, vm3);
     createCacheInVMs(lnPort, vm4, vm5, vm6, vm7);
 
-    vm4.invoke(() -> WANTestBase.createSender( "ln", 2,
-        false, 100, 10, false, false, null, true ));
-    vm5.invoke(() -> WANTestBase.createSender( "ln", 2,
-        false, 100, 10, false, false, null, true ));
-
     vm4.invoke(() -> WANTestBase.createPartitionedRegion(
-        getTestMethodName() + "_PR", "ln", 1, 100, isOffHeap() ));
+      getTestMethodName() + "_PR", "ln", 1, 100, isOffHeap() ));
     vm5.invoke(() -> WANTestBase.createPartitionedRegion(
-        getTestMethodName() + "_PR", "ln", 1, 100, isOffHeap() ));
+      getTestMethodName() + "_PR", "ln", 1, 100, isOffHeap() ));
     vm6.invoke(() -> WANTestBase.createPartitionedRegion(
-        getTestMethodName() + "_PR", "ln", 1, 100, isOffHeap() ));
+      getTestMethodName() + "_PR", "ln", 1, 100, isOffHeap() ));
     vm7.invoke(() -> WANTestBase.createPartitionedRegion(
-        getTestMethodName() + "_PR", "ln", 1, 100, isOffHeap() ));
-
-    startSenderInVMs("ln", vm4, vm5);
-
+      getTestMethodName() + "_PR", "ln", 1, 100, isOffHeap() ));
     vm2.invoke(() -> WANTestBase.createPartitionedRegion(
-        getTestMethodName() + "_PR", null, 1, 100, isOffHeap() ));
+      getTestMethodName() + "_PR", null, 1, 100, isOffHeap() ));
     vm3.invoke(() -> WANTestBase.createPartitionedRegion(
-        getTestMethodName() + "_PR", null, 1, 100, isOffHeap() ));
+      getTestMethodName() + "_PR", null, 1, 100, isOffHeap() ));
+
     createReceiverInVMs(vm2, vm3);
 
+    vm4.invoke(() -> WANTestBase.createSender( "ln", 2,
+        false, 100, 10, false, false, null, true ));
+    vm5.invoke(() -> WANTestBase.createSender( "ln", 2,
+        false, 100, 10, false, false, null, true ));
+
+    startSenderInVMs("ln", vm4, vm5);
+
+
+
     vm4.invoke(() -> WANTestBase.doMultiThreadedPuts( // TODO: eats exceptions
         getTestMethodName() + "_PR", 1000 ));
 
     vm2.invoke(() -> WANTestBase.validateRegionSize(
         getTestMethodName() + "_PR", 1000 ));
+    vm3.invoke(() -> WANTestBase.validateRegionSize(
+      getTestMethodName() + "_PR", 1000 ));
   }
 }


Mime
View raw message