geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject [1/3] incubator-geode git commit: GEODE-1656: fix compilation warnings with @SuppressWarnings annotations
Date Thu, 14 Jul 2016 16:06:40 GMT
Repository: incubator-geode
Updated Branches:
  refs/heads/develop 1318a4aeb -> 5b2898761


GEODE-1656: fix compilation warnings with @SuppressWarnings annotations


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/f78f70c8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/f78f70c8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/f78f70c8

Branch: refs/heads/develop
Commit: f78f70c879d6c6b017084309e15ae2f270087adb
Parents: 1318a4a
Author: gmeilen <gracemeilen@gmail.com>
Authored: Mon Jul 11 16:42:56 2016 -0700
Committer: Kirk Lund <klund@apache.org>
Committed: Thu Jul 14 09:02:37 2016 -0700

----------------------------------------------------------------------
 .../modules/session/internal/filter/GemfireHttpSession.java | 1 +
 .../gemfire/modules/session/installer/JarClassLoader.java   | 1 +
 .../filter/SessionReplicationIntegrationJUnitTest.java      | 1 +
 .../gemfire/internal/cache/tier/sockets/HandShake.java      | 9 ---------
 .../gemfire/internal/security/GeodeSecurityUtil.java        | 4 ----
 .../gemfire/cache/query/internal/cq/CqQueryImpl.java        | 5 +++--
 .../vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java | 1 +
 .../gemfire/cache/client/internal/GatewaySenderBatchOp.java | 1 +
 .../gemfire/internal/cache/wan/GatewayReceiverImpl.java     | 2 +-
 .../cli/commands/DataCommandsOverHttpDistributedTest.java   | 1 +
 10 files changed, 10 insertions(+), 16 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/extensions/geode-modules-session-internal/src/main/java/com/gemstone/gemfire/modules/session/internal/filter/GemfireHttpSession.java
----------------------------------------------------------------------
diff --git a/extensions/geode-modules-session-internal/src/main/java/com/gemstone/gemfire/modules/session/internal/filter/GemfireHttpSession.java
b/extensions/geode-modules-session-internal/src/main/java/com/gemstone/gemfire/modules/session/internal/filter/GemfireHttpSession.java
index 695a03b..88380c6 100644
--- a/extensions/geode-modules-session-internal/src/main/java/com/gemstone/gemfire/modules/session/internal/filter/GemfireHttpSession.java
+++ b/extensions/geode-modules-session-internal/src/main/java/com/gemstone/gemfire/modules/session/internal/filter/GemfireHttpSession.java
@@ -46,6 +46,7 @@ import org.slf4j.LoggerFactory;
 /**
  * Class which implements a Gemfire persisted {@code HttpSession}
  */
+@SuppressWarnings("deprecation")
 public class GemfireHttpSession implements
     HttpSession, DataSerializable, Delta {
 

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/extensions/geode-modules-session/src/main/java/com/gemstone/gemfire/modules/session/installer/JarClassLoader.java
----------------------------------------------------------------------
diff --git a/extensions/geode-modules-session/src/main/java/com/gemstone/gemfire/modules/session/installer/JarClassLoader.java
b/extensions/geode-modules-session/src/main/java/com/gemstone/gemfire/modules/session/installer/JarClassLoader.java
index ba528ce..986ddce 100644
--- a/extensions/geode-modules-session/src/main/java/com/gemstone/gemfire/modules/session/installer/JarClassLoader.java
+++ b/extensions/geode-modules-session/src/main/java/com/gemstone/gemfire/modules/session/installer/JarClassLoader.java
@@ -33,6 +33,7 @@ import java.util.jar.JarFile;
  * Classloader, which allows finding classes in jars  within jars. This is used to check
  * whether a listener, as found in web.xml, is a ServletContextListener
  */
+@SuppressWarnings("deprecation")
 public class JarClassLoader extends URLClassLoader {
 
   public JarClassLoader(URL[] urls, ClassLoader parent) {

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
----------------------------------------------------------------------
diff --git a/extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
b/extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
index 309ee4e..da56735 100644
--- a/extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
+++ b/extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
@@ -55,6 +55,7 @@ import static org.junit.Assert.*;
  */
 @Category(IntegrationTest.class)
 @RunWith(PerTestClassLoaderRunner.class)
+@SuppressWarnings("unchecked")
 public class SessionReplicationIntegrationJUnitTest {
 
   private MyServletTester tester;

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java
b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java
index cf69d0c..a2951f5 100755
--- a/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java
+++ b/geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/HandShake.java
@@ -1784,15 +1784,6 @@ public class HandShake implements ClientHandShake
 
   /**
    * this could return either a Subject or a Principal depending on if it's integrated security
or not
-   * @param authenticatorMethod
-   * @param credentials
-   * @param securityProperties
-   * @param logWriter
-   * @param securityLogWriter
-   * @param member
-   * @return
-   * @throws AuthenticationRequiredException
-   * @throws AuthenticationFailedException
    */
   public static Object verifyCredentials(String authenticatorMethod,
       Properties credentials, Properties securityProperties, InternalLogWriter logWriter,

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
b/geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
index 59bcb12..8707a78 100644
--- a/geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
+++ b/geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
@@ -163,9 +163,6 @@ public class GeodeSecurityUtil {
    *   if(state!=null)
    *      state.clear();
    * }
-   *
-   * @param subject
-   * @return
    */
   public static ThreadState bindSubject(Subject subject){
     if (subject == null) {
@@ -350,7 +347,6 @@ public class GeodeSecurityUtil {
   /**
    * postProcess call already has this logic built in, you don't need to call this everytime
you call postProcess.
    * But if your postProcess is pretty involved with preparations and you need to bypass
it entirely, call this first.
-   * @return
    */
   public static boolean needPostProcess(){
     Subject subject = getSubject();

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqQueryImpl.java
----------------------------------------------------------------------
diff --git a/geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqQueryImpl.java
b/geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqQueryImpl.java
index 275ec84..2ca82e0 100644
--- a/geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqQueryImpl.java
+++ b/geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqQueryImpl.java
@@ -48,10 +48,11 @@ import com.gemstone.gemfire.internal.logging.LogService;
 import com.gemstone.gemfire.i18n.StringId;
 
 /**
+ * Represents the CqQuery object. Implements CqQuery API and CqAttributeMutator.
+ *
  * @since GemFire 5.5
- * Represents the CqQuery object. Implements CqQuery API and CqAttributeMutator. 
- *  
  */
+@SuppressWarnings("deprecation")
 public abstract class CqQueryImpl implements InternalCqQuery {
   private static final Logger logger = LogService.getLogger();
   

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java
----------------------------------------------------------------------
diff --git a/geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java
b/geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java
index 23c7f75..eeaa069 100644
--- a/geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java
+++ b/geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAbstractTest.java
@@ -47,6 +47,7 @@ import org.openqa.selenium.support.ui.WebDriverWait;
 import com.gemstone.gemfire.management.internal.JettyHelper;
 import com.vmware.gemfire.tools.pulse.internal.data.PulseConstants;
 
+@SuppressWarnings("deprecated")
 public abstract class PulseAbstractTest extends PulseBaseTest {
 
   private static String jmxPropertiesFile;

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/GatewaySenderBatchOp.java
----------------------------------------------------------------------
diff --git a/geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/GatewaySenderBatchOp.java
b/geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/GatewaySenderBatchOp.java
index be0a4f7..ef5f816 100755
--- a/geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/GatewaySenderBatchOp.java
+++ b/geode-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/GatewaySenderBatchOp.java
@@ -37,6 +37,7 @@ import java.util.List;
 
 import org.apache.logging.log4j.Logger;
 
+@SuppressWarnings("unchecked")
 public class GatewaySenderBatchOp {
   
   private static final Logger logger = LogService.getLogger();

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java
----------------------------------------------------------------------
diff --git a/geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java
b/geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java
index 3779749..9fd73e6 100644
--- a/geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java
+++ b/geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewayReceiverImpl.java
@@ -40,9 +40,9 @@ import com.gemstone.gemfire.internal.logging.LogService;
 import com.gemstone.gemfire.internal.logging.log4j.LocalizedMessage;
 
 /**
- * 
  * @since GemFire 7.0
  */
+@SuppressWarnings("deprecation")
 public class GatewayReceiverImpl implements GatewayReceiver {
 
   private static final Logger logger = LogService.getLogger();

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/f78f70c8/geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommandsOverHttpDistributedTest.java
----------------------------------------------------------------------
diff --git a/geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommandsOverHttpDistributedTest.java
b/geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommandsOverHttpDistributedTest.java
index 3c673f5..11b8ab1 100644
--- a/geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommandsOverHttpDistributedTest.java
+++ b/geode-web/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommandsOverHttpDistributedTest.java
@@ -40,6 +40,7 @@ import org.junit.contrib.java.lang.system.ProvideSystemProperty;
 import org.junit.experimental.categories.Category;
 
 @Category(DistributedTest.class)
+@SuppressWarnings("deprecated")
 public class DataCommandsOverHttpDistributedTest extends CliCommandTestBase {
 
   private static final String REBALANCE_REGION_NAME = DataCommandsOverHttpDistributedTest.class.getSimpleName()
+ "Region";


Mime
View raw message