geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From upthewatersp...@apache.org
Subject [1/2] incubator-geode git commit: Fixing test failures after junit 4 conversion
Date Tue, 24 May 2016 22:23:17 GMT
Repository: incubator-geode
Updated Branches:
  refs/heads/feature/GEODE-837 54cb7d534 -> 5fb3826e5


Fixing test failures after junit 4 conversion


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/6fbcebfb
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/6fbcebfb
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/6fbcebfb

Branch: refs/heads/feature/GEODE-837
Commit: 6fbcebfbe359b96b3d3898573375588aec94035e
Parents: 54cb7d5
Author: Dan Smith <dsmith@pivotal.io>
Authored: Tue May 24 11:28:38 2016 -0700
Committer: Dan Smith <dsmith@pivotal.io>
Committed: Tue May 24 11:28:38 2016 -0700

----------------------------------------------------------------------
 .../gemstone/gemfire/internal/cache/PRBadToDataDUnitTest.java  | 4 ----
 .../internal/cache/PartitionedRegionEntryCountDUnitTest.java   | 4 ----
 .../gemfire/internal/statistics/StatisticsDUnitTest.java       | 6 +++---
 3 files changed, 3 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/6fbcebfb/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PRBadToDataDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PRBadToDataDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PRBadToDataDUnitTest.java
index 76af914..9ab247e 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PRBadToDataDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PRBadToDataDUnitTest.java
@@ -49,10 +49,6 @@ import com.gemstone.gemfire.test.dunit.VM;
 @Category(DistributedTest.class)
 public class PRBadToDataDUnitTest extends JUnit4CacheTestCase {
 
-  public PRBadToDataDUnitTest(final String name) {
-    super();
-  }
-
   @Test
   public void testBadToData() {
     final Host host = Host.getHost(0);

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/6fbcebfb/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionEntryCountDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionEntryCountDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionEntryCountDUnitTest.java
index 466de43..ff5413c 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionEntryCountDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionEntryCountDUnitTest.java
@@ -47,10 +47,6 @@ import com.gemstone.gemfire.test.dunit.VM;
 public class PartitionedRegionEntryCountDUnitTest extends JUnit4CacheTestCase {
   private static final long serialVersionUID = 19808034671087558L;
 
-  public PartitionedRegionEntryCountDUnitTest(final String name) {
-    super();
-  }
-
   @Test
   public void testTotalEntryCountAfterLocalDestroyEviction() {
     final Host host = Host.getHost(0);

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/6fbcebfb/geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsDUnitTest.java
index c9408ad..6673dbf 100755
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatisticsDUnitTest.java
@@ -441,7 +441,7 @@ public class StatisticsDUnitTest extends JUnit4CacheTestCase {
                 double mean = sv.getSnapshotsAverage();
                 double stdDev = sv.getSnapshotsStandardDeviation();
                 
-                assertEquals(mostRecent, max);
+                assertEquals(mostRecent, max, 0f);
   
                 double summation = 0;
                 double[] rawSnapshots = sv.getRawSnapshots();
@@ -449,7 +449,7 @@ public class StatisticsDUnitTest extends JUnit4CacheTestCase {
                   //log.convertToLogWriter().info("DEBUG " + ri.getName() + " " + statName
+ " rawSnapshots[" + j + "] = " + rawSnapshots[j]);
                   summation += rawSnapshots[j];
                 }
-                assertEquals(mean, summation / sv.getSnapshotsSize());
+                assertEquals(mean, summation / sv.getSnapshotsSize(), 0);
                 
                 combinedPuts += mostRecent;
               }
@@ -457,7 +457,7 @@ public class StatisticsDUnitTest extends JUnit4CacheTestCase {
           }
           
           // assert that sum of mostRecent values for all puts equals totalPuts
-          assertEquals((double)totalPuts, combinedPuts);
+          assertEquals((double)totalPuts, combinedPuts, 0);
           puts.getAndAdd(totalPuts);
         }
       });


Mime
View raw message