geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject [06/11] incubator-geode git commit: GEODE-558 DistributedSystemIdDUnitTest.testInfectiousId locator already exist
Date Thu, 05 May 2016 20:50:21 GMT
GEODE-558 DistributedSystemIdDUnitTest.testInfectiousId locator already exist

Added disconnectAllFromDS to preSetUp to protect the test from other
flaky tests.


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/a45f452d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/a45f452d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/a45f452d

Branch: refs/heads/feature/GEODE-1276
Commit: a45f452d153975b499c12eeaa3ed4e1239cdfb71
Parents: 1a50b76
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Authored: Wed May 4 16:16:23 2016 -0700
Committer: Bruce Schuchardt <bschuchardt@pivotal.io>
Committed: Wed May 4 16:17:52 2016 -0700

----------------------------------------------------------------------
 .../com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/a45f452d/geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java
old mode 100644
new mode 100755
index 011aa4f..8c00ab3
--- a/geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/pdx/DistributedSystemIdDUnitTest.java
@@ -37,6 +37,11 @@ public class DistributedSystemIdDUnitTest extends DistributedTestCase {
     super(name);
   }
 
+  @Override
+  public void preSetUp() {
+    disconnectAllFromDS(); // GEODE-558 test fails due to infection from another test
+  }
+
   public void testMatchingIds() {
     Host host = Host.getHost(0);
     VM vm0 = host.getVM(0);
@@ -53,7 +58,6 @@ public class DistributedSystemIdDUnitTest extends DistributedTestCase {
     
   }
   
-  @Category(FlakyTest.class) // GEODE-558: random ports, test pollution (TODO: disconnect
DS in setup?)
   public void testInfectiousId() {
     Host host = Host.getHost(0);
     VM vm0 = host.getVM(0);


Mime
View raw message