geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject [03/11] incubator-geode git commit: added a TODO for a test that isn't checking what it claims to be checking
Date Thu, 05 May 2016 20:50:18 GMT
added a TODO for a test that isn't checking what it claims to be checking


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/e63acceb
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/e63acceb
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/e63acceb

Branch: refs/heads/feature/GEODE-1276
Commit: e63acceb429fb23b5e9551dbed28126d9ecd5076
Parents: fc38555
Author: Bruce Schuchardt <bschuchardt@pivotal.io>
Authored: Wed May 4 11:32:22 2016 -0700
Committer: Bruce Schuchardt <bschuchardt@pivotal.io>
Committed: Wed May 4 11:33:09 2016 -0700

----------------------------------------------------------------------
 .../java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/e63acceb/geode-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java
index fdbc96c..ca2c17b 100755
--- a/geode-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java
@@ -163,8 +163,13 @@ public class ReconnectDUnitTest extends CacheTestCase
     return factory.create();
   }
 
-  // quorum check fails, then succeeds
+  /*
+  TODO this test is not actually using quorum checks.  To do that it needs to
+  have the locator disconnect & reconnect
+   */
+
   public void testReconnectWithQuorum() throws Exception {
+    // quorum check fails, then succeeds
     IgnoredException.addIgnoredException("killing member's ds");
     Host host = Host.getHost(0);
     VM vm0 = host.getVM(0);


Mime
View raw message