geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl...@apache.org
Subject incubator-geode git commit: Adding FlakyTest category to flaky tests (BindException or time sensitive)
Date Fri, 15 Apr 2016 19:56:33 GMT
Repository: incubator-geode
Updated Branches:
  refs/heads/feature/GEODE-1233 40de500e4 -> 877b5de8b


Adding FlakyTest category to flaky tests (BindException or time sensitive)


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/877b5de8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/877b5de8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/877b5de8

Branch: refs/heads/feature/GEODE-1233
Commit: 877b5de8b3509b655fcb3fedbf0fb77c97d31891
Parents: 40de500
Author: Kirk Lund <klund@apache.org>
Authored: Fri Apr 15 12:56:01 2016 -0700
Committer: Kirk Lund <klund@apache.org>
Committed: Fri Apr 15 12:56:01 2016 -0700

----------------------------------------------------------------------
 .../gemstone/gemfire/cache/ConnectionPoolDUnitTest.java  |  3 +++
 .../com/gemstone/gemfire/cache30/Bug44418JUnitTest.java  |  6 ++++--
 .../distributed/LocatorLauncherRemoteJUnitTest.java      | 11 ++++++++---
 ...cheduledThreadPoolExecutorWithKeepAliveJUnitTest.java |  4 +++-
 .../PersistentPartitionedRegionDUnitTest.java            |  6 +++---
 .../UniversalMembershipListenerAdapterDUnitTest.java     |  2 --
 .../CreateAlterDestroyRegionCommandsDUnitTest.java       | 10 ++--------
 .../cli/commands/DiskStoreCommandsDUnitTest.java         |  2 ++
 .../cli/commands/GemfireDataCommandsDUnitTest.java       |  2 ++
 .../internal/cli/commands/IndexCommandsDUnitTest.java    |  4 +++-
 .../cli/commands/MiscellaneousCommandsDUnitTest.java     |  3 ++-
 .../SharedConfigurationUsingDirDUnitTest.java            |  2 ++
 .../internal/cli/commands/ClientCommandsDUnitTest.java   |  2 +-
 .../gemfire/security/ClientAuthzObjectModDUnitTest.java  |  4 +++-
 .../security/ClientPostAuthorizationDUnitTest.java       |  9 +++------
 .../gemstone/gemfire/internal/cache/wan/WANTestBase.java |  2 +-
 16 files changed, 42 insertions(+), 30 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
index 2acab3a..839e0b0 100755
--- a/geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
@@ -31,6 +31,7 @@ import java.util.Set;
 import junit.framework.AssertionFailedError;
 
 import org.junit.FixMethodOrder;
+import org.junit.experimental.categories.Category;
 
 import com.gemstone.gemfire.CancelException;
 import com.gemstone.gemfire.LogWriter;
@@ -70,6 +71,7 @@ import com.gemstone.gemfire.test.dunit.ThreadUtils;
 import com.gemstone.gemfire.test.dunit.VM;
 import com.gemstone.gemfire.test.dunit.Wait;
 import com.gemstone.gemfire.test.dunit.WaitCriterion;
+import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 
 /**
  * This class tests the client connection pool in GemFire.
@@ -1186,6 +1188,7 @@ public class ConnectionPoolDUnitTest extends CacheTestCase {
    * Make sure cnx lifetime expiration working on thread local cnxs.
    * @author darrel
    */
+  @Category(FlakyTest.class) // GEODE-1197: BindException
   public void test009LifetimeExpireOnTL() throws CacheException {
     basicTestLifetimeExpire(true);
   }

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java
index ccd9df0..d74da9a 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java
@@ -37,6 +37,7 @@ import com.gemstone.gemfire.cache.Region.Entry;
 import com.gemstone.gemfire.cache.RegionShortcut;
 import com.gemstone.gemfire.distributed.DistributedSystem;
 import com.gemstone.gemfire.internal.cache.LocalRegion;
+import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 import com.gemstone.gemfire.test.junit.categories.IntegrationTest;
 
 
@@ -46,12 +47,13 @@ import com.gemstone.gemfire.test.junit.categories.IntegrationTest;
  * @since 7.0
  */
 @Category(IntegrationTest.class)
+@SuppressWarnings({ "unchecked", "rawtypes" })
 public class Bug44418JUnitTest {
 
   DistributedSystem ds;
   Cache cache;
 
-  @SuppressWarnings({ "unchecked", "rawtypes" })
+  @Category(FlakyTest.class) // GEODE-1139: time sensitive
   @Test
   public void testPut() throws Exception {
 
@@ -98,7 +100,7 @@ public class Bug44418JUnitTest {
       System.getProperties().remove(LocalRegion.EXPIRY_MS_PROPERTY);
     }
   }
-  @SuppressWarnings({ "unchecked", "rawtypes" })
+
   @Test
   public void testGet() throws Exception {
 

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
index 1be5ea4..e9ac834 100755
--- a/geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
@@ -147,6 +147,7 @@ public class LocatorLauncherRemoteJUnitTest extends AbstractLocatorLauncherJUnit
   }
   */
 
+  @Category(FlakyTest.class) // GEODE-473: BindException
   @Test
   public void testStartCreatesPidFile() throws Throwable {
     // build and start the locator
@@ -203,6 +204,7 @@ public class LocatorLauncherRemoteJUnitTest extends AbstractLocatorLauncherJUnit
     }
   }
 
+  @Category(FlakyTest.class) // GEODE-530: BindException
   @Test
   public void testStartDeletesStaleControlFiles() throws Throwable {
     // create existing control files
@@ -274,7 +276,7 @@ public class LocatorLauncherRemoteJUnitTest extends AbstractLocatorLauncherJUnit
     }
   }
 
-  @Category(FlakyTest.class)
+  @Category(FlakyTest.class) // GEODE-1229: BindException
   @Test
   public void testStartOverwritesStalePidFile() throws Throwable {
     // create existing pid file
@@ -330,6 +332,7 @@ public class LocatorLauncherRemoteJUnitTest extends AbstractLocatorLauncherJUnit
     }
   }
 
+  @Category(FlakyTest.class) // GEODE-764: BindException
   @Test
   public void testStartUsingForceOverwritesExistingPidFile() throws Throwable {
     // create existing pid file
@@ -693,7 +696,8 @@ public class LocatorLauncherRemoteJUnitTest extends AbstractLocatorLauncherJUnit
       this.errorCollector.addError(e);
     }
   }
-  
+
+  @Category(FlakyTest.class) // GEODE-569: BindException
   @Test
   public void testStatusUsingWorkingDirectory() throws Throwable {
     final List<String> jvmArguments = getJvmArguments();
@@ -892,7 +896,8 @@ public class LocatorLauncherRemoteJUnitTest extends AbstractLocatorLauncherJUnit
       this.errorCollector.addError(e);
     }
   }
-  
+
+  @Category(FlakyTest.class) // GEODE-847: BindException
   @Test
   public void testStopUsingWorkingDirectory() throws Throwable {
     final List<String> jvmArguments = getJvmArguments();

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java
index 2ed0152..5078c6c 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/ScheduledThreadPoolExecutorWithKeepAliveJUnitTest.java
@@ -34,6 +34,7 @@ import org.junit.After;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
+import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 import com.gemstone.gemfire.test.junit.categories.IntegrationTest;
 
 /**
@@ -87,7 +88,8 @@ public class ScheduledThreadPoolExecutorWithKeepAliveJUnitTest {
     
     assertEquals(2, ex.getLargestPoolSize());
   }
-  
+
+  @Category(FlakyTest.class) // GEODE-1138: time sensitive
   @Test
   public void testConcurrentExecutionAndExpiration() throws InterruptedException, ExecutionException
{
     ex = new ScheduledThreadPoolExecutorWithKeepAlive(

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
index c7cc33f..ad10e07 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
@@ -93,7 +93,6 @@ import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 
 /**
  * Tests the basic use cases for PR persistence.
- *
  */
 public class PersistentPartitionedRegionDUnitTest extends PersistentPartitionedRegionTestBase
{
   private static final int NUM_BUCKETS = 15;
@@ -443,7 +442,8 @@ public class PersistentPartitionedRegionDUnitTest extends PersistentPartitionedR
     }
     ex.remove();
   }
-  
+
+  @Category(FlakyTest.class) // GEODE-974
   public void testRevokeBeforeStartup() throws Throwable {
     IgnoredException.addIgnoredException("RevokeFailedException");
     Host host = Host.getHost(0);
@@ -1076,6 +1076,7 @@ public class PersistentPartitionedRegionDUnitTest extends PersistentPartitionedR
    * 1, we restore the same buckets when the
    * missing member comes back online.
    */
+  @Category(FlakyTest.class) // GEODE-1047
   public void testMissingMemberRedundancy1() {
     Host host = Host.getHost(0);
     VM vm0 = host.getVM(0);
@@ -1630,7 +1631,6 @@ public class PersistentPartitionedRegionDUnitTest extends PersistentPartitionedR
    * 5. Member A recovers, and gets stuck waiting for member B.
    * @throws Throwable 
   */
-  @Category(FlakyTest.class)
   public void testBug42226() throws Exception {
     Host host = Host.getHost(0);
     VM vm0 = host.getVM(0);

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java
index cd2788e..55686f3 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/management/UniversalMembershipListenerAdapterDUnitTest.java
@@ -63,7 +63,6 @@ import com.gemstone.gemfire.test.junit.categories.FlakyTest;
  *
  * @since 4.2.1
  */
-
 public class UniversalMembershipListenerAdapterDUnitTest extends ClientServerTestCase {
   protected static final boolean CLIENT = true;
   protected static final boolean SERVER = false;
@@ -702,7 +701,6 @@ public class UniversalMembershipListenerAdapterDUnitTest extends ClientServerTes
   /**
    * Tests notification of events for loner bridge clients in server process.
    */
-  //@Category(FlakyTest.class) // GEODE-1174
   public void testSystemClientEventsInServer() throws Exception {
      try {
        doTestSystemClientEventsInServer();

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
index b6692c7..58651e3 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
@@ -36,7 +36,6 @@ import javax.management.MalformedObjectNameException;
 import javax.management.ObjectName;
 
 import org.junit.Ignore;
-import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
@@ -68,12 +67,10 @@ import com.gemstone.gemfire.management.internal.cli.util.CommandStringBuilder;
 import com.gemstone.gemfire.test.dunit.Host;
 import com.gemstone.gemfire.test.dunit.SerializableCallable;
 import com.gemstone.gemfire.test.dunit.VM;
-import com.gemstone.gemfire.test.junit.Retry;
 import com.gemstone.gemfire.test.junit.categories.DistributedTest;
 import com.gemstone.gemfire.test.junit.categories.FlakyTest;
-import com.gemstone.gemfire.test.junit.rules.RetryRule;
 
-@Category({ DistributedTest.class, FlakyTest.class }) // GEODE-973
+@Category(DistributedTest.class)
 public class CreateAlterDestroyRegionCommandsDUnitTest extends CliCommandTestBase {
 
   private static final long serialVersionUID = 1L;
@@ -93,9 +90,6 @@ public class CreateAlterDestroyRegionCommandsDUnitTest extends CliCommandTestBas
 
   final List<String> filesToBeDeleted = new CopyOnWriteArrayList<String>();
 
-  @Rule
-  public RetryRule retryRule = new RetryRule();
-
   /**
    * Asserts that the "compressor" option for the "create region" command succeeds for a
recognized compressor.
    */
@@ -361,8 +355,8 @@ public class CreateAlterDestroyRegionCommandsDUnitTest extends CliCommandTestBas
     };
   }
 
+  @Category(FlakyTest.class) // GEODE-973: getRandomAvailablePort
   @Test
-  @Retry(2) // GEODE-973: getRandomAvailablePort
   public void testCreateRegion46391() throws IOException {
     createDefaultSetup(null); // GEODE-973: getRandomAvailablePort
     String command = CliStrings.CREATE_REGION + " --" + CliStrings.CREATE_REGION__REGION
+ "=" + this.region46391 + " --" + CliStrings.CREATE_REGION__REGIONSHORTCUT + "=REPLICATE";

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
index e8ee713..38b8736 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
@@ -69,6 +69,7 @@ import com.gemstone.gemfire.test.dunit.SerializableRunnable;
 import com.gemstone.gemfire.test.dunit.VM;
 import com.gemstone.gemfire.test.dunit.WaitCriterion;
 import com.gemstone.gemfire.test.junit.categories.DistributedTest;
+import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 
 /**
  * The DiskStoreCommandsDUnitTest class is a distributed test suite of test cases for testing
the disk store commands
@@ -831,6 +832,7 @@ public class DiskStoreCommandsDUnitTest extends CliCommandTestBase {
     assertEquals(true, resultAsString.contains(vm1Name));
   }
 
+  @Category(FlakyTest.class) // GEODE-1206: port already in use
   @Test
   public void testCreateDiskStore() {
     final String diskStore1Name = "testCreateDiskStore1";

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
index 1b0c9cf..6019213 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java
@@ -81,6 +81,7 @@ import com.gemstone.gemfire.test.dunit.SerializableRunnable;
 import com.gemstone.gemfire.test.dunit.VM;
 import com.gemstone.gemfire.test.dunit.WaitCriterion;
 import com.gemstone.gemfire.test.junit.categories.DistributedTest;
+import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 
 /**
  * Dunit class for testing gemfire data commands : get, put, remove, select, rebalance
@@ -1212,6 +1213,7 @@ public class GemfireDataCommandsDUnitTest extends CliCommandTestBase
{
     vm2.invoke(checkPutKeysInVM2);
   }
 
+  @Category(FlakyTest.class) // GEODE-1182: BindException
   @Test
   public void testGetLocateEntryJsonKeys() {
     final String keyPrefix = "testKey";

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java
index 123c3bc..68eee8b 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/IndexCommandsDUnitTest.java
@@ -55,7 +55,7 @@ import com.gemstone.gemfire.test.dunit.WaitCriterion;
 import com.gemstone.gemfire.test.junit.categories.DistributedTest;
 import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 
-@Category({ DistributedTest.class, FlakyTest.class }) // see GEODE-689, GEODE-1048
+@Category(DistributedTest.class)
 public class IndexCommandsDUnitTest extends CliCommandTestBase {
 
   private static final long serialVersionUID = 1L;
@@ -230,6 +230,7 @@ public class IndexCommandsDUnitTest extends CliCommandTestBase {
     assertTrue(resultAsString.contains(indexName));
   }
 
+  @Category(FlakyTest.class) // GEODE-1048
   @Test
   public void testCreateMultipleIndexes() {
     setupSystem();
@@ -264,6 +265,7 @@ public class IndexCommandsDUnitTest extends CliCommandTestBase {
     assertTrue(resultAsString.contains(indexName));
   }
 
+  @Category(FlakyTest.class) // GEODE-689
   @Test
   public void testClearMultipleIndexes() {
     setupSystem();

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java
index 1c6f141..250b6df 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/MiscellaneousCommandsDUnitTest.java
@@ -60,7 +60,7 @@ import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 /**
  * Dunit class for testing gemfire function commands : GC, Shutdown
  */
-@Category({ DistributedTest.class, FlakyTest.class }) // see GEODE-1034
+@Category(DistributedTest.class)
 public class MiscellaneousCommandsDUnitTest extends CliCommandTestBase {
 
   private static final long serialVersionUID = 1L;
@@ -78,6 +78,7 @@ public class MiscellaneousCommandsDUnitTest extends CliCommandTestBase {
     });
   }
 
+  @Category(FlakyTest.class) // GEODE-1034
   @Test
   public void testGCForGroup() {
     Properties localProps = new Properties();

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java
b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java
index b625cfa..d117e0b 100644
--- a/geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java
+++ b/geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java
@@ -26,6 +26,7 @@ import com.gemstone.gemfire.test.dunit.Host;
 import com.gemstone.gemfire.test.dunit.VM;
 import com.gemstone.gemfire.test.dunit.cache.internal.JUnit4CacheTestCase;
 import com.gemstone.gemfire.test.junit.categories.DistributedTest;
+import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 import com.gemstone.gemfire.util.test.TestUtil;
 import com.jayway.awaitility.Awaitility;
 import org.junit.After;
@@ -111,6 +112,7 @@ public class SharedConfigurationUsingDirDUnitTest extends JUnit4CacheTestCase
{
     }
   }
 
+  @Category(FlakyTest.class) // GEODE-1165: BindException
   @Test
   public void updateClusterConfigDirWithTwoLocatorsNoRollingServerRestart() throws Exception
{
     final int[] ports = AvailablePortHelper.getRandomAvailableTCPPorts(2);

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java
b/geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java
index ad1d530..d3ec953 100644
--- a/geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java
+++ b/geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java
@@ -83,7 +83,7 @@ import com.gemstone.gemfire.test.junit.categories.FlakyTest;
  * Dunit class for testing gemfire Client commands : list client , describe client 
  * @since 8.0
  */
-@Category(DistributedTest.class) // see GEODE-1034
+@Category(DistributedTest.class)
 public class ClientCommandsDUnitTest extends CliCommandTestBase {
 
   private static final long serialVersionUID = 1L;

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java
b/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java
index fe0e4c3..3e05530 100644
--- a/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java
+++ b/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java
@@ -41,6 +41,7 @@ import com.gemstone.gemfire.security.generator.DummyCredentialGenerator;
 import com.gemstone.gemfire.security.templates.UserPasswordAuthInit;
 import com.gemstone.gemfire.test.dunit.SerializableRunnable;
 import com.gemstone.gemfire.test.junit.categories.DistributedTest;
+import com.gemstone.gemfire.test.junit.categories.FlakyTest;
 import com.gemstone.gemfire.test.junit.categories.SecurityTest;
 
 /**
@@ -79,7 +80,8 @@ public class ClientAuthzObjectModDUnitTest extends ClientAuthorizationTestCase
{
     server1.invoke(registerInstantiator);
     server2.invoke(registerInstantiator);
   }
-  
+
+  @Category(FlakyTest.class) // GEODE-1228
   @Test
   public void testAllOpsObjectModWithFailover() throws Exception {
     OperationWithAction[] allOps = allOps();

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java
b/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java
index 5db15f0..cbda9f5 100644
--- a/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java
+++ b/geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java
@@ -46,14 +46,11 @@ import com.gemstone.gemfire.test.junit.rules.RetryRule;
  * 
  * @since 5.5
  */
-@Category({ DistributedTest.class, SecurityTest.class, FlakyTest.class}) // GEODE-693, GEODE-1009:
getRandomAvailablePort
+@Category({ DistributedTest.class, SecurityTest.class })
 public class ClientPostAuthorizationDUnitTest extends ClientAuthorizationTestCase {
 
-  @Rule
-  public RetryRule retryRule = new RetryRule();
-
+  @Category(FlakyTest.class) // GEODE-693: getRandomAvailablePort
   @Test
-  @Retry(2) // GEODE-693: getRandomAvailablePort
   public void testAllPostOps() throws Exception {
     OperationWithAction[] allOps = allOpsForTestAllPostOps();
 
@@ -114,8 +111,8 @@ public class ClientPostAuthorizationDUnitTest extends ClientAuthorizationTestCas
     }
   }
 
+  @Category(FlakyTest.class) // GEODE-1009: getRandomAvailablePort
   @Test
-  @Retry(2) // GEODE-1009: getRandomAvailablePort
   public void testAllOpsNotifications() throws Exception {
     OperationWithAction[] allOps = allOpsForTestAllOpsNotifications();
 

http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/877b5de8/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
----------------------------------------------------------------------
diff --git a/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
b/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
index e93c9c2..0f38441 100644
--- a/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
+++ b/geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
@@ -5073,7 +5073,7 @@ public class WANTestBase extends DistributedTestCase{
     }
     for (AsyncInvocation invocation : invocations) {
       invocation.join();
-      assertFalse(invocation.exceptionOccurred());
+      invocation.checkException();
     }
   }
 


Mime
View raw message