geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dschnei...@apache.org
Subject [05/38] incubator-geode git commit: changed TODO comment
Date Sat, 05 Mar 2016 00:51:05 GMT
changed TODO comment


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/4e127b8f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/4e127b8f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/4e127b8f

Branch: refs/heads/feature/GEODE-982
Commit: 4e127b8fa64f05c1bd6e2602641e7ff5e23ab223
Parents: af6a01d
Author: Darrel Schneider <dschneider@pivotal.io>
Authored: Thu Feb 25 14:07:14 2016 -0800
Committer: Darrel Schneider <dschneider@pivotal.io>
Committed: Thu Feb 25 14:07:14 2016 -0800

----------------------------------------------------------------------
 .../java/com/gemstone/gemfire/internal/offheap/ObjectChunk.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/4e127b8f/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ObjectChunk.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ObjectChunk.java
b/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ObjectChunk.java
index 840d8e5..878e87d 100644
--- a/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ObjectChunk.java
+++ b/geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ObjectChunk.java
@@ -158,7 +158,7 @@ import com.gemstone.gemfire.internal.offheap.annotations.Unretained;
       // Hopefully the jvm is smart enough to use our stack for this short lived array.
       final byte[] dataCache1 = new byte[1024];
       final byte[] dataCache2 = new byte[dataCache1.length];
-      // TODO OFFHEAP: no need to copy to heap. Just get the address of each and compare
each byte.
+      // TODO OFFHEAP: no need to copy to heap. Just get the address of each and compare
each byte. No need to call incReads when reading from address.
       int i;
       // inc it twice since we are reading two different off-heap objects
       SimpleMemoryAllocatorImpl.getAllocator().getStats().incReads();
@@ -199,7 +199,7 @@ import com.gemstone.gemfire.internal.offheap.annotations.Unretained;
       }
       // We want to be able to do this operation without copying any of the data into the
heap.
       // Hopefully the jvm is smart enough to use our stack for this short lived array.
-      // TODO OFFHEAP: compare as ByteBuffers?
+      // TODO OFFHEAP: no need to copy to heap. Just get the address of each and compare
each byte. No need to call incReads when reading from address.
       final byte[] dataCache = new byte[1024];
       int idx=0;
       int i;


Mime
View raw message