geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dschnei...@apache.org
Subject [47/52] [abbrv] incubator-geode git commit: GEODE-862: Suppress suspect log statement
Date Fri, 29 Jan 2016 01:17:04 GMT
GEODE-862: Suppress suspect log statement

Added a TODO to the code to clean this up further. I believe the removeNotificationListener
was being called as a form of tearDown near the end of the test but there are no registered
NotificationListeners and that's not what the test is testing.


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/a5437b2f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/a5437b2f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/a5437b2f

Branch: refs/heads/feature/GEODE-831
Commit: a5437b2fb1f379cd7713ef708095ba7b0ca2cfb9
Parents: c194f76
Author: Kirk Lund <klund@pivotal.io>
Authored: Thu Jan 28 10:43:41 2016 -0800
Committer: Kirk Lund <klund@pivotal.io>
Committed: Thu Jan 28 10:48:27 2016 -0800

----------------------------------------------------------------------
 .../gemstone/gemfire/management/DistributedSystemDUnitTest.java   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/a5437b2f/gemfire-core/src/test/java/com/gemstone/gemfire/management/DistributedSystemDUnitTest.java
----------------------------------------------------------------------
diff --git a/gemfire-core/src/test/java/com/gemstone/gemfire/management/DistributedSystemDUnitTest.java
b/gemfire-core/src/test/java/com/gemstone/gemfire/management/DistributedSystemDUnitTest.java
index 1a52f9b..f234e34 100644
--- a/gemfire-core/src/test/java/com/gemstone/gemfire/management/DistributedSystemDUnitTest.java
+++ b/gemfire-core/src/test/java/com/gemstone/gemfire/management/DistributedSystemDUnitTest.java
@@ -452,7 +452,8 @@ public class DistributedSystemDUnitTest extends ManagementTestBase {
           } catch (InstanceNotFoundException e) {
             getLogWriter().error(e);
           } catch (ListenerNotFoundException e) {
-            getLogWriter().error(e);
+            // TODO: apparently there is never a notification listener on any these mbeans
at this point 
+            // fix this test so it doesn't hit these unexpected exceptions -- getLogWriter().error(e);
           }
         }
       }


Mime
View raw message