geode-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jche...@apache.org
Subject incubator-geode git commit: GEODE-668 Improve GMSHealthMonitor logs to help debugging
Date Tue, 15 Dec 2015 22:52:29 GMT
Repository: incubator-geode
Updated Branches:
  refs/heads/develop df32ad1c6 -> e63ad64b6


GEODE-668 Improve GMSHealthMonitor logs to help debugging


Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/e63ad64b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/e63ad64b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/e63ad64b

Branch: refs/heads/develop
Commit: e63ad64b693c10f3de2809697a1b60eef8514e38
Parents: df32ad1
Author: Jianxia Chen <jchen@pivotal.io>
Authored: Tue Dec 15 14:51:31 2015 -0800
Committer: Jianxia Chen <jchen@pivotal.io>
Committed: Tue Dec 15 14:51:31 2015 -0800

----------------------------------------------------------------------
 .../internal/membership/gms/fd/GMSHealthMonitor.java      | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/e63ad64b/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
----------------------------------------------------------------------
diff --git a/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
b/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
index 8c38ba6..2aac935 100755
--- a/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
+++ b/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
@@ -514,7 +514,7 @@ public class GMSHealthMonitor implements HealthMonitor, MessageHandler
{
         GMSMember gmbr = (GMSMember) suspectMember.getNetMember();
         writeMemberToStream(gmbr, out);
         clientSocket.shutdownOutput();
-        logger.debug("Connected - reading response", suspectMember);
+        logger.debug("Connected - reading response from suspect member {}", suspectMember);
         int b = in.read();
         logger.debug("Received {}", (b == OK ? "OK" : (b == ERROR ? "ERROR" : b)), suspectMember);
         if (b == OK) {
@@ -531,7 +531,7 @@ public class GMSHealthMonitor implements HealthMonitor, MessageHandler
{
         return false;
       }
     } catch (SocketTimeoutException e) {
-      logger.debug("tcp/ip connection timed out");
+      logger.debug("Final check TCP/IP connection timed out for suspect member {}", suspectMember);
       return false;
     } catch (IOException e) {
       logger.trace("Unexpected exception", e);
@@ -1201,15 +1201,15 @@ public class GMSHealthMonitor implements HealthMonitor, MessageHandler
{
               if (!pinged && !isStopping) {
                 TimeStamp ts = memberTimeStamps.get(mbr);
                 if (ts == null || ts.getTime() <= startTime) {
-                  logger.info("Final check failed - requesting removal");
+                  logger.info("Final check failed - requesting removal of suspect member
" + mbr);
                   services.getJoinLeave().remove(mbr, reason);
                   failed = true;
                 } else {
-                  logger.info("check failed but detected recent message traffic");
+                  logger.info("Final check failed but detected recent message traffic for
suspect member " + mbr);
                 }
               }
               if (!failed) {
-                logger.info("Final check passed");
+                logger.info("Final check passed for suspect member " + mbr);
               }
               // whether it's alive or not, at this point we allow it to
               // be watched again


Mime
View raw message