Return-Path: X-Original-To: apmail-geode-commits-archive@minotaur.apache.org Delivered-To: apmail-geode-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D66918C9D for ; Wed, 11 Nov 2015 21:23:51 +0000 (UTC) Received: (qmail 15403 invoked by uid 500); 11 Nov 2015 21:23:51 -0000 Delivered-To: apmail-geode-commits-archive@geode.apache.org Received: (qmail 15370 invoked by uid 500); 11 Nov 2015 21:23:51 -0000 Mailing-List: contact commits-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list commits@geode.incubator.apache.org Received: (qmail 15361 invoked by uid 99); 11 Nov 2015 21:23:51 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Nov 2015 21:23:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F2403C3B84 for ; Wed, 11 Nov 2015 21:23:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.457 X-Spam-Level: X-Spam-Status: No, score=0.457 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.343] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id skzkxj93vAZr for ; Wed, 11 Nov 2015 21:23:35 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id DF10543C67 for ; Wed, 11 Nov 2015 21:23:34 +0000 (UTC) Received: (qmail 12416 invoked by uid 99); 11 Nov 2015 21:23:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Nov 2015 21:23:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 458FCE0AD2; Wed, 11 Nov 2015 21:23:34 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ashvin@apache.org To: commits@geode.incubator.apache.org Date: Wed, 11 Nov 2015 21:24:05 -0000 Message-Id: <9af674e619ce4e53b4cb517a50bae82c@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [33/50] [abbrv] incubator-geode git commit: Adding a TODO to LuceneIndexCreation about the attributes mutator Adding a TODO to LuceneIndexCreation about the attributes mutator We may need to do something different for replicated regions than what is being done here in onCreate. Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/7d50cf15 Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/7d50cf15 Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/7d50cf15 Branch: refs/heads/develop Commit: 7d50cf15b2d2bac36a046bb817d45b89bdcd69e7 Parents: 5d7535a Author: Dan Smith Authored: Thu Oct 15 16:20:54 2015 -0700 Committer: Dan Smith Committed: Fri Oct 16 12:46:55 2015 -0700 ---------------------------------------------------------------------- .../gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java | 2 ++ 1 file changed, 2 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/7d50cf15/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java ---------------------------------------------------------------------- diff --git a/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java b/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java index 3609ae8..b2f2645 100644 --- a/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java +++ b/gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java @@ -75,6 +75,8 @@ public class LuceneIndexCreation implements LuceneIndex, Extension> String aeqId = LuceneServiceImpl.getUniqueIndexName(getName(), getRegionPath()); //Here, it is safe to add the aeq with the mutator, because onCreate is //fired in a special place before the region is initialized. + //TODO - this may only work for PRs. We need to intercept the attributes + //before the region is created with a RegionListener. region.getAttributesMutator().addAsyncEventQueueId(aeqId); service.afterDataRegionCreated(getName(), new StandardAnalyzer(), getRegionPath(), getFieldNames()); }